[MediaWiki-CodeReview] [MediaWiki r100329]: New comment added
User Jpostlethwaite posted a comment on MediaWiki.r100329. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100329#c24613 Commit summary: Cleaned up documentation. Added public declaration to classes. Added stage_transaction_type() Comment: If a method is not defined as public, protected or private. It is public by default and backwards compatibility. It may be desired, at some point, to make some of these methods protected. This would need to be propagated up to the parent class. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100212]: New comment added
User Junaidpv posted a comment on MediaWiki.r100212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100212#c24614 Commit summary: New feature - provide all input methods for the user, dynamically load the input method rules. Bug 28474 Comment: Nice work! Showing big list can be avoided by arranging by language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100212]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r100212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100212#c24615 Commit summary: New feature - provide all input methods for the user, dynamically load the input method rules. Bug 28474 Comment: We will do it in next step. Even if we group by language, list is growing and it will be big. Need to prototype a new UI and it is planned. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99245]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r99245. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99245 Commit summary: Video, *the* Video extension. Some things haven't yet been implemented, see my wikitech-l post for details. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98772]: New comment added, and revision status changed
User FrequentPatternTagCloud changed the status of MediaWiki.r98772. Old Status: fixme New Status: new User FrequentPatternTagCloud also posted a comment on MediaWiki.r98772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98772#c24616 Commit summary: Fixing i18n topics of r98627 Comment: Fixed sql injection issue ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100334]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r100334. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100334 Commit summary: Narayam: Rename internal name of Tamil99 scheme, so every scheme follow same pattern of naming. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100335]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r100335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100335#c24617 Commit summary: Narayam: Correct comment, a copy paste mistake. Comment: make sure ta-bamini loads after ta - Why we need this ordering ? What happens if ta loads before ta-bamini? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100332]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r100332. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100332 Commit summary: Narayam: Fix consonant pattern in Tamil99 scheme. bug 31774 - Tamil 99 scheme has a bug ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99682]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r99682. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99682 Commit summary: Narayam: Update Amharic transliteration rules. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Proposed Authentication Schema for Wikimedia projects
Nice idea, but most users hate inputting a password/drawing on the screen to unlock it. So if you lose your phone or it gets stolen, all your credentials are lost and in the hands of an unknkown attacker. Also, phones tend to break during day-to-day usage (beverage spills, falls from desks). While these problems were mentioned on the design page, I have another scenario: colleague comes over to your desk, swaps your phone with his so you don't notice immediately, pranks you on Facebook or Wikipedia and then swaps the phone back. Marco On Tue, Oct 18, 2011 at 4:51 AM, packs-24...@mypacks.net wrote: I originally posted this idea on G+ and Arthur Richards suggested I cross-post it here. My friend, Isaac Potoczny-Jones is a computer security professional. He developed a new authentication schema that layers on top of existing technologies and leverages a user's smartphone and QRCodes to improve authentication usability, eliminate human-generated passwords, and further improve security by separating the authentication channel from the login session. He's calling this capability Animate Login and as part of the proof of concept, he developed a MediaWiki implementation. I believe the Wikimedia foundation should pursue adding this technique as part of the primary login options for it's projects. I would personally love to be able to just point my phone at the login screen and have the system log me in to Wikipedia without having to type anything or remember complex passwords. Wikimedia has worked hard to consolidate logins across the many projects over the last couple years and this would be a great way of providing seamless login. It should be very low overhead and relatively easy to implement. Isaac is very interested in seeing his tool put to use on Wikipedia. Wikimedia could lead the way to improved authentication that also vastly improves the user experience! Isaac explains the project in some detail on this Google Plus post: https://plus.google.com/u/0/112702172838704084335/posts/B9UR2zzDY3f?hl=en His landing page for the project is here: http://animate-innovations.com/content/animate-login The website has videos, links to a MediaWiki instance where its in use and more. From the conversations I've had with him, I know that he has thought long and hard about this application and has sought to address/understand all of the potential attack vectors. Compared to human-generated passwords, this would be vastly more secure and dramatically improve the user experience of logging in. It might even entice new or old editors to login and give it a try and thus re-engage them in editing. I'm also certain it could generate a fair bit of buzz as people learn they can use their smartphone to login to Wikipedia. I hope you'll consider working with Isaac. I'll point him to this thread so he knows it is here. I know he'd love to see this implemented in Wikipedia. Don ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100335]: New comment added
User Junaidpv posted a comment on MediaWiki.r100335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100335#c24618 Commit summary: Narayam: Correct comment, a copy paste mistake. Comment: Currently there is no 'legal' way of ordering schemes, but it was accomplished earlier for Tamil by r93711. Actually there should be no dependencies between schemes and this should be corrected. For Malayalam it was accomplished by r84379. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100348]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r100348. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100348#c24619 Commit summary: Revert r79363, r79364, and r79369 to disable datalists support entirely based on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's comments in http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html Comment: I meant Bug 31768, not Bug 31658 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100349]: Revision status changed
User ^demon changed the status of MediaWiki.r100349. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100349 Commit summary: eol w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] WikiEditor dialogs and caching? (fwd)
Roan writes: This is probably a ResourceLoader thing, then, not directly related to WikiEditor. Please try waiting 5-10 minutes for the cached version of the startup module (the request with modules=startup) to expire (it has s-maxage=300, max-age=300), then RL should request your module with an updated timestamp and that should give you the new version. Also, verify that the filesystem timestamp of the file has changed after you updated it, because that's what RL uses to determine whether a file has changed. Thanks. Below are the HTTP headers for the modules=startup load. I waited 30 minutes after changing the JavaScript file but the change is still not appearing in WikiEditor, even after browser refreshes. I also confirmed that the file timestamp has indeed changed. Any other ideas? http://myhost.net/w/load.php?debug=falselang=enmodules=startuponly=scriptsskin=vector* GET /w/load.php?debug=falselang=enmodules=startuponly=scriptsskin=vector* HTTP/1.1 Host: myhost.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 Accept: */* Accept-Language: en-us,en;q=0.5 Accept-Encoding: gzip, deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Connection: keep-alive Referer: http://myhost.net/w/index.php?title=Temp:Testaction=editredlink=1 Cookie: autoloadapplet=1; killoptions=1; wikidb_vpw_office_id=2; vector-nav-p-tb=true; _pk_id.3.07be=89b57d07f8d247a6.1318020769.20.1319123488.1318951711.; edittoolscharsubset=0; wikiEditor-0-booklet-help-page=format; wikidb_vpw__session=i0avdgi2p9fn7g0mgosjenftq3; wikiEditor-0-toolbar-section=software; _pk_ses.3.07be=* If-Modified-Since: Thu, 20 Oct 2011 14:52:51 GMT Cache-Control: max-age=0 HTTP/1.1 200 OK Date: Thu, 20 Oct 2011 15:14:55 GMT Server: Apache/2.2.3 (CentOS) X-Powered-By: PHP/5.3.3 Last-Modified: Thu, 20 Oct 2011 14:52:51 GMT Cache-Control: public, max-age=300, s-maxage=300 Expires: Thu, 20 Oct 2011 15:19:55 GMT Content-Encoding: gzip Vary: Accept-Encoding Content-Length: 3232 Connection: close Content-Type: text/javascript; charset=utf-8 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WikiEditor dialogs and caching? (fwd)
I waited 30 minutes after changing the JavaScript file but the change is still not appearing in WikiEditor, even after browser refreshes. Hmmm... after about 60 minutes, the change showed up (after a hard refresh) in WikiEditor. Any idea why it took so long? DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99682]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r99682. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99682 Commit summary: Narayam: Update Amharic transliteration rules. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79363]: New comment added
User Krinkle posted a comment on MediaWiki.r79363. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79363#c24620 Commit summary: Enable mwsuggest datalist implementation Tested in Firefox 4.0b8, which is the only browser it will trigger for due to the feature test. Opera is explicitly blacklisted for the reason given in the comment. This feature was added in r61348 but remained disabled by default because no browser actually supported it properly (due to Opera's bug). Of course, this is somewhat obsolescent given the fancy new Vector search, but it's a two-line change, so why not. I was reminded of this by Jonas Sicking, a Firefox developer, remarking on how datalist should indeed be usable for this purpose in Firefox 4: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029577.html Comment: smalltest test test/small ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100314]: Revision status changed
User Reedy changed the status of MediaWiki.r100314. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100314 Commit summary: slice, not splice and made getUser a bit more robust ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Security manual and pages
Hi, most of you already know about the small virtual library of MediaWiki books (collections) on http://www.mediawiki.org/wiki/MVL I recently added links to the project site of OWASP to our security pages https://www.owasp.org/ Open Web Application Security Project (OWASP) because I like the OWASP site and this is a useful addition to information we already have. T. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WikiEditor dialogs and caching? (fwd)
Hmmm... after about 60 minutes, the change showed up (after a hard refresh) in WikiEditor. Any idea why it took so long? Something really weird is going on with caching and ResourceLoader/WikiEditor. Originally my JavaScript file (loaded via ResourceLoader) emitted the string A. I changed it to B and an hour later, the B became visible. Then I changed it to C, refreshed my browser, and the string A appeared again!! Any ideas? Thanks, DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Android App Triage
What: Android App triage When: Wednesday, Oct 26, 16:00UTC Time zone conversion: http://hexm.de/8h Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev if you don't have an IRC client Next Wednesday, I'll be holding a triage on the Android App for our mobile development team working top-down with the bugs listed on http://etherpad.wikimedia.org/BugTriage-2011-10. If you've forked the github repo (https://github.com/nitobi/Wikipedia), downloaded the app, or if you would like to help solve issues with it, then please join us. Thanks! -- Mark A. Hershberger Bugmeister Wikimedia Foundation mhershber...@wikimedia.org 717.271.1084 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] File::getPath() refactoring
On Wed, Oct 19, 2011 at 12:55 PM, Happy Melon happy.melon.w...@gmail.comwrote: On 19 October 2011 20:41, Russell Nelson russnel...@gmail.com wrote: In order to support viewing deleted files (currently a blocker bug in SwiftMedia), I'm going to refactor File::getPath() into a new public function File::getLocalPath(), which will return an instance of a new class TempLocalPath, which will have two methods: getPath(), and close(). This class will own a local copy of the file. When it goes out of scope or its close() method is called (same thing), any resources held by the class will be freed. Is there a more standardised name than close? dispose is pretty common in compiled languages; do we have any sort of standard for that behaviour within MW? If not, is this a good opportunity to create one? We have free() on things like database result wrappers; I'd probably stick with that. Generally though nobody has to call these explicitly as the runtime's reference counting auto-destroys objects once they fall out of use, and the destructor calls it for us. As Tim noted, the particular case in Special:Undelete is probably an example of old code using a lazy interface due to old assumptions, and should actually be changed to use a proper File reference, and have a method to call from the File object / via the FileRepo/FileBackend that wraps streaming output so it doesn't actually need to do a file checkout. This didn't come up as much for ForeignAPIRepo because we do fewer direct operations on files from non-local repositories: we leave metadata lookups and thumbnailing to the foreign site, so don't have to pass the file into MediaHandler's shell-outs. We don't stream restricted or deleted files out because we don't manage their deletion/undeletion or security. On Wed, Oct 19, 2011 at 3:06 PM, Platonides platoni...@gmail.com wrote: Why is this needed? A FileSwift class which needed to fetch the file from Swift could acquire it when calling getPath(), and have it deleted on FileSwift destruction (getPath() is usually called from several methods, so it isn't practical to acquire and destroy every time). I would broadly warn against unnecessarily checking files out to a local filesystem: while this is fairly cheap with tiny JPEGs and PNG diagrams, and feels cheap on modern computers for several-megabyte photos, it's still potentially very expensive for multi-hundred-meg and multi-gigabyte video files. Any time we are copying to a local file, we should be sure that we *really mean it*. A getPath() that implicitly copies files makes me uneasy... I might actually recommend putting a deprecation warning on it to help find and reduce these. A more explicit check-out / discard interface will let us keep existing code like our thumbnailing that does need to deal with local files, without hiding that it's a potentially expensive operation. And that can encourage us to move things towards interfaces that don't need to check files out, but can read them as streams or skip expensive original-file checks in the first place when they're not really needed. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100350]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r100350. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r100350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100350#c24621 Commit summary: Narayam: Remember dynamically loaded scheme next time utilizing cookie entry. bug 31846 - Remember dynamically loaded scheme selection. Comment: PHP Notice: Undefined index: narayam-scheme in /www/w/extensions/Narayam/Narayam.hooks.php on line 71 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100350]: New comment added
User Junaidpv posted a comment on MediaWiki.r100350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100350#c24622 Commit summary: Narayam: Remember dynamically loaded scheme next time utilizing cookie entry. bug 31846 - Remember dynamically loaded scheme selection. Comment: Fixed r100361. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100350]: Revision status changed
User Raymond changed the status of MediaWiki.r100350. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100350 Commit summary: Narayam: Remember dynamically loaded scheme next time utilizing cookie entry. bug 31846 - Remember dynamically loaded scheme selection. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100373]: New comment added
User Reedy posted a comment on MediaWiki.r100373. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100373#c24623 Commit summary: REL1_18: MFT r98962, r98971, r99004, r99065 Comment: Looks like r99065 was already merged in somewhere ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100374]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r100374. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r100374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100374#c24624 Commit summary: [JSTesting] Re-branch from trunk. Going to commit a new start-patch for bug 30339. The patch I had attached to bug 30339 (committed as start-commit for this branch in r100340 by hasher) was outdated. Sorry for not having committed my local progress. Comment: Congratulations on your svn branching \o/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100374]: New comment added
User Krinkle posted a comment on MediaWiki.r100374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100374#c24625 Commit summary: [JSTesting] Re-branch from trunk. Going to commit a new start-patch for bug 30339. The patch I had attached to bug 30339 (committed as start-commit for this branch in r100340 by hasher) was outdated. Sorry for not having committed my local progress. Comment: Thanks :) Looks like it went OK. The diff in CoreReview seems a bit confusing though, it's making me think it's loading a huge diff but it's not doing anything. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100374]: New comment added
User Hashar posted a comment on MediaWiki.r100374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100374#c24626 Commit summary: [JSTesting] Re-branch from trunk. Going to commit a new start-patch for bug 30339. The patch I had attached to bug 30339 (committed as start-commit for this branch in r100340 by hasher) was outdated. Sorry for not having committed my local progress. Comment: It most probably receive an error from the API, something like svn diff impossible for file copy. Bug Reedy about it :-D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Heads up: Online coding challenge
Seems like were not the only ones thinking about challenges http://developers.slashdot.org/story/11/10/20/2025241/gnarly-programming-challenges-help-recruit-coders --tomasz On Wed, Oct 19, 2011 at 7:36 PM, Erik Moeller e...@wikimedia.org wrote: Following up, we'd appreciate help with testing the coding challenge workflow. This is a DRAFT ONLY -- here's the current draft workflow: http://www.mediawiki.org/wiki/Special:ContestWelcome/Draft_October_2011_Coding_Challenge Any data you submit through it will be lost, messaging is subject to change, and any email address you provide may receive notices as we test the workflow. :-) The contest rules are just a placeholder right now; we'll finalize them tomorrow. You can report bugs or post comments here or on http://www.mediawiki.org/wiki/Talk:October_2011_Coding_Challenge Thanks! Erik -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100382]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r100382.
Old Status: deferred
New Status: fixme
User Siebrand also posted a comment on MediaWiki.r100382.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100382#c24627
Commit summary:
applied patch by Van de Bugger from bug 31830
Comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100255]: New comment added
User Vigilius posted a comment on MediaWiki.r100255. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100255#c24628 Commit summary: Tweak messages. Comment: remove tag ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100227]: New comment added
User Platonides posted a comment on MediaWiki.r100227. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100227#c24629 Commit summary: * Changed ParserOptions to store a Language object instead of only a string, avoids object - string - object conversion * ParserOptions::getUserLang() will still return a string for compatibility, added ParserOptions::getUserLangObj() to get the object * Added ParserOptions::newFromUserAndLang() and ParserOptions::newFromContext() to easily get a ParserOptions object when a context is available or when someone wants to force the language * Updated OutputPage and Preferences to use newFromContext() and WikiPage to use newFromUserAndLang() * ParserOptions::setUserLang() still accepts either a string or a Language object, but changed the calls to pass an object instead of a string * Changed Parser::getFunctionLang() to return the Language object from ParserOptions when parsing interface messages rather than $wgLang directly and updated the documentation to say that $wgLang should not be used directly (as $wgUser, $wgTitle and $wgRequest) Comment: It seems to do the stated job, but... why? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100368]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r100368.
Old Status: new
New Status: fixme
User Siebrand also posted a comment on MediaWiki.r100368.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100368#c24630
Commit summary:
somewhat cleaned-up version of
https://svn.wikia-code.com/wikia/trunk/extensions/wikia/SpecialBatchUserRights/
(r43851) at Kevin's request
Comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100255]: New comment added
User Siebrand posted a comment on MediaWiki.r100255. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100255#c24631 Commit summary: Tweak messages. Comment: Done ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100346]: Revision status changed
User Siebrand changed the status of MediaWiki.r100346. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100346 Commit summary: Followup r100243: prevent reviewing fuzzy messages Internationalization/#128 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100188]: Revision status changed
User Platonides changed the status of MediaWiki.r100188. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100188 Commit summary: Follow up r100186: Removing mistakenly placed comma ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r649]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r649. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/649 Commit summary: mingle analytics #232 - fix rates in live results to reflect only times until which impressions have been loaded modified summary results query, determine end time of latest squid impression log ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r629]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r629. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/629 Commit summary: fixed paths in test and camapaign django app view modules ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r630]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r630. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/630 Commit summary: minor cosmetic change to teble summary template ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r631]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r631. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/631 Commit summary: mingle analytics #226 - order live landing page for analytics reporting by country ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r632]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r632. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/632 Commit summary: modified slightly the colour scheme for confidence testing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r633]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r633. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/633 Commit summary: mingle analytics #227 - indicate the items being comapred in hypothesis testing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r635]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r635. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/635 Commit summary: small fix to live banner link in query ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r637]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r637. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/637 Commit summary: fixed evaluation of args for log mining script schell ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r638]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r638. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/638 Commit summary: mingle analytics #228 - bug fix: some reports are generated with zeroed data for artifacts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r639]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r639. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/639 Commit summary: minor fix, removed regexp ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r640]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/640 Commit summary: mingle analytics #229 - feature fix: allow test-type to be set before execution modified django template and form processing to reload show campaigns view with alternative test type ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r641]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/641 Commit summary: mingle analytics #230 - fix report summary (% increase) based the calculation on summary rather than sampled values ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r645]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r645. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/645 Commit summary: simplified log mining logs views. removed user functionality to copy logs and mine new logs - this is access that should not be public ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r647]: Revision status changed
User Pgehres (WMF) changed the status of Wikimedia.r647. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/647 Commit summary: removed deprecated SQL queries ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100368]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r100368. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100368 Commit summary: somewhat cleaned-up version of https://svn.wikia-code.com/wikia/trunk/extensions/wikia/SpecialBatchUserRights/ (r43851) at Kevin's request ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Welcoming Amir Aharoni
Hi All, Please join me in welcoming Amir Aharoni as a Software Developer in WMF’s Features Engineering team. Amir will be joining Niklas Laxstrom, Santhosh Thottingal, Siebrand Mazeland and Gerard Meijssen on the Internationalization / Localization features team to add RTL expertise to build and improve language support tools and technologies for reading and editing Wikipedia in all supported languages. Amir was born in Moscow in 1980 and immigrated to Israel in 1991. He speaks fluent Russian, Hebrew and English, as well as nearly fluent Catalan and he can also read a few other languages, including Latin, Lithuanian, Amharic and Malayalam. He's quite happy and proud about all his different cultural backgrounds and identities and finds them quite useful, too. He dreamt about being a linguist, an encyclopedia and dictionary writer and a programmer since he was five years old. Really. So, this opportunity makes his earliest childhood dreams come true at one fell swoop. Amir has two bookcases full of dictionaries and grammar books of various languages and he keeps buying at least one dictionary of the local language of every country he visits, as well as a couple of fiction books to use the dictionaries with. He also still loves buying CDs and vinyl records and has very little patience for e-book readers and digital music players, especially if they have DRM features or don't support all Unicode scripts. You will rarely catch him not listening to music; he also plays the piano and can strum a couple of guitar chords. Amir lived for several years in Haifa, the host of Wikimania 2011, and now he lives in a village near Jerusalem. He regularly blogs in Hebrew, English and Russian. Amir is passionate about Free Software since he first heard about it in a lecture in 1998. He has edited Wikipedia in several languages since 2004, but the project about which he is most proud is editing the heavily cross-referenced version of Gesenius' Hebrew Grammar at the English Wikisource. He reported many MediaWiki bugs and sent a few patches. He's a member of the Wikimedia Language committee and a board member of Wikimedia Israel. He has zero patience for incorrectly displayed right-to-left strings in any software, but you probably knew that about him already (if you've met him in person). Say hello to Amir online. He’s usually available on our favorite irc channels including #mediawiki Welcome Amir! -- Alolita Sharma Director, Features Engineering Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r650]: Revision status changed
User Awjrichards changed the status of Wikimedia.r650. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/650 Commit summary: Adding passthrough for preferred_language as lang_COUNTRY. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r651]: Revision status changed
User Awjrichards changed the status of Wikimedia.r651. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/651 Commit summary: Normalization on the preferred_language field due to CiviCRM's contraints ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Welcoming Amir Aharoni
This is great! Welcome, Amir. Looking forward to working with you even more. :-) Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100397]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r100397. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r100397. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100397#c24632 Commit summary: Adding js error message loading to payflowpro gateway Comment: This magic and the magic that generates it should be abstracted and ResourceLoader-ified ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100382]: Revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r100382. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100382 Commit summary: applied patch by Van de Bugger from bug 31830 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100392]: New comment added
User Reedy posted a comment on MediaWiki.r100392.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100392#c24633
Commit summary:
[JSTesting] Initial stab at implementing on-wiki running of unit tests with
QUnit.
* Using a SpecialPage, Special:JavaScriptTest
* Disabled by default (both because it's a new feature and because tests can
potentially make edits or do bad stuff not wanted on a production wiki)
* Extensions can register a test suite by registering their test suite as a
regular module (e.g. 'ext.fooBar.test'), with a dependency on the module(s)
being tested.
code
$wgHooks['ResourceLoaderTestModules'][] =
'FooBarHooks::resourceLoaderTestModules';
--- FooBar.hooks.php
public static function resourceLoaderTestModules( $testModules,
$resourceLoader ) {
$testModules['qunit']['ext.fooBar.test'] = array(
'scripts' = 'resources/ext.fooBar.test.js',
'dependencies' = array(
'ext.fooBar.editor',
'ext.fooBar.api',
),
'remoteExtPath' = 'FooBar',
'localBasePath' = __DIR__,
);
return true;
}
/code
* MFT r100386
Comment:
svn:eol-style native
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Coding challenge about to land. :)
Hello all. We are about to kick off the October 2011 Coding Challenge, to which Erik alluded in his emails yesterday. I just wanted to offer a brief word of thanks to all at Wikimedia who have helped to put this together, and express my sense of what it is that we're doing. This is an experiment. It may be brilliant, or it may not be. Offering a big prize for challenge winners may be a master stroke, or it may be a terrible mistake. The contest may yield lots of smart developers or lots of clueless noobs. There may be a torrent of new voices overwhelming #mediawiki and wikitech-l, or there may be no one at all. I have no idea what to expect, and I'm not about to pretend otherwise. I will be fascinated to see how the next few weeks play out. One thing I am confident about: from everything I've observed about the Wikimedia technical community so far, I'm not the least bit worried about how noobs will be received. In some communities, this would be a note begging everyone to please, *please* not be to mean to the noobs -- but in this community, I only feel obliged to thank all of you in advance for being helpful and patient, as I know you will be. If you have any questions or concerns about the contest, feel free to raise them here on the list, or address them to me personally. --g ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Welcome, Antoine Musso! (hashar)
Hi everyone, A belated (re-)welcome to Antoine Musso (a.k.a. hashar on IRC) as a contractor working on continuous integration (e.g. beefing up our unit tests, improving our Jenkins configuration, figuring out how to integrate TestSwarm, etc). Antoine has been working in our community for quite some time, going by the name Ashar Voultoiz on mailing lists, and by hashar on IRC.Now that he's working as a contractor for WMF, he's decided to let everyone know the Superman behind the Clark Kent alter ego :) You've probably already seen him be even more active (if that were possible) in SVN and elsewhere since Monday, which is when he officially started. Welcome, Antoine! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83795]: New comment added
User MZMcBride posted a comment on MediaWiki.r83795. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83795#c24634 Commit summary: Follow-up r83794, r83792: restore new SpecialBlock.php code from r83786. This revision should *not* be broken :D Comment: Does this cause bug 31851? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100402]: Revision status changed
User Reedy changed the status of MediaWiki.r100402. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100402 Commit summary: use master db after submission so results do not get omitted due to rep lag ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100368]: Revision status changed
User Siebrand changed the status of MediaWiki.r100368. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100368 Commit summary: somewhat cleaned-up version of https://svn.wikia-code.com/wikia/trunk/extensions/wikia/SpecialBatchUserRights/ (r43851) at Kevin's request ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Coding challenge about to land. :)
Would I sound like a reactionary old crank if I asked why the coding challenge welcome page requires JavaScript? Without it, one can't even see the list of challenges! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Coding challenge about to land. :)
No. You'd sound like an ideal tester hitting a use case we didn't even consider. Will look into it. --g On Oct 20, 2011 8:29 PM, Steve Summit s...@eskimo.com wrote: Would I sound like a reactionary old crank if I asked why the coding challenge welcome page requires JavaScript? Without it, one can't even see the list of challenges! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] wikipedia lacks a share' button
Gentlemen, where is the Share button? All other sites have them by now, but on Wikipedia one cannot even find its definition in http://en.wikipedia.org/wiki/Share . At least on ones account preferences there should be a way to activate sharing with the following websites ... causing a share button to appear in the navigation menu. If there is an extension, then wikipedia should install it and not depend on browser plugins, etc. OK, I made https://bugzilla.wikimedia.org/show_bug.cgi?id=31853 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99323]: Revision status changed
User Tim Starling changed the status of MediaWiki.r99323. Old Status: ok New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99323 Commit summary: * Only spread blocks on page edit/move attempts via spreadAnyEditBlock(). We don't want to spread everytime the user's block status is checked as the user may just be viewing something rather than attempting to do anything. For example, if the 'edit' tab were changed to reflect block status, the autoblocks would trigger by a user just *looking* at the page. An example in the wild would be the UI checks in r93246. * Made spreadBlock() protected, no outside callers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99193]: Revision status changed
User Tim Starling changed the status of MediaWiki.r99193. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99193 Commit summary: FU r99187: * Added begin()/commit() as needed * Do the deletions in batches * Use addQuotes() as needed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99349]: Revision status changed
User Tim Starling changed the status of MediaWiki.r99349. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99349 Commit summary: FU r99323: spread blocks for edit/move attempts via the API (which uses these functions) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99323]: Revision status changed
User Tim Starling changed the status of MediaWiki.r99323. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99323 Commit summary: * Only spread blocks on page edit/move attempts via spreadAnyEditBlock(). We don't want to spread everytime the user's block status is checked as the user may just be viewing something rather than attempting to do anything. For example, if the 'edit' tab were changed to reflect block status, the autoblocks would trigger by a user just *looking* at the page. An example in the wild would be the UI checks in r93246. * Made spreadBlock() protected, no outside callers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100408]: New comment added
User Jpostlethwaite posted a comment on MediaWiki.r100408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100408#c24635 Commit summary: Documentation cleanup. Added public declarations to methods. Comment: This is the beginning of a code checkin. More files to come. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] wikipedia lacks a share' button
Some relevant links and notes: https://strategy.wikimedia.org/wiki/Product_Whitepaper#Red_link:_Post_to_social_media_feeds http://www.mediawiki.org/wiki/User:Dantman/Post_to_social_media_feeds On Thu, 20 Oct 2011 21:50:41 -0700, Alolita Sharma asha...@wikimedia.org wrote: It is time to write a gadget or extension for sharing Check out the Coding Challenge at http://www.mediawiki.org/wiki/Special:ContestWelcome/October_2011_Coding_Challenge and select Challenge #2 Making Wikipedia More Alive to enter your solution for sharing on Wikipedia :-) Alolita On Thu, Oct 20, 2011 at 9:22 PM, Jeremy Baron jer...@tuxmachine.com wrote: On Fri, Oct 21, 2011 at 00:13, Jeremy Baron jer...@tuxmachine.com wrote: Hi, On Thu, Oct 20, 2011 at 23:54, jida...@jidanni.org wrote: Gentlemen, where is the Share button? [...] OK, I made https://bugzilla.wikimedia.org/show_bug.cgi?id=31853 Your bug has been duped to Bug 27027[0] `Share button in Wikipedia:` which in turn links to enwiki discussion[1]. (I think there have been several onwiki/mailing list discussions actually) -Jeremy [0] https://bugzilla.wikimedia.org/show_bug.cgi?id=27027 [1] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29/Archive_83#Revisiting_social_media_links See also, this thread: http://lists.wikimedia.org/pipermail/commons-l/2010-October/005673.html http://lists.wikimedia.org/pipermail/commons-l/2010-August/thread.html#5614 -Jeremy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100350]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r100350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100350#c24636 Commit summary: Narayam: Remember dynamically loaded scheme next time utilizing cookie entry. bug 31846 - Remember dynamically loaded scheme selection. Comment: r100412 changed $_COOKIE. to $wgRequest-getCookie ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100350]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r100350. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100350 Commit summary: Narayam: Remember dynamically loaded scheme next time utilizing cookie entry. bug 31846 - Remember dynamically loaded scheme selection. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100361]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r100361. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100361#c24637 Commit summary: Narayam: Fix undefined index issue in r100350. Comment: r100412 changed $_COOKIE. to $wgRequest-getCookie ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100361]: Revision status changed
User Santhosh.thottingal changed the status of MediaWiki.r100361. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100361 Commit summary: Narayam: Fix undefined index issue in r100350. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
