[MediaWiki-CodeReview] [MediaWiki r104194]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104194.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104194
Commit summary:

Localisation updates for ToolserverI18N from translatewiki.net

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104159]: New comment added

2011-11-25 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r104159.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104159#c26537
Commit summary:

Limit the Narayam menu height so that it doesn't overflow the screen - had to 
increase padding to accommodate the scrollbars.

Comment:

IE7 and 8 are just broken. Need to revert or make special fix for them.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104159]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104159.

Old Status: new
New Status: fixme

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104159
Commit summary:

Limit the Narayam menu height so that it doesn't overflow the screen - had to 
increase padding to accommodate the scrollbars.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102501]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r102501.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102501
Commit summary:

Fix Narayam UI in modern skin.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Bugzilla vandalism

2011-11-25 Thread Bryan Tong Minh
On Fri, Nov 25, 2011 at 8:56 AM, Ariel T. Glenn ar...@wikimedia.org wrote:

 Στις 24-11-2011, ημέρα Πεμ, και ώρα 21:30 +0100, ο/η Daniel Zahn έγραψε:
  On Thu, Nov 24, 2011 at 8:15 PM, Rob Lanphier ro...@wikimedia.org wrote:
   So, here's the solution for now, and probably for a while:
  
   1.  New account creation has been re-enabled
   2.  All existing accounts have been explicitly given the editbugs 
   permission
   3.  New accounts only get the ability to file bugs, comment on bugs,
   and mark bugs as confirmed
 
  Nice! Thanks apergos and robla.
  @Antoine:I have mailed Annaïg to try again now.
 

 Not so nice, as it turns out. They were back today adding and removing
 people from CC lists. I've disabled new account creation again, the two
 accounts they created are blocked, and Siebrand cleaned up the bugs,
 about 80 of them.

There is also another, impersonating brion, which does not appear to
have been cleaned up.


Bryan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Bugzilla vandalism

2011-11-25 Thread K. Peachey
On Fri, Nov 25, 2011 at 7:06 PM, Bryan Tong Minh
bryan.tongm...@gmail.com wrote:
 There is also another, impersonating brion, which does not appear to
 have been cleaned up.
Most of that has been (Its what Ariel was referring to just before),
But it was done mostly with email off to prevent people getting
flooded with bogus./unwanted emails about it.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added

2011-11-25 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r102160.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c26538
Commit summary:

Merging ReferenceTooltips into Cite step 2: rename/register

Comment:

Anyone know if there will be compatibility issues with popups navigator ?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104199]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104199.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104199
Commit summary:

qqq docs, follow up to r104189 r104188 r104176

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Bugzilla vandalism

2011-11-25 Thread Ariel T. Glenn
Στις 25-11-2011, ημέρα Παρ, και ώρα 19:08 +1000, ο/η K. Peachey έγραψε:
 On Fri, Nov 25, 2011 at 7:06 PM, Bryan Tong Minh
 bryan.tongm...@gmail.com wrote:
  There is also another, impersonating brion, which does not appear to
  have been cleaned up.
 Most of that has been (Its what Ariel was referring to just before),
 But it was done mostly with email off to prevent people getting
 flooded with bogus./unwanted emails about it.

Fixed about another 40 of those.  That should be the lot of them.

Ariel



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r98493]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98493.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98493
Commit summary:

Trim trailing whitespace

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98494]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98494.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98494
Commit summary:

Add method for adding extensions to a release tarball

Untested, and not actually put into use yet

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98514]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98514.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98514
Commit summary:

Fix path from r98494

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98516]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98516.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98516
Commit summary:

Improvement on r98515, give an array of extensions to include (hard coded) and 
then iterate over that to include multiple extensions

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98515]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98515.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98515
Commit summary:

*(bug 26261) Bundle ParserFunctions extension with MediaWiki


Fuck. Yeah.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98515]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98515.

Old Status: ok
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98515
Commit summary:

*(bug 26261) Bundle ParserFunctions extension with MediaWiki


Fuck. Yeah.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103507]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103507.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103507
Commit summary:

Don't attempt to diff zips or xmp files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100366]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100366.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100366
Commit summary:

Also bundle ConfirmEdit, Gadgets, Nuke, RenameUser and WikiEditor

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103326]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r103326.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103326#c26539
Commit summary:

Export extensions of old version also

Don't diff gif or svg

Comment:

Why not SVG? Aren't they XML files? :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Final mobile switch-over

2011-11-25 Thread Tomasz Finc
On Thu, Nov 24, 2011 at 2:41 AM, Strainu strain...@gmail.com wrote:

 I've logged this as an enhancement:
 https://bugzilla.wikimedia.org/show_bug.cgi?id=32597


Thanks!


 It's a shame we have to go through some not-so-nice hacks to make the
 content for mobiles different than the one for desktops. Perhaps the
 architecture is too iPhone/American oriented? Not all mobile users


Are XML DOM parsers that American and iPhone centric? I sure hope not as
the rest of the Internet is going to have to be informed ...


 have unlimited traffic. Many people around me disable images on mobile
 internet.


Yup, and thats why we've had the option to disable images for many months
now. It lowered the payload by half. Lots of people use it. If you see
other data heavy features on pages that we can get rid of then please file
a bug. Were always eager to lower our payload.

Hope you will give that some serious thought when the time comes.


We already have and would love to drop it down even more. Next interesting
step would actually be to load sections only when people want them. That'll
drop down the payload even more.

Turn on the webkit network profiler and let us know whats really slowing us
down.

--tomasz
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r102208]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102208.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102208
Commit summary:

Followup r102201, quote all variables to guard against paths with spaces in 
them.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102201]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r102201.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102201#c26540
Commit summary:

Commit maintenance/dev/ a set of bash scripts that can quickly download php 
5.4, install it in an isolated area, install a quick development copy of 
MediaWiki, and then start up a local webserver.

Comment:

Petrb, even if you do not have commit rights on trunk/phase3, your comments are 
always welcome!  That is probably the best way to learn about the code so be 
bold and do ask questions whenever something looks suspicious :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102201]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r102201.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102201#c26541
Commit summary:

Commit maintenance/dev/ a set of bash scripts that can quickly download php 
5.4, install it in an isolated area, install a quick development copy of 
MediaWiki, and then start up a local webserver.

Comment:

Dantman, I think those .sh scripts could be merged in a Makefile. That is 
probably easier to handle in the long time.

Or we could use pake instead of make ( https://github.com/indeyets/pake/wiki ) 
which would make the makefile/scritps usable on windows. It is available from 
PEAR.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r96985]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96985.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96985
Commit summary:

fix for mismatched div

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r97305]: New comment added, and revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97305.

Old Status: new
New Status: ok

User Hashar also posted a comment on MediaWiki.r97305.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97305#c26542
Commit summary:

add a version to js to bust cache

Comment:

The only bad thing is that you might be forgetting to update the version number 
when editing the .js file :)

You might use a global variable to easily update that version number in all 
your code. Much like http://www.mediawiki.org/wiki/Manual:$wgStyleVersion in 
core.



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104130]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104130.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104130
Commit summary:

remove root username

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98657]: New comment added

2011-11-25 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r98657.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98657#c26543
Commit summary:

Revert r98355 and r98357; drop the field instead.

Comment:

No, ALTER TABLE in SQLite is very limited. See 
http://www.sqlite.org/faq.html#q11 and 
http://www.sqlite.org/lang_altertable.html

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Final mobile switch-over

2011-11-25 Thread Strainu
2011/11/25 Tomasz Finc tf...@wikimedia.org:
 On Thu, Nov 24, 2011 at 2:41 AM, Strainu strain...@gmail.com wrote:

 I've logged this as an enhancement:
 https://bugzilla.wikimedia.org/show_bug.cgi?id=32597


 Thanks!


 It's a shame we have to go through some not-so-nice hacks to make the
 content for mobiles different than the one for desktops. Perhaps the
 architecture is too iPhone/American oriented? Not all mobile users


 Are XML DOM parsers that American and iPhone centric? I sure hope not as
 the rest of the Internet is going to have to be informed ...

Somehow, I find myself unable to laugh at that joke. You quoted that
out of context, the question goes together with the following phrases.
Plus, the XML DOM parser is the implementation of the architectural
decision, which was to parse the HTML and not the wikitext.



 have unlimited traffic. Many people around me disable images on mobile
 internet.


 Yup, and thats why we've had the option to disable images for many months
 now. It lowered the payload by half. Lots of people use it. If you see
 other data heavy features on pages that we can get rid of then please file
 a bug. Were always eager to lower our payload.

Disabling images by the user is cool, but it leaves behind references
to images, which might make the text sound a little awkward. All
images in the ro.wp main page are referenced in the text. Removing
them cripples the page. This is why we had a custom webpage for mobile
and we would like to be able to use that as we go forward.


 Hope you will give that some serious thought when the time comes.


 We already have and would love to drop it down even more. Next interesting
 step would actually be to load sections only when people want them. That'll
 drop down the payload even more.

 Turn on the webkit network profiler and let us know whats really slowing us
 down.

Isn't webkit specific to the iPhone? I was not aware it was available
on normal platforms.

As to suggestions on how to drop the load, it's the same as above: let
the users do the micromanagement of the mobile sites, they're much
better than you (i.e the WMF, not you personally)  at this.

Going back to the original issue, is there any other way to display
something else for the mobile site than including the divs on the main
page and making them invisible from the desktop site by CSS and JS?
This is what I called an ugly hack because it might very well fail
for text browsers or screen readers.

Thanks,
Strainu

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r97654]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97654.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97654
Commit summary:

bump version number

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98130]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98130.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98130
Commit summary:

stylize

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99018]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99018.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99018
Commit summary:

search bar too wide

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99709]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99709.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99709
Commit summary:

Revert back, it's arkward

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99710]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99710.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99710
Commit summary:

Start again by properly reformatting files

Killed 5.4 KB to being with

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99719]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99719.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99719
Commit summary:

Bug 31050 - Cleanup duplicate CSS for mobile devices

Move .clearlink, #search, .divclearable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99721]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99721.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99721
Commit summary:

Bug 31050 - Cleanup duplicate CSS for mobile devices

Move table[style] and table.navbox td.navbox-group

So far, about 35 KB saved by refactoring out all the complete duplicate blocks 
of CSS

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99723]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99723.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99723
Commit summary:

Bug 31050 - Cleanup duplicate CSS for mobile devices

Move table.gallery and table.navbox

Remove some already refactored code from wii

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99758]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99758.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99758
Commit summary:

Bug 31050 - Cleanup duplicate CSS for mobile devices

More gone!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99720]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99720.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99720
Commit summary:

table, table.gallery thumb[style] and table.geography[style] 
td[style*=text-align], table.geography[style] td[colspan=2], table.toc h2 
ans table.gallery th, table.gallery td

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99757]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99757.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99757
Commit summary:

Kill jquery.js as it is now unused

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99786]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99786.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99786
Commit summary:

add back content type header for wml view

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101392]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101392.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101392
Commit summary:

fix use of weak comparison

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101430]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101430.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101430
Commit summary:

up version number

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101710]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101710.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101710
Commit summary:

update version number for application javascript

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101714]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101714.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101714
Commit summary:

fix spacing

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101709]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101709.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101709
Commit summary:

partial fix for bug 30985 mobile header expanding and menu do not work until 
page loads

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101711]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101711.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101711
Commit summary:

1.18wmf1: MFT r101709 - r101710

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101772]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101772.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101772
Commit summary:

up version number

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101774]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101774.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101774
Commit summary:

up version number

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103326]: New comment added

2011-11-25 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r103326.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103326#c26544
Commit summary:

Export extensions of old version also

Don't diff gif or svg

Comment:

They are, it just seemed easier to exclude them aswell... Can always be reverted

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Final mobile switch-over

2011-11-25 Thread Tomasz Finc
On Fri, Nov 25, 2011 at 3:48 AM, Strainu strain...@gmail.com wrote:

 Isn't webkit specific to the iPhone? I was not aware it was available
 on normal platforms.


Grabbing this section before I head off to bed (its 4am here) and will
respond to the rest a bit later.

Nope, it actually has its roots as part of KDE. Its actively used in S60,
Android, Google Chrome, and even more found here:
http://en.wikipedia.org/wiki/WebKit#Ports

--tomasz
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r104210]: New comment added

2011-11-25 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104210.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104210#c26545
Commit summary:

else if - elseif

Comment:

Bah, I reverted some of the ones in obvious external libraries

I suppose it's not a big deal, and won't break anything either way

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104023]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104023.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104023
Commit summary:

Add Lohit Devanagari for Maithili per Red Hat localisation team feedback.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103995]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r103995.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103995#c26546
Commit summary:

Added soft undo/redo

Comment:

It is CTRL+R under vim, not Z :-)

You guys rocks!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103981]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103981.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103981
Commit summary:

qqq docs

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103708]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r103708.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103708#c26547
Commit summary:

* (bug 19698) Inverse selection for Special:Contributions

Manually updated patch to fix conflicts

Comment:

updated with r104234

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103708]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103708.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103708
Commit summary:

* (bug 19698) Inverse selection for Special:Contributions

Manually updated patch to fix conflicts

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103678]: New comment added, and revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103678.

Old Status: new
New Status: fixme

User Hashar also posted a comment on MediaWiki.r103678.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103678#c26548
Commit summary:

Incorporate a router into our maintenance/dev/ code to better handle the 
variety of file types we support.

Comment:

Can you please add a comment about what this file is meant for? What are the 
expected inputs and what happens on return true or return false?

Thanks!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103668]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103668.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103668
Commit summary:

Fix svn:eol-style native

Remove wrong mime-type

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103656]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103656.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103656
Commit summary:

Remove punctuation from message group description.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103472]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103472.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103472
Commit summary:

Initial skeleton for testswarm deb

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Final mobile switch-over

2011-11-25 Thread Thomas Dalton
On 23 November 2011 19:13, Philip Chang pch...@wikimedia.org wrote:
 We are suggesting that a home page customized for mobile viewing is perhaps
 more suitable, but I also understand the point you are making and will take
 that into consideration.

I don't think anyone disagrees with that. The question is over whether
no home page at all (just a search bar) is better than a home page
that hasn't been customised for mobile users. I'm not sure that it is.

Also, can you elaborate on what you said about country-specific home
pages? Why would we want that? Wikipedias are for languages, not
countries. All Wikipedias should have global reach, regardless of what
language they are in. If individual language communities want to
create different home pages for different countries, then I doubt the
rest of the movement would step in to stop them, but it shouldn't be
something initiated by the tech team. I suggest you find out if anyone
wants such a feature before you implement it...

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r103876]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103876.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103876
Commit summary:

Backing out history integration for now

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103994]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103994.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103994
Commit summary:

tweak hook doc; followup r103762

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103678]: New comment added

2011-11-25 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r103678.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103678#c26549
Commit summary:

Incorporate a router into our maintenance/dev/ code to better handle the 
variety of file types we support.

Comment:

You want me to write php documentation in MediaWiki?

http://ca2.php.net/manual/en/features.commandline.webserver.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102201]: New comment added

2011-11-25 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r102201.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102201#c26550
Commit summary:

Commit maintenance/dev/ a set of bash scripts that can quickly download php 
5.4, install it in an isolated area, install a quick development copy of 
MediaWiki, and then start up a local webserver.

Comment:

Before we go adding dependencies like pake to something that is supposed to 
work without any dependency on pre-installed php much less a non-default pear 
module, I'd like to have someone actually make sure that the installation steps 
on Windows works seamlessly.
Using something cross platform but non-native is completely pointless if the 
configure / install of php chokes up in ANY way at all.

Looking at php's Windows site makes me think using the same pattern for 
installing php as we use on unix-like systems won't work sanely on Windows and 
you need a complete separate set of steps dedicated to Windows for it to work. 
ie: Someone should consider writing a .bat for Windows.

((Really? To install php 5.4 and MediaWiki together please ensure you have a 
fully functional php installation, pear, and the pake pear package on your 
system.))

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103524]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103524.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103524
Commit summary:

More things to do

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103417]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103417.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103417
Commit summary:

Debian changelog for recent work.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103875]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103875.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103875
Commit summary:

bad bad dollar sign

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103860]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103860.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103860
Commit summary:

set udp2log recv-queue to up to 128k based on rmem_max

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101770]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101770.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101770
Commit summary:

Add Cite4Wiki straight from the unzipped xpi that I downloaded from
https://addons.mozilla.org/en-US/firefox/addon/cite4wiki/

Doing this after discussing with User:SMcCandlish.  See:
http://en.wikipedia.org/w/index.php?diff=458737327oldid=458729968

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101759]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101759.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101759
Commit summary:

Added documentation and fixed eol-style.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101552]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101552.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101552
Commit summary:

article - page

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101138]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101138.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101138#c26551
Commit summary:

An alternative to using DOMDocument for normalizing when using 
Preprocessor_Hash.
Follow-up r99909.

Comment:

You might want to remove the now unreachable code in normalizeXml() :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100708]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100708.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100708
Commit summary:

version 0.945 adds a SHA1 hash and hash test of the downloaded php-openid-2.2.2 
library

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99842]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99842.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99842
Commit summary:

Adding Sternograph extension

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99502]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r99502.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99502#c26552
Commit summary:

https links to shut up warnings on something I'm testing

Comment:

Maybe you could use relative URLs?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98441]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98441.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98441
Commit summary:

Avoid use of HistoryPager::getArticle()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98092]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98092.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98092
Commit summary:

Remove trailing whitespace in 'openstackmanager-email-body'.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98090]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98090.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98090
Commit summary:

Remove trailing whitespace in 'emailcapture-response-body'.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r96613]: New comment added

2011-11-25 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96613.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96613#c26553
Commit summary:

Fix XSS pointed out in r86105

Comment:

Merged in REL1_18 by r104240

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r86758]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86758.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86758
Commit summary:

register Commonshelper2 domain in Toolserver Intuition

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100311]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100311.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100311
Commit summary:

Trim trailing whitespace

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101052]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101052.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101052
Commit summary:

fix default language issue

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101054]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101054.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101054
Commit summary:

thumb-handler.php uses different globals than everyone else.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101088]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101088.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101088
Commit summary:

Reverted r84395,r98710: thumbnails must be purged on file deletion

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100962]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100962.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100962
Commit summary:

Followup r99354, adding release notes entry

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100704]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100704.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100704
Commit summary:

Tweak message.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99675]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99675.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99675
Commit summary:

Remove trailing whitespace.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101626]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101626.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101626
Commit summary:

Style/consistencies updates.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r97854]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97854.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97854
Commit summary:

Remove some values for ignored messages as well as add/update recent 
translations from http://translatewiki.net.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101932]: New comment added, and revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101932.

Old Status: new
New Status: ok

User Hashar also posted a comment on MediaWiki.r101932.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101932#c26554
Commit summary:

* Update 'wikimedia-copyrightwarning' per Wikimedia Foundation General Counsel 
Geoff Brigham, as communicated with Philippe Beaudette.
* Bring link and link description in 'wikimedia-copyright' in line with the 
actual page.

Comment:

We seize your keyboard and replace it with a mouse instead :-]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101934]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101934.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101934
Commit summary:

MFT r101932 and other updates to WikimediaMessages.i18n.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101918]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101918.

Old Status: ok
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101918
Commit summary:

adding donate_interface-currency-display to i18n

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101921]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101921.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101921
Commit summary:

Add underscore missing in r101918.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101920]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101920.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101920
Commit summary:

Follow-up r101918: update tags.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r98003]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98003.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98003
Commit summary:

Fix duplicate 'qqq' entry. Duplicate keys will be resolved after the next twn 
export.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99548]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99548.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99548
Commit summary:

Follow-up r99541: add tags
Update indentation.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104021]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104021.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104021
Commit summary:

Update tags.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100969]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100969.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100969
Commit summary:

Normalize newline before exploding by \n

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r101114]: New comment added, and revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101114.

Old Status: new
New Status: ok

User Hashar also posted a comment on MediaWiki.r101114.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101114#c26555
Commit summary:

Break long lines (and prove svn is working)

Comment:

svn tells demon: patch received master

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104236]: Revision status changed

2011-11-25 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104236.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104236
Commit summary:

Update comments, some braces

Remove some returns where things aren't being returned

Fixed an undefined variable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


  1   2   >