Re: [Wikitech-l] SOPA banner implementation
Are there any plans for per-country geolocated banners? (I realise we have only 22 hours.) Things like saying "Contact [name of ministry in your country]" rather than expecting people to look these up themselves. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109117]: Revision status changed
"Raymond" changed the status of MediaWiki.r109117 to "reverted" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109117 Old status: new > New status: reverted Commit summary for MediaWiki.r109117: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109118]: Revision status changed
"Raymond" changed the status of MediaWiki.r109118 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109118 Old status: new > New status: ok Commit summary for MediaWiki.r109118: Revert own r109117. We have 4 valid localisations, but that's about it... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109063]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109063 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109063 Old status: new > New status: resolved Commit summary for MediaWiki.r109063: r109027: Make key optional for translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109107]: New comment added
"NeilK" posted a comment on MediaWiki.r109107. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109107#c29669 Commit summary for MediaWiki.r109107: a more usable page NeilK's comment: ok, it's 12:20am and there isn't a fix in place... I am going to defer deployment until tomorrow morning. But will try to make that as early as possible, like 8am or something. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109107]: New comment added
"NeilK" posted a comment on MediaWiki.r109107. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109107#c29670 Commit summary for MediaWiki.r109107: a more usable page NeilK's comment: Kaldari: if you fix this at home ping me anyway (email, IRC, whatever) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SOPA banner implementation
On Tue, Jan 17, 2012 at 7:23 AM, Roan Kattouw wrote: > When the Italians did their blackout, Google asked us to block them > (!) from bits.wm.o (our JS/CSS domain), which in the specific case of > the Italian blackout had the effect of not honoring the blackout at > all. > > I'm guessing we'd probably have to block search engines from enwiki > entirely to avoid the blackout screwing things up, yeah. It seems Google has advised to serve a 503 (Service unavailable) HTTP code during blackouts to avoid them influencing their search engine. -- André Engels, andreeng...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109119]: Revision status changed
"NeilK" changed the status of MediaWiki.r109119 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109119 Old status: new > New status: ok Commit summary for MediaWiki.r109119: building tables the right way ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109107]: Revision status changed
"NeilK" changed the status of MediaWiki.r109107 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109107 Old status: fixme > New status: resolved Commit summary for MediaWiki.r109107: a more usable page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109115]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109115 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109115 Old status: new > New status: ok Commit summary for MediaWiki.r109115: Fix r109063 per Niklas' CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109120]: Revision status changed
"Santhosh.thottingal" changed the status of MediaWiki.r109120 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109120 Old status: new > New status: ok Commit summary for MediaWiki.r109120: Update documentation and remove incorrect localisation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109075]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r109075 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109075#c29671 Old Status: new > New Status: fixme Commit summary for MediaWiki.r109075: AFT5 - Add ability to 'delete' (super-hide, visible to oversight only) comments. Started plumbing the bits to allow updating the count queries when hiding feedback, but i need to noodle that one over a bit more. Nikerabbit's comment: Where is articlefeedbackv5-delet-saved used? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109100]: New comment added
"NeilK" posted a comment on MediaWiki.r109100. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109100#c29672 Commit summary for MediaWiki.r109100: fixing schema, adding twitter and missing contact pages NeilK's comment: Actually... it's not ok. Fixed in 109121 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109121]: Revision status changed
"NeilK" changed the status of MediaWiki.r109121 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109121 Old status: new > New status: ok Commit summary for MediaWiki.r109121: adding db prefixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109116]: Revision status changed
"^demon" changed the status of MediaWiki.r109116 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109116 Old status: new > New status: ok Commit summary for MediaWiki.r109116: r109075: Ignore empty message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109123]: Revision status changed
"NeilK" changed the status of MediaWiki.r109123 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109123 Old status: new > New status: ok Commit summary for MediaWiki.r109123: breaking dump into smaller inserts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109124]: Revision status changed
"NeilK" changed the status of MediaWiki.r109124 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109124 Old status: new > New status: ok Commit summary for MediaWiki.r109124: better math ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109125]: Revision status changed
"NeilK" changed the status of MediaWiki.r109125 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109125 Old status: new > New status: ok Commit summary for MediaWiki.r109125: using REPLACE INTO ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109083]: New comment added, and revision status changed
"NeilK" changed the status of MediaWiki.r109083 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109083#c29673 Old Status: new > New Status: ok Commit summary for MediaWiki.r109083: Wired up the backend so the lookups work. Note: You still have to import the data dumps manually. NeilK's comment: this is ok, with later revisions which fix the escaping issues. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added
"Fomafix" posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c29674
Commit summary for MediaWiki.r107669:
* more specific selectors for wikitable - don't inherit properties to nested
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with
class="wikitable"
** (bug 33434) math extension: integral expressions display with
boxes/frames/borders
Fomafix's comment:
For large tables td { expression() } can be a performance problem.
An other idea is to use the HTML attributes border and
cellpadding for IE6:
$( 'table.wikitable' )
.attr( 'border', '1' )
.attr( 'cellpadding', '2' )
in stead of
table.wikitable > * > tr > th,
table.wikitable > * > tr > td {
border: 1px #aaa solid;
padding: 0.2em;
Test case:
{| class="wikitable"
|+ wikitable
| cell || cell
|-
| cell || cell
|}
{| class="wikitable3" style="background-color: #F9F9F9; border: 1px solid
#AA; border-collapse: collapse; color: black; margin: 1em 1em 1em 0;"
|+ wikitable3
| cell || cell
|-
| cell || cell
|}
paste to address bar: (untested in IE6)
javascript:void( $( 'table.wikitable3' ).attr( 'border', '1' ).attr(
'cellpadding', '2' ) )
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109128]: Revision status changed
"NeilK" changed the status of MediaWiki.r109128 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109128 Old status: new > New status: ok Commit summary for MediaWiki.r109128: mo better data ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109128]: New comment added
"NeilK" posted a comment on MediaWiki.r109128. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109128#c29675 Commit summary for MediaWiki.r109128: mo better data NeilK's comment: This also fixed a stupid issue we had with the db prefixed & quoting ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108774]: New comment added, and revision status changed
"^demon" changed the status of MediaWiki.r108774 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108774#c29676 Old Status: resolved > New Status: fixme Commit summary for MediaWiki.r108774: Give sql.php eval.php type scrollback ^demon's comment: You're opening $file and then never using it again in favor of the prompt. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109131]: Revision status changed
"Kaldari" changed the status of MediaWiki.r109131 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109131 Old status: new > New status: ok Commit summary for MediaWiki.r109131: fixed quoting, commenting issues that seem to confuse sql.php. INSERT INTO -> REPLACE INTO ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109135]: Revision status changed
"Santhosh.thottingal" changed the status of MediaWiki.r109135 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109135 Old status: new > New status: ok Commit summary for MediaWiki.r109135: Cleaned up whitespace and improved comments, and renamed fontSelecter to fontChooser, like its id. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108145]: Revision status changed
"Hashar" changed the status of MediaWiki.r108145 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108145
Old status: new
> New status: resolved
Commit summary for MediaWiki.r108145:
(bug 33321. Sort of) Adding a line to MediaWiki:Sidebar that contains a pipe,
but doesn't
have any pipes after being transformed by MessageCache, causes exception on
all pages.
This can happen with lines like:
**{{#if:yes|Something}}
Thank you to liangent for figuring out how to escape a | without {{!}} existing
and | not working.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100509]: New comment added, and revision status changed
"Hashar" changed the status of MediaWiki.r100509 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100509#c29677 Old Status: new > New Status: fixme Commit summary for MediaWiki.r100509: (bug 31414) Skin specific gadgets Hashar's comment: Liagent, can you have a look at Krinkle comment from november 13th 2011? Thanks :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109059]: Revision status changed
"Hashar" changed the status of MediaWiki.r109059 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109059 Old status: new > New status: ok Commit summary for MediaWiki.r109059: On hold until r109005 is reviewed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102575]: New comment added
"Hashar" posted a comment on MediaWiki.r102575. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102575#c29678 Commit summary for MediaWiki.r102575: Commit to fix bug 30513. Hashar's comment: Is there anything else to review / fix or this is just missing a release note? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109103]: Revision status changed
"^demon" changed the status of MediaWiki.r109103 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109103 Old status: new > New status: ok Commit summary for MediaWiki.r109103: Added CurlHttpRequest to AutoLoader.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109139]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r109139 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109139#c29679 Old Status: new > New Status: fixme Commit summary for MediaWiki.r109139: If you want to display miliseconds, make the time be really miliseconds and not seconds Nikerabbit's comment: This looks wrong. Simple query can't take 300 ms. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109140]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109140 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109140 Old status: new > New status: ok Commit summary for MediaWiki.r109140: * Reordered code to not create a RequestContext if the title is invalid * Use Article::newFromTitle() instead of new Article() * Set the WikiPage in the context from the created Article object ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108774]: Revision status changed
"Reedy" changed the status of MediaWiki.r108774 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108774 Old status: fixme > New status: new Commit summary for MediaWiki.r108774: Give sql.php eval.php type scrollback ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109136]: Revision status changed
"Reedy" changed the status of MediaWiki.r109136 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109136 Old status: new > New status: ok Commit summary for MediaWiki.r109136: Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100509]: New comment added
"Liangent" posted a comment on MediaWiki.r100509. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100509#c29680 Commit summary for MediaWiki.r100509: (bug 31414) Skin specific gadgets Liangent's comment: I want some others' input about "Do we need the array_intersect ?" ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109134]: Revision status changed
"Reedy" changed the status of MediaWiki.r109134 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109134 Old status: new > New status: ok Commit summary for MediaWiki.r109134: adding a message to i18n, changing server-side cache to 20 minutes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109137]: Revision status changed
"Hashar" changed the status of MediaWiki.r109137 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109137 Old status: new > New status: ok Commit summary for MediaWiki.r109137: Add bill numbers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109147]: New comment added
"Hashar" posted a comment on MediaWiki.r109147. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109147#c29681 Commit summary for MediaWiki.r109147: Links to SOPA/PIPA acts Hashar's comment: Follow up r109137 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109143]: New comment added
"^demon" posted a comment on MediaWiki.r109143. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109143#c29682 Commit summary for MediaWiki.r109143: Fixed reading from file from r108774 ^demon's comment: This also gets rid of stdin, but I suppose that's acceptable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SOPA banner implementation
On Tue, Jan 17, 2012 at 3:27 AM, Andre Engels wrote: > On Tue, Jan 17, 2012 at 7:23 AM, Roan Kattouw wrote: >> When the Italians did their blackout, Google asked us to block them >> (!) from bits.wm.o (our JS/CSS domain), which in the specific case of >> the Italian blackout had the effect of not honoring the blackout at >> all. >> >> I'm guessing we'd probably have to block search engines from enwiki >> entirely to avoid the blackout screwing things up, yeah. > > It seems Google has advised to serve a 503 (Service unavailable) HTTP > code during blackouts to avoid them influencing their search engine. > Here, have a citation for that, https://plus.google.com/115984868678744352358/posts/Gas8vjZ5fmB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109143]: New comment added
"Reedy" posted a comment on MediaWiki.r109143. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109143#c29683 Commit summary for MediaWiki.r109143: Fixed reading from file from r108774 Reedy's comment: Indeed, the other way would be to keep it, and have some parameter to have it as a CLI with backscroll like eval ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109141]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109141 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109141 Old status: new > New status: ok Commit summary for MediaWiki.r109141: Fix trailing whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SOPA banner implementation
On 16 January 2012 02:31, Erik Moeller wrote: > On Sat, Jan 14, 2012 at 11:33 AM, MZMcBride wrote: >> The question becomes: how will this be implemented? I assume some kind of >> CentralNotice banner with some CSS absolute positioning or something? Is >> that right? Or will it be part of a separate extension? > > What's currently under primary consideration is a CN implementation > geo-located to US visitors. First early prototype here: > > http://test.wikipedia.org/?banner=blackout > *cough* USA can take over hostnames ".com" from other countries. Then blackout the frontpage of these websites with this image: http://rojadirecta.com/IPRC_Seized_2011_02_NY.gif http://rojadirecta.org/IPRC_Seized_2011_02_NY.gif So SOPA is not just a US visitor concern, but worldwide. -- -- ℱin del ℳensaje. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109143]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109143 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109143 Old status: new > New status: ok Commit summary for MediaWiki.r109143: Fixed reading from file from r108774 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109146]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109146 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109146 Old status: new > New status: ok Commit summary for MediaWiki.r109146: added package description ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109147]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109147 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109147 Old status: new > New status: ok Commit summary for MediaWiki.r109147: Links to SOPA/PIPA acts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109145]: Revision status changed
"Santhosh.thottingal" changed the status of MediaWiki.r109145 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109145 Old status: new > New status: ok Commit summary for MediaWiki.r109145: Tests found a bug, fallback fonts were not loaded because the spaces was not trimmed. addFont( " bar" ) doesn't really work. All webfonts tests passing for me now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109144]: Revision status changed
"Santhosh.thottingal" changed the status of MediaWiki.r109144 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109144 Old status: new > New status: ok Commit summary for MediaWiki.r109144: Modify directly the style attr, .css didn't work - more tests passing now Some whitespace and test comment cleanups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109149]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109149 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109149 Old status: new > New status: ok Commit summary for MediaWiki.r109149: updated project setup ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Wording (RE: SOPA banner implementation)
> http://test.wikipedia.org/?banner=blackout
As a writer, I believe the current message ("The Wikipedia community has
authorized...") is long and wordy and therefore not likely to be read by most
users. I recommend shortening & simplifying it. Here's an example that removes
30+ words and preserves the meaning:
WE NEED YOU TO PROTECT FREE SPEECH ONLINE
The English Wikipedia is "blacked out" for 24 hours to protest two bills before
the United States Congress, known as SOPA and PIPA. These bills endanger free
speech in the United States and abroad, setting a frightening precedent of
Internet censorship for the world.
Today we ask you to take action.
[[Take action]] [[Learn more]]
Just a suggestion.
DanB
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wording (RE: SOPA banner implementation)
On 17/01/12 15:01, Daniel Barrett wrote:
>> http://test.wikipedia.org/?banner=blackout
>
> As a writer, I believe the current message ("The Wikipedia community has
> authorized...") is long and wordy and therefore not likely to be read by most
> users. I recommend shortening& simplifying it. Here's an example that
> removes 30+ words and preserves the meaning:
>
> WE NEED YOU TO PROTECT FREE SPEECH ONLINE
> The English Wikipedia is "blacked out" for 24 hours to protest two bills
> before the United States Congress, known as SOPA and PIPA. These bills
> endanger free speech in the United States and abroad, setting a frightening
> precedent of Internet censorship for the world.
>
> Today we ask you to take action.
> [[Take action]] [[Learn more]]
+1
The first sentence is really too complicated.
Markus
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wording (RE: SOPA banner implementation)
On 17 January 2012 15:23, Markus Krötzsch wrote:
> On 17/01/12 15:01, Daniel Barrett wrote:
> >> http://test.wikipedia.org/?banner=blackout
> >
> > As a writer, I believe the current message ("The Wikipedia community has
> authorized...") is long and wordy and therefore not likely to be read by
> most users. I recommend shortening& simplifying it. Here's an example that
> removes 30+ words and preserves the meaning:
> >
> > WE NEED YOU TO PROTECT FREE SPEECH ONLINE
> > The English Wikipedia is "blacked out" for 24 hours to protest two bills
> before the United States Congress, known as SOPA and PIPA. These bills
> endanger free speech in the United States and abroad, setting a frightening
> precedent of Internet censorship for the world.
> >
> > Today we ask you to take action.
> > [[Take action]] [[Learn more]]
>
> +1
>
> The first sentence is really too complicated.
>
> Markus
>
+1 for the first sentence. The question of "authorised *who*?" is one that
only serves to distract attention from the main message. I prefer the
current wording of the legislation description: I don't think people will
mind reading a few extra words there... it's not like they have anything
else to read!! :-)
That said, I'm sure this list is not the best place to discuss the banner
wording. Where is?
--HM
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109075]: New comment added
"Gregchiasson" posted a comment on MediaWiki.r109075. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109075#c29684 Commit summary for MediaWiki.r109075: AFT5 - Add ability to 'delete' (super-hide, visible to oversight only) comments. Started plumbing the bits to allow updating the count queries when hiding feedback, but i need to noodle that one over a bit more. Gregchiasson's comment: That's a typo. It should be "articlefeedbackv5-delete-saved", and it's used in modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (or it will be, when I fix it). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109150]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109150 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109150 Old status: new > New status: ok Commit summary for MediaWiki.r109150: this lucene api has switched to streams ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109151]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r109151 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109151#c29685 Old Status: new > New Status: fixme Commit summary for MediaWiki.r109151: this lucene api has switched to streams Nikerabbit's comment: Why did you delete and re-add the file? Now all the history is gone. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109150]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109150 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109150 Old status: ok > New status: fixme Commit summary for MediaWiki.r109150: this lucene api has switched to streams ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109142]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r109142 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109142#c29686 Old Status: new > New Status: ok Commit summary for MediaWiki.r109142: Bump 0.61 Nikerabbit's comment: Haven't seen such useless comment for a while as this. // for security meaning_of_life should always be set to 42. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109130]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109130 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109130 Old status: new > New status: ok Commit summary for MediaWiki.r109130: dbg toolbar: makes pane title consistent Example output: Console (1) | Queries (45) | Debug Log (21) | Request | PHP includes (131) A null / undefined / 0 value will skip the parentheses output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109154]: New comment added
"Reedy" posted a comment on MediaWiki.r109154. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109154#c29687 Commit summary for MediaWiki.r109154: Set mime-type to application/gzip to see if ViewVC won't be so stupid with it Ping r109153 Reedy's comment: Nope. Stupid software ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109153]: New comment added
"ArielGlenn" posted a comment on MediaWiki.r109153. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109153#c29688 Commit summary for MediaWiki.r109153: use 9 digit zip if provided; table and data for 9 digit zip; fix leading 0 in zip issue for sen lookup ArielGlenn's comment: Left out a comment in the commit: set cl id -> NULL for zip codes in cl zip5 table that are split across districts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Wording (RE: SOPA banner implementation)
On Tue, Jan 17, 2012 at 7:31 AM, Happy Melon wrote:
> On 17 January 2012 15:23, Markus Krötzsch
> wrote:
>
>> On 17/01/12 15:01, Daniel Barrett wrote:
>> >> http://test.wikipedia.org/?banner=blackout
>> >
>> > As a writer, I believe the current message ("The Wikipedia community has
>> authorized...") is long and wordy and therefore not likely to be read by
>> most users. I recommend shortening& simplifying it. Here's an example that
>> removes 30+ words and preserves the meaning:
>> >
>> > WE NEED YOU TO PROTECT FREE SPEECH ONLINE
>> > The English Wikipedia is "blacked out" for 24 hours to protest two bills
>> before the United States Congress, known as SOPA and PIPA. These bills
>> endanger free speech in the United States and abroad, setting a frightening
>> precedent of Internet censorship for the world.
>> >
>> > Today we ask you to take action.
>> > [[Take action]] [[Learn more]]
>>
>> +1
>>
>> The first sentence is really too complicated.
>>
>> Markus
>>
>
> +1 for the first sentence. The question of "authorised *who*?" is one that
> only serves to distract attention from the main message. I prefer the
> current wording of the legislation description: I don't think people will
> mind reading a few extra words there... it's not like they have anything
> else to read!! :-)
I like this wording better as well. If we want to discuss the
authorization, the learn more link might be a better place to detail
it.
>
> That said, I'm sure this list is not the best place to discuss the banner
> wording. Where is?
>
> --HM
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
--
Leslie Carr
Wikimedia Foundation
AS 14907, 43821
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105919]: New comment added
"Hashar" posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29689
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Hashar's comment:
What I meant is that I would like the second parameter (query2) to be
deprecated with the release of 1.19.
So if $query2 is set to something, we should emit a deprecation warning.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109139]: New comment added
"IAlex" posted a comment on MediaWiki.r109139. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109139#c29690 Commit summary for MediaWiki.r109139: If you want to display miliseconds, make the time be really miliseconds and not seconds IAlex's comment: So you have a problem somewhere, because the time passed from MWDebug to JavaScript is in seconds, not milliseconds. On my machine with this rev, simple queries take between 0.1 and 0.3 milliseconds. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Text browser users won't see your important site notice
Text browser users won't see you important site notice. Better use the $wg Site Notice variable... Indeed, text browser users heard the closing news on the radio. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105919]: New comment added, and revision status changed
"Hashar" changed the status of MediaWiki.r105919 to "resolved" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29691
Old Status: new
> New Status: resolved
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Hashar's comment:
I have added a deprecation warning with r109161.
All the code is fine. Marking resolved.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Text browser users won't see your important site notice
On 17 January 2012 16:40, wrote: > Text browser users won't see you important site notice. > Better use the $wg Site Notice variable... > Indeed, text browser users heard the closing news on the radio. http://en.m.wikipedia.org/ isn't showing the site notice either. IT REALLY NEEDS TO. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105924]: Revision status changed
"Hashar" changed the status of MediaWiki.r105924 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105924 Old status: new > New status: ok Commit summary for MediaWiki.r105924: Followup r105919: - Fix a loose $variant I missed when cleaning up other methods. - Add documentation to getLocalURL. - Swap the disorganized docs on the dependent methods with a see comment. - Add RELEASE-NOTES. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109139]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r109139 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109139#c29692 Old Status: fixme > New Status: ok Commit summary for MediaWiki.r109139: If you want to display miliseconds, make the time be really miliseconds and not seconds Nikerabbit's comment: You're right. I didn't expect the queries to be so fast. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109122]: Revision status changed
"Hashar" changed the status of MediaWiki.r109122 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109122 Old status: new > New status: ok Commit summary for MediaWiki.r109122: Make the QunitTestResources in sync with qunit/index.html. JqueryMsg tests were not preset in QunitTestResources. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SOPA banner implementation
On Tue, Jan 17, 2012 at 3:33 PM, Tei wrote: > *cough* > > USA can take over hostnames ".com" from other countries. > > Then blackout the frontpage of these websites with this image: > http://rojadirecta.com/IPRC_Seized_2011_02_NY.gif > http://rojadirecta.org/IPRC_Seized_2011_02_NY.gif > > So SOPA is not just a US visitor concern, but worldwide. One more chilling case that is current at the moment is that of Richard O'Dwyer (http://en.wikipedia.org/wiki/Richard_O%27Dwyer). He hosted a site where people would share links to (usually pirated) videos of television shows. He is to be extradited from the United Kingdom to the United States for having that site, even though the servers were in the Netherlands and he was in the UK. In Europe he would have good chances with a defense that linking to pirated material is not in itself illegal, but there is no such defense in the United States. -- André Engels, andreeng...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r104343]: New comment added
"Hashar" posted a comment on MediaWiki.r104343. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104343#c29693 Commit summary for MediaWiki.r104343: Bug 32673: Keep the username in the input field if not existing We could also add on LogEventsList.php line 870 $this->performer = $name; but that method is also used to build the query, which we don't want to affect. Hashar's comment: Platonides, can you have a look at this one again? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109075]: New comment added
"Raymond" posted a comment on MediaWiki.r109075.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109075#c29694
Commit summary for MediaWiki.r109075:
AFT5 - Add ability to 'delete' (super-hide, visible to oversight only)
comments. Started plumbing the bits to allow updating the count queries when
hiding feedback, but i need to noodle that one over a bit more.
Raymond's comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109157]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109157 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109157 Old status: new > New status: ok Commit summary for MediaWiki.r109157: Better way to check whether @font-face rule is added to the document for the font. Also helps in case font was loaded using uselang=ta and not by tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] i18n Triage
What: Localisation and internationalisation bug triage When: Wednesday, January 18, 13:00 UTC Time zone conversion: http://hexm.de/cu Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev The preparation for the triage is in this etherpad: http://etherpad.wikimedia.org/BugTriage-i18n-2012-01 This triage will focus on the Narayam and Translate extension and we've selected issues that we would really like community input on. Thanks, Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100509]: New comment added
"Krinkle" posted a comment on MediaWiki.r100509. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100509#c29695 Commit summary for MediaWiki.r100509: (bug 31414) Skin specific gadgets Krinkle's comment: Actually array_intersect isn't as much an issue as much as much as the issue is in the nature of filtering user input in a different context that it was entered by the user. So if we've got a wiki with skin foo, bar and quux and gadget X and gadget Y: *GadgetX[skin=foo]|GadgetX.js|GadgetX.js *GadgetY|GadgetY.js|GadgetY.js Then at this moment in time GadgetX is only for users with "foo" skin and GadgetY for everyone. If this gadget remains untouched and at some point skin "foo" is removed then suddently due to the above cited code (if I understand correctly) it will be evaluated as if it was the following: *GadgetX|GadgetX.js|GadgetX.js *GadgetY|GadgetY.js|GadgetY.js Eventough no change took place and GadgetX is still incompatible with other skins. So do we need to filter them at all ? Assuming the reason is validation, I think it's fine without in this case. Invalid skins simply never match anyones preference. In ResourceLoader2/Gadgets 2.0 we will do this in a "nicer" way in the front-end by limiting the users choice in the first place, but that's another story. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107982]: New comment added
"Krinkle" posted a comment on MediaWiki.r107982. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107982#c29696 Commit summary for MediaWiki.r107982: [jquery.footHovzer] new plugin for mw-log-console and mw-debug-toolbar * Previously mw.log and mw.Debug both were in a fixed container on the bottom, overlapping each other. mw.log did increase the body's padding-bottom to account for the height so that all content is still visible, but it was still a problem when mw.Debug came along. * This plugin adds a single fixed position element to bottom of the body, to which other stuff like mw.log and mw.Debug can append a non-fixed position container. That will take care of it. * Method update() will re-check the padding and scroll position and fix where needed * Reduces code a little bit Krinkle's comment: The use case for it was valid imho, but the side affects were worse than the gain in the utility. Removed in r109166. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107982]: Revision status changed
"Krinkle" changed the status of MediaWiki.r107982 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107982 Old status: fixme > New status: new Commit summary for MediaWiki.r107982: [jquery.footHovzer] new plugin for mw-log-console and mw-debug-toolbar * Previously mw.log and mw.Debug both were in a fixed container on the bottom, overlapping each other. mw.log did increase the body's padding-bottom to account for the height so that all content is still visible, but it was still a problem when mw.Debug came along. * This plugin adds a single fixed position element to bottom of the body, to which other stuff like mw.log and mw.Debug can append a non-fixed position container. That will take care of it. * Method update() will re-check the padding and scroll position and fix where needed * Reduces code a little bit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] [TestSwarm] Mr. Epiphany (Ubuntu 11.04), please leave the swarm
Hey all, After two weeks of annoyance I'll just dump this here. There have been many people who have donated their browser resources to our TestSwarm[1] continuos integration project for MediaWiki. First and foremost, thanks to all who've been doing so. Please keep doing that :) However there's one little thing I'd like to get rid of: Someone with Ubunto has an "Epiphany" (WebKit based) browser that is polluting[4] our swarm with false positives. "Epiphany" is not a supported[2] browser, but due it lying[3] about it's identity it is not blocked from joining the swarm and instead submits results under "Safari". User agent of suspect: Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.26+ (KHTML, like Gecko) Version/5.0 Safari/534.26+ Ubuntu/11.04 (3.0.4-1ubuntu1) Epiphany/3.0.4 Please whoever operates this machine, keep it out of the swarm. (in the future we might get a system to blacklist this but for now..) Thanks :) - Krinkle [1] http://integration.mediawiki.org/testswarm/ [2] http://www.mediawiki.org/wiki/Compatibility#Browser [3] http://webaim.org/blog/user-agent-string-history/ [4] http://integration.mediawiki.org/testswarm/user/mediawiki/ (if you don't see a red column to the right here, it means the problem was fixed in the mean time) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109163]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109163 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109163 Old status: new > New status: ok Commit summary for MediaWiki.r109163: r109156: De-ignore empty message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109164]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109164 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109164 Old status: new > New status: ok Commit summary for MediaWiki.r109164: Clearer test descriptions and constant font names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109165]: New comment added
"Nikerabbit" posted a comment on MediaWiki.r109165. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109165#c29697 Commit summary for MediaWiki.r109165: Added compatibility for SMW 1.6 (finally), moved all functions into class, plus some stylistic improvements Nikerabbit's comment: Why did you remove htmlspecialchars from: $link = $skin->makeLinkObj( $title, htmlspecialchars( $title->getText() ) ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108938]: Revision status changed
"Reedy" changed the status of MediaWiki.r108938 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108938 Old status: new > New status: resolved Commit summary for MediaWiki.r108938: (Bug 33553) Babel AutoCreate should not be able to create categories it is not allowed to create (protected titles) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109165]: New comment added
"Yaron K." posted a comment on MediaWiki.r109165. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109165#c29698 Commit summary for MediaWiki.r109165: Added compatibility for SMW 1.6 (finally), moved all functions into class, plus some stylistic improvements Yaron K.'s comment: Oops! I don't know how that happened. Thanks for pointing that out; I just fixed it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109205]: Revision status changed
"SPQRobin" changed the status of MediaWiki.r109205 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109205 Old status: new > New status: ok Commit summary for MediaWiki.r109205: Followup r108938, don't create an article object to just get the title out again $article is used lower down, so moved declaration down ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109196]: New comment added
"Nikerabbit" posted a comment on MediaWiki.r109196. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109196#c29699 Commit summary for MediaWiki.r109196: MFT r102851, r102861 Nikerabbit's comment: Is this needed in 1.18? Without release notes? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109197]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109197 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109197 Old status: new > New status: ok Commit summary for MediaWiki.r109197: MFT r102851, r102861 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109209]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109209 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109209 Old status: new > New status: ok Commit summary for MediaWiki.r109209: Follow-up to r109165 - restored htmlspecialchars() call, accidentally deleted ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109165]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109165 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109165 Old status: deferred > New status: resolved Commit summary for MediaWiki.r109165: Added compatibility for SMW 1.6 (finally), moved all functions into class, plus some stylistic improvements ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109208]: Revision status changed
"Reedy" changed the status of MediaWiki.r109208 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109208 Old status: new > New status: ok Commit summary for MediaWiki.r109208: retabbing to eliminate mixed spaces and tabs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109166]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109166 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109166 Old status: new > New status: ok Commit summary for MediaWiki.r109166: [jquery.footHovzer] Remove buggy scrollstate preserver * Intended to preserver scroll-state (which is shifted when an element to the bottom gains height). However too unstable to be more handy that it is annoying when it is not. * Follows-up r107982 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109168]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109168 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109168 Old status: deferred > New status: ok Commit summary for MediaWiki.r109168: New version: 0.3.9 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109169]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109169 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109169 Old status: deferred > New status: ok Commit summary for MediaWiki.r109169: Follow-up to r109165 - more fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109188]: Revision status changed
"Nikerabbit" changed the status of MediaWiki.r109188 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109188 Old status: new > New status: ok Commit summary for MediaWiki.r109188: Fix eol-style for r109039 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109195]: New comment added
"Nikerabbit" posted a comment on MediaWiki.r109195. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109195#c29700 Commit summary for MediaWiki.r109195: [Actions] Move the remaining actions out of MediaWiki::performAction into single action classes (finally). - [Actions] - * I am aware that eventually these classes should be more than just a few lines re-directing control to WikiPage, but I'm keeping these commits as uncontroversial as possible due to feature freeze. Refactor could be done later. * Contributes to solution of bug 27930 - Ablity to get current action (The Right Way) * Final goal: Get the current action without needing access to Wiki.php internals (i.e. with Action::factory in one hand and an instance of IContextSource in the other) * Required for proper fix of r108342/108343 (currently marked FIXME) Nikerabbit's comment: Whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109154]: Revision status changed
"^demon" changed the status of MediaWiki.r109154 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109154 Old status: new > New status: ok Commit summary for MediaWiki.r109154: Set mime-type to application/gzip to see if ViewVC won't be so stupid with it Ping r109153 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109005]: New comment added
"Multichill" posted a comment on MediaWiki.r109005. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109005#c29701 Commit summary for MediaWiki.r109005: Finish r109000 change. Move to wm-license-pd-usgov-work-template languages be-tarask, de, ia, ko, mg, pms and add to wm-license-pd-usgov-work-template qqq. You may _now_ revert it if you wish, or break the message in different pieces (although the direct object seems quite sensible). You may not like helper messages, but WikimediaMessagesLicense is broken forcing to translate everything. The redundancy is there, no matter the language (anyway, if it couldn't be expressed through wm-license-pd-usgov-work-template, it can be ignored). It is clear in how, despite adding a new message, this saves 5KB. And we want those messages to be consistent! If a language had three ways to say 'U.S. federal government', different messages choosing different variants, just because they were translated at different times, would be wrong (still better than untranslated, but wrong). Multichill's comment: As I already said in r109001. I don't like these lego messages being introduced. This duplication is there for a reason: Clean translation as recommended by the people of Translatewiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109206]: Revision status changed
"Hashar" changed the status of MediaWiki.r109206 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109206 Old status: new > New status: ok Commit summary for MediaWiki.r109206: adding some error messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108342]: Revision status changed
"Krinkle" changed the status of MediaWiki.r108342 to "reverted" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108342 Old status: fixme > New status: reverted Commit summary for MediaWiki.r108342: Implement MediaWiki::getPerformedAction() * Fixes: -- Bug 27930 - Ablity to get current action (The Right Way) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108343]: Revision status changed
"Krinkle" changed the status of MediaWiki.r108343 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343 Old status: fixme > New status: new Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108343]: Revision status changed
"Krinkle" changed the status of MediaWiki.r108343 to "reverted" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343 Old status: new > New status: reverted Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
