[Wikitech-l] Site Incident report - 1/20/12

[CT Woo]

All,

Earlier today, while fixing some network congestion problem with the bits
servers, the varnish servers for bits.wikimedia.org went into an overload
condition. While most affected users had incorrectly formatted wiki pages
rendered due to missing javascript and css (the primary function of
bits.wikimedia.org is to serve them), some experienced site slowness. The
whole incident lasted for 10-15 minutes.

The incident was investigated and documented, and  now available at  -
http://wikitech.wikimedia.org/view/Site_issue_January_2012

Regards,
CT
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r109243]: Revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109243 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109243

Old status:  ok
> New status: reverted

Commit summary for MediaWiki.r109243:

Reverted r109223 per CR

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108343]: Revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r108343 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343

Old status:  new
> New status: reverted

Commit summary for MediaWiki.r108343:

[mw.config] wgAction shouldn't use direct URL values
* Fixes bug 25800
* Depends on r108342

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109223]: New comment added

[MediaWiki Mail]

"Krinkle" posted a comment on MediaWiki.r109223.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109223#c29841

Commit summary for MediaWiki.r109223:

[Actions] Move action logic out of 
MediaWiki::getAction/MediaWiki::performAction into Action::getActionName.
* Follows-up r109195
* Reverts/Redoes r108342, r108343, r108345

* Contributes to solution of bug 27930 - Ability to get current action (The 
Right Way)

Krinkle's comment:

Okay, chatter on IRC with Aaron resulted in that this revision can be 
re-instated. But we need to use $context->canUseWikiPage() before calling 
$context->getWikiPage() so that if the current context is in NS_SPECIAL, we 
won't try to fabricate a WikiPage object, which cases the exceptions to be 
thrown as shown above by Raymond.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109545]: New comment added

[MediaWiki Mail]

"Krinkle" posted a comment on MediaWiki.r109545.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109545#c29840

Commit summary for MediaWiki.r109545:

Using the browser checking function from mw.webfonts. Converting the 
font-family string to an array to allow cross-browser testing.

Krinkle's comment:


+fontFamilyList = function( fontFamilyString ) {

implied global, spotted in r109677. Just noting here for reference.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109157]: New comment added, and revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109157 to "resolved" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109157#c29839

Old Status: ok
> New Status: resolved

Commit summary for MediaWiki.r109157:

Better way to check whether @font-face rule is added to the document for the 
font.
Also helps in case font was loaded using uselang=ta and not by tests.

Krinkle's comment:


isFontFaceLoaded = function(fontFamilyName){

implied global, spotted in r109677. Just noting here for reference

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109144]: New comment added, and revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109144 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109144#c29838

Old Status: resolved
> New Status: fixme

Commit summary for MediaWiki.r109144:

Modify directly the style attr, .css didn't work - more tests passing now
Some whitespace and test comment cleanups

Krinkle's comment:

Modify directly the style attr, .css 
didn't work

-   $testElement.css( 'font-family', 'NonExistingFont, AnjaliOldLipi, 
Arial, Helvetica, sans');
+   $testElement.attr( 'style','font-family: NonExistingFont, 
AnjaliOldLipi, Arial, Helvetica, sans' );


This is a problem imho. Considering that the main WebFonts module uses this 
all-over: 

 $body.css( 'font-family' )
..
$( '.webfonts-lang-attr' ).css( 'font-family', '' )
..
$( 'body, input, select, textarea' ).css(
'font-family', '"' + font + '", Helvetica, 
Arial, sans-serif'
);
..
$(el).css( 'font-family', fontFamily )


If that really doesn't work then the main module can't work either. Needs more 
investigation, perhaps the test failure was not caused by this ?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109144]: New comment added, and revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109144 to "resolved" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109144#c29837

Old Status: ok
> New Status: resolved

Commit summary for MediaWiki.r109144:

Modify directly the style attr, .css didn't work - more tests passing now
Some whitespace and test comment cleanups

Krinkle's comment:

bogus $testElement !== [] removed in r109677.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109610]: Revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109610 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109610

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109610:

A little more cleanup in blacklisted browser test. Test the cookie and the 
reset link.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109677]: New comment added

[MediaWiki Mail]

"Krinkle" posted a comment on MediaWiki.r109677.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109677#c29836

Commit summary for MediaWiki.r109677:

[WebFonts.tests] Fixes

* Variables isFontFaceLoaded and fontFamilyList are lacking a "var" statement, 
were leaking to global scope. Adding local closure and turning them into 
(local) function expressions and moved to the top of the scope for clarity.

* Removing redundant tests:
** ok( $inputElement.remove() )
** ok( $( 'body' ).append( .. ) )
-- jQuery collections always return a jQuery object, they are chainable 
prototypes without a status-related return value. These checks don't do 
anything, they will always return a jQuery object and all objects case to true 
in JavaScript

* Removing useless tests:
** assertTrue( $selectElement !== [] )
** In JavaScript all objects are compared by reference, this comparison can 
never succeed because 1) jQuery objects are not arrays, 2) even the, "[] !== 
[]" because they are both separate instances of Array. Arrays and objects must 
be iterated in order to compare them by value, this is done by deepEqual.

* Fixing element selection.
-- Instead of:
 $('body').append( '' );
 var $foo = $('input.foo');
-- Use:
 var $foo = $( '' );
 $('body').append( $foo );
-- No need to query the DOM for this.

* Using equal() instead of ok() as much as possible. ok() is not useful in most 
unit testing because it makes you have to do the comparison inline. Which means 
the value given to ok() is only the end result, not the expected/result values 
themselves. Which means in case of a failure, ok() can only say "Passed" or 
"Failed", whereas equal() (having both values), can output useful debug 
information. This is especially important when working with test reports 
generated externally (eg. through TestSwarm) in which are the test report is 
all you have.

// Not very useful, the comparison is done inline and ok()
// can only know about the result of the comparison
var x = 'foo';
ok( x === 'bar' ); // Failed.
ok( x === 'foo' ); // Passed.


// Useful! The unit test is give both values so it can also mention
// both in the output:
var x = 'foo';
equal( x, 'bar' ); // Failed. Expected: "bar". Result: "foo"
equal( x, 'foo' ); // Passed. Expected: "foo".

Krinkle's comment:

Forgot to include in commit message:

* Didn't introduce an alternative for the tests of the element appending.  
jQuery element creation and appending can be taken for granted at this level. 
If $foo.append( '' ); has to be tested, 
there are way bigger problems to be concerned about.
* Fixed loose string "input content" that was left inside the 
{{tag|body|o}}. The following line fixed it:

-   ok( $( 'body' ).append( "input 
content"), 'An input element for testing was appended to body' );
-   var $inputElement =  $( 'input.webfonts-testing-element' );
+   var $inputElement = $( '' );

Because this:

$("input content");

actually creates '''2''' nodes, not one. Since {{tag|input|o}} is a shorttag 
and cannot hold any content (only attributes), the browser's native parsers 
turns that into 2 nodes: and a Textnode: 
"input content". And in older version of IE6 invalid HTML like 
this can also cause an exception to be thrown, when fed to the innerHTML parser.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] MediaWiki 1.19, Resource Loader, Gadgets, and User Scripts

[Mark A. Hershberger]

Earlier this week
(http://lists.wikimedia.org/pipermail/wikitech-l/2012-January/057638.html),
I wrote about the upcoming 1.19 release and the changes that need to be
made on-wiki to provide a consistent experience.

I've been thinking about this and getting input from on-wiki
administrators, but I'm interested in your thoughts,

I have talked to Krinkle and I realize his concerns -- javascript
dependencies really should be enumerated.  Still, I'm concerned about
the experience for users who have installed several gadgets (which we
can test in Krinkle's "Tour de Wiki") as well as possible UserScripts
(which we really can't test, at least not at as easily or as quickly).

I adjusted the [[MediaWiki:Gadgets-definition]] on enwiki.beta and let
the people on enwiki know what I had found, but I think this sort of
adjustment will be needed in more places.  For proof, just look at
http://de.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Hauptseite?debug=true
in FireBug.

You'll see (or, at least, I see) two un-fulfilled dependencies on
mw.util.

Some sort of dependency needs to be added on mw.util -- either just
preload it or make it log a message when there is an unenumerated
dependency on it (and other necessary js dependencies).

This, plus a message on WP:VPT or the like, would be a way for users and
gadget authors to update their javascript.  It be a great way to notify
users of the deprecation from 1.18 to 1.20 (or 1.21) without providing a
horribly shocking experience after we upgrade the cluster.

Let's ensure that the Wiki* experience is consistent.  We can avoid some
of the mistakes like those that happened when we introduced
ResourceLoader.  Backwards compatibility is important.  If we upgrade
MediaWiki and we know that people are going to complain because a
widespread dependency (like mw.util) disappeared, let's eliminate that
"experience gap".

Mark.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] 2012 Q1 Extension Page Review Drive

[Gregory Varnum]

WikiProject Extensions is presenting our first ever "Extension Page Review 
Drive" - 
http://www.mediawiki.org/wiki/Project:WikiProject_Extensions/Projects/Page_Drive

Several extension pages are long overdue for review. Many are lacking the 
appropriate tags, both header and within the extensions, which cause confusion 
for other developers and sysadmins. In addition to time wasted on bad 
installations, there is also time wasted by other developers providing tech 
support to these bad installations. This will also help with future drives 
reviewing actual code of extensions (although you're welcome to do thorough 
code review during this drive if you'd like) and moving extensions based in 
wikicode to the code repository.

The goal is to review as many of the pages as possible during the 1st quarter 
of this calendar year (so by March 31st).  We've just officially started this 
and already 1% done.  :)

During this drive, all extension pages are marked with an additional category.  
These will be removed once the drive is completed.  Page drive specific 
template modifications and wikicode will also be removed upon the page drive's 
completion.

Any interested participants are welcome to sign on as a participant on:  
http://www.mediawiki.org/wiki/Project:WikiProject_Extensions/Projects/Page_Drive

Feel free to email me with any questions or feedback.  :)

-greg aka varnent


---
Gregory Varnum
Lead, Aequalitas Project
Lead Administrator, WikiQueer
Founding Principal, VarnEnt
@GregVarnum
fb.com/GregVarnum



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Fwd: [Wikimania-l] Call for Participation - Wikimania 2012

[aude]

FYI, the Wikimania 2012 call for participation is out!

We encourage you to submit a talk, a workshop or panel session for
Wikimania 2012. We have a technical track throughout the conference.

http://wikimania2012.wikimedia.org/wiki/Submissions

Scholarships are also open now, should you need help with traveling to
Wikimania.

https://secure.wikidc.org/wm/schols/

Cheers,
Katie


-- Forwarded message --
From: Tiffany Smith 
Date: Wed, Jan 18, 2012 at 2:07 PM
Subject: [Wikimania-l] Call for Participation - Wikimania 2012
To: "Wikimania general list (open subscription)" <
wikimani...@lists.wikimedia.org>


Hi all,

We're happy to announce that the Call for Participation for Wikimania
2012 is open!  During this time of reflection, please take a few
minutes to consider what topics you've been thinking about most and
how you'd be willing to share what you know with the worldwide Wiki
community.

The two most important dates to keep in mind - outside of July 12-14 -
 are as follows:
Deadline for submitting proposals: 18 March 2012
Notification of acceptance: 8 April 2012

To submit a proposal, visit
http://wikimania2012.wikimedia.org/wiki/Submissions.

If you'd like to forward this message to other mailing lists or for
broader distribution (please do!), please use the Call for
Participation included below my signature line.

Thanks so much for your consideration, and, on behalf of the Program
Committee, we look forward to reviewing your proposals and seeing you
in Washington.

Best,
Tiffany

Tiffany Smith
Program Committee Chair, Wikimania 2012
tiffany.lmb.sm...@gmail.com

--

Call for Participation - Wikimania 2012

To submit a proposal, visit:
http://wikimania2012.wikimedia.org/wiki/Submissions

Important Dates
Deadline for submitting proposals: 18 March 2012
Notification of acceptance: 8 April 2012

Overview
Wikimania conferences provide unique opportunities for the wiki
community and its sister projects (including Wikipedia, Wikibooks,
Wikinews, Wiktionary, Wikispecies, Wikimedia Commons, and Wikimedia)
to come together, share their common goals, and develop better ways to
work together on an international level. The Wikimania 2012 program
structure is designed to create multiple opportunities for conference
participants to actively engage with the subject matter, the
environment, and, most importantly, each other. Washington, D.C, can
play an important role in Wikimania 2012 as a locale that gathers
interest in government, culture, media, and academia around the
general goals of the Wikimania conference series.

In accordance with these goals and themes, the program will include
traditional conference offerings such as paper presentations,
tutorials, panels, and poster sessions; provide lounge space and
breaks throughout for participants to gather; and innovate with an
unconference day for attendees to design their own schedule and
participation around common interests. Submissions will be reviewed
and selected in advance by the program committee. Attendees are
welcome to present in the open space track of the conference,
regardless of whether their submitted presentations were accepted.

The eigth annual Wikimania will be held between 12th and 14th July,
2012 in Washington D.C. For more information, please visit the main
site.

Presentation length
Due to the extensive amount of program submissions received in the
previous years, we request your presentation be a maximum of 25
minutes, including time for questions. You may request more time,
though shorter individual presentations are more likely to be
accepted.

This does not apply for keynote speakers, panels, or workshops. 70
minute presentations must be submitted either as panel presentations
to include at least three presenters or as workshops with a clear
lesson plan.

Tracks
Tracks are used by Wikimania to organize submissions and diversify
audiences so that presentations of competing interest do not have time
conflicts. Five tracks are proposed:

Wikis and the Public Sector
The Washington, DC, location for Wikimania 2012 provides a special
opportunity for those working in the social good, policy, government,
nonprofit, and disaster response arenas to share their experience with
collaboration on a local, national, or international level. Wikis and
complementary technologies are proving to be critical in times of
crisis and in ongoing work with citizen participation in government,
as well as in long-term goals for education, public policy, social
entrepreneurship, and development in the global south and throughout
the world. This track will explore the ways that Wikimedia projects
and related activities can be used to support citizens worldwide.

GLAM: Galleries, Libraries, Archives, and Museums
This track aims to support current outreach to Galleries, Libraries,
Archives, and Museums and build enthusiasm for continued work in this
area. Presentations and panels will demonstrate effective outreach
techniques and results from ongoing ac

Re: [Wikitech-l] What happened to MediaWiki-CVS

[Erik Moeller]

On Fri, Jan 20, 2012 at 7:06 AM, Chad  wrote:
> Mail servers were migrated, but the post-commit hooks weren't
> updated to point to the new hosts. This has been fixed now.

Hmm, still seems broken, stopped receiving mediawiki-cvs mails at r109618.

-- 
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r107327]: New comment added, and revision status changed

[MediaWiki Mail]

"Robmoen" changed the status of MediaWiki.r107327 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107327#c29835

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r107327:

[Core JS] wikibits.js / IEFixes clean up
* fix on-the-loose fixalpha() call
-- Calls should not be dangling loose like that
-- Removed local calls from skins and installer
-- instead calling from the IEFixes script (which is loaded raw by wikibits 
which is loaded from the bottom, as are all legacy scripts)
* Removing usage of 'skinpath' and 'skin' globals in wikibits.js, those aren't 
globals per se since introduction of mw.config and $wgLegacyJavaScriptGlobals
* Wrapping wikibits.js in closure to avoid leakage of "local" variables. This 
shouldn't break anything as it is loaded through resource loader which, in 
production mode, wraps it in a closure anyway.
* adding explicit posision=>bottom for wikibits. 'bottom' is default but 
repeating here since it must not change for legacy reasons.

Robmoen's comment:

Tested in IE6 on XP SP2.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109609]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109609 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109609

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109609:

Split LogPager out of LogEventsList.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r104867]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r104867 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104867

Old status:  new
> New status: ok

Commit summary for MediaWiki.r104867:

apply patch from Bug 32501 - [QuestyCaptcha] Help page is broken

Fixes:

  When trying to open the help page, the following messages appear:

Notice: Undefined property: QuestyCaptcha::$storage in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68

Fatal error: Call to a member function cookiesNeeded() on a non-object in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68


Might need to be merged so Extension Distributor can use it?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r103467]: New comment added, and revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r103467 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103467#c29834

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r103467:

Adapt and re-apply Michael Newton's patch from Bug 24464 - Execute
LoginAuthenticateAudit hook more often.

Also updated release notes.

Aaron Schulz's comment:

FIXME'd per chad.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] proposed tech conference anti-harassment policy

[Sumana Harihareswara]

Thanks to all of you for your feedback on this.  We've now finalized the
policy and it now lives at

https://wikimediafoundation.org/wiki/Friendly_space_policy

-- 
Sumana Harihareswara
Volunteer Development Coordinator
Wikimedia Foundation

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r108213]: Revision status changed

[MediaWiki Mail]

"Robmoen" changed the status of MediaWiki.r108213 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108213

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108213:

Hopefully fix too narrow dialog issues reported

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109657]: Revision status changed

[MediaWiki Mail]

"Johnduhart" changed the status of MediaWiki.r109657 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109657

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109657:

Follup to r109654, because I'm blind as a bat.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109661]: New comment added, and revision status changed

[MediaWiki Mail]

"Johnduhart" changed the status of MediaWiki.r109661 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109661#c29833

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109661:

Final styles for Jan. 20 push to prototype.

Johnduhart's comment:

You're missing embeds for resource loader.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r107994]: Revision status changed

[MediaWiki Mail]

"MarkAHershberger" changed the status of MediaWiki.r107994 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107994

Old status:  new
> New status: ok

Commit summary for MediaWiki.r107994:

Follow-up r107376: disable test by default, causes failures in some 
configurations

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109659]: New comment added

[MediaWiki Mail]

"Aaron Schulz" posted a comment on MediaWiki.r109659.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109659#c29832

Commit summary for MediaWiki.r109659:

* Added FileBackend::parentStoragePath() convenience function for getting 
parent directories.
* In StoreBatchTest: sed proper clean() function to remove temp dirs (follows 
up r109641). Also removed some commented out code.
* Fixed temp dir leakage in FileBackendTest.

Aaron Schulz's comment:

Should be "In StoreBatchTest: use proper clean()...", there are no sed matching 
here :p

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109641]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109641 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109641

Old status:  fixme
> New status: resolved

Commit summary for MediaWiki.r109641:

Fix folder leakage.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109650]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r109650 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109650

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109650:

follow-up to r94579. Fixed white spaces

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109649]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r109649 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109649

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109649:

remove BeforePageDisplay hook, interfaceConcurrency module shoudld be loaded as 
needed.  Not on every page.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109641]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109641 to "fixme"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109641

Old status:  new
> New status: fixme

Commit summary for MediaWiki.r109641:

Fix folder leakage.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109529]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109529 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109529

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109529:

Remove use of deprecated LanguageGetMagic hook.
Remove a few globals or constants that were used for magic words.
Trim trailing whitespace and update indentation in a few place.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109525]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109525 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109525

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109525:

Remove use of deprecated LanguageGetMagic hook.
Remove a few globals or constants that were used for magic words.
Trim trailing whitespace.
Remove unneeded MEDIAWIKI checks in class files.
Add FIXME where needed.
Probably some other minor miscellaneous changes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109530]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109530 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109530

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109530:

Remove use of deprecated LanguageGetMagic hook.
Update $wgExtensionCredits here and there, renamed descriptionmsg key for 
UKGeocodingForMaps.
Remove a few globals that were used for magic words.
Trim trailing whitespace and update indentation in a few places.
Updated examples.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r94579]: New comment added

[MediaWiki Mail]

"Wikinaut" posted a comment on MediaWiki.r94579.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94579#c29831

Commit summary for MediaWiki.r94579:

new version RSS 1.90: streamlined template use, extended documentation; 
replaced parsing of each single channel subelement (item) by one final parser 
call when rendering

Wikinaut's comment:

white space problem fixed in r109650 .

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109632]: Revision status changed

[MediaWiki Mail]

"Jack Phoenix" changed the status of MediaWiki.r109632 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109632

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109632:

AFT5 sigh. This is why you test before you commit. Syntax errors, fixed now. 
Followup to r109631

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109402]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109402 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109402

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r109402:

Remove use of deprecated LanguageGetMagic hook.
Add FIXMEs hackish uses.
Some misc. whitespace updates.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91180]: New comment added

[MediaWiki Mail]

"Umherirrender" posted a comment on MediaWiki.r91180.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91180#c29830

Commit summary for MediaWiki.r91180:

Fixes for r88113 and some realted changes:
* Modified Article::editUpdates() WikiPage::doEditUpdates() arguments to 
take a Revision object, an User object and options (much more readable that 
those boolean parameters)
* Call isCountable() on the old content and pass it to 
WikiPage::doEditUpdates() with the 'oldcountable' option so that it really 
reflects the old state of the page
* Updated all calls (no one in extensions) and removed the wrapper 
WikiPage::editUpdates()
* Call onArticleEdit() and onArticleCreate() (the one that is of course) from 
doEditUpdates()
* Removed $wgTitle hack from Import.php

Umherirrender's comment:

This revision breaks the REVISION* vars in WikiText after a nulledit (save 
without change), see bug 32948.

$revision is now always created with current timestamp and than this 
object is used to reparse the page (in doEditUpdates). But than the current 
timestamp is used for the vars. REVISIONID is also empty, because for $changed 
= true the revision id in $revision is never set. But I am unsure why 
REVISIONUSER is also empty.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109129]: Revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r109129 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109129

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109129:

dbg toolbar query list

* add headers (using  instead of 
* hardcoded width that looks fine to me. 4em is enoug for query count
* split function name / execution time in their own column

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109642]: Revision status changed

[MediaWiki Mail]

"Hashar" changed the status of MediaWiki.r109642 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109642

Old status:  new
> New status: deferred

Commit summary for MediaWiki.r109642:

Localisation updates for core and extension messages from translatewiki.net

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r105122]: New comment added, and revision status changed

[MediaWiki Mail]

"Hashar" changed the status of MediaWiki.r105122 to "resolved" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105122#c29829

Old Status: new
> New Status: resolved

Commit summary for MediaWiki.r105122:

Adding new debugging toolbar

Needs a UI cleanup still, but for the most part is working.

Hashar's comment:

Being bold and marking this revision as resolved. This has been reviewed / 
tested by lot of people now.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109641]: New comment added

[MediaWiki Mail]

"Aaron Schulz" posted a comment on MediaWiki.r109641.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109641#c29828

Commit summary for MediaWiki.r109641:

Fix folder leakage.

Aaron Schulz's comment:

I'll probably rewrite this to use repo->getBackend()->clean(), since I want 
this tests to be able to work with specified backends soon.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108577]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r108577 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108577

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108577:

Remove use of deprecated LanguageGetMagic hook.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109640]: New comment added, and revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109640 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109640#c29827

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r109640:

If you are going to leak folders, at least give them your surname.

Aaron Schulz's comment:

Also, note that StoreBatchTest also leaks dirs.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109637]: Revision status changed

[MediaWiki Mail]

"Bsitu" changed the status of MediaWiki.r109637 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109637

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109637:

Tweak desc

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r107958]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r107958 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107958

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r107958:

getting rid of temporary Harvard Sciences Po functionality, replacing it with 
more generic functionality, dont deploy until you get the OK from Dario about 
the Harvard study being totally finished.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109638]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r109638 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109638

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109638:

follow-up to 107958 - using TTL expiry to avoid timezone issues

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r107958]: New comment added, and revision status changed

[MediaWiki Mail]

"Kaldari" changed the status of MediaWiki.r107958 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107958#c29826

Old Status: fixme
> New Status: new

Commit summary for MediaWiki.r107958:

getting rid of temporary Harvard Sciences Po functionality, replacing it with 
more generic functionality, dont deploy until you get the OK from Dario about 
the Harvard study being totally finished.

Kaldari's comment:

Fixed in r109638.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109286]: Revision status changed

[MediaWiki Mail]

"Bsitu" changed the status of MediaWiki.r109286 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109286

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109286:

User::newFromName() can return false — warnings seen on beta.wmflabs.org

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108373]: New comment added, and revision status changed

[MediaWiki Mail]

"Robmoen" changed the status of MediaWiki.r108373 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108373#c29825

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r108373:

[mediawiki.action.history.js] Clean up
* Using named variables instead of eq(0) and eq(1), also future proof by 
checking name="" instead of depending on their respective position in the DOM.

Robmoen's comment:

I see that you removed the redundant $radios in in r108380.
Looks good. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109129]: New comment added

[MediaWiki Mail]

"Robmoen" posted a comment on MediaWiki.r109129.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109129#c29824

Commit summary for MediaWiki.r109129:

dbg toolbar query list

* add headers (using  instead of 
* hardcoded width that looks fine to me. 4em is enoug for query count
* split function name / execution time in their own column

Robmoen's comment:

In CSS change "overflow: scroll;" to: 


.mw-debug-plane { overflow-y: scroll; }


That seems to remove the horizontal scrollbar for me.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109609]: New comment added

[MediaWiki Mail]

"Nikerabbit" posted a comment on MediaWiki.r109609.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109609#c29823

Commit summary for MediaWiki.r109609:

Split LogPager out of LogEventsList.php

Nikerabbit's comment:

I didn't touch any code, just moved it to different file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109609]: New comment added

[MediaWiki Mail]

"Bsitu" posted a comment on MediaWiki.r109609.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109609#c29822

Commit summary for MediaWiki.r109609:

Split LogPager out of LogEventsList.php

Bsitu's comment:


if( count($types) ) {
$this->mConds['log_type'] = $types;
// Set typeCGI; used in url param for paging
if( count($types) == 1 ) $this->typeCGI = $types[0];
}


It's probably better to add curly brace to the if statement and not write 
"blocks" as a single-line, also note that count($types) gets called twice 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109629]: New comment added, and revision status changed

[MediaWiki Mail]

"Robmoen" changed the status of MediaWiki.r109629 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109629#c29821

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r109629:

followup to -r109558, add white space for code consistency

Robmoen's comment:

Not to be picky, but it should have a space after the 1st parameter's comma.  


+   $wgOut->setRobotPolicy( 'noindex, nofollow' );


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109557]: New comment added

[MediaWiki Mail]

"Bsitu" posted a comment on MediaWiki.r109557.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109557#c29820

Commit summary for MediaWiki.r109557:

followup to r107187 - Making textarea width to be 100% in all skins

Bsitu's comment:

Yeah, I was thinking about moving it to shared.css, but I am not sure if this 
would break any layout

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109161]: New comment added

[MediaWiki Mail]

"Hashar" posted a comment on MediaWiki.r109161.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29819

Commit summary for MediaWiki.r109161:

deprecated $query2 in Title.php

$query2 was used to pass a variant. Make that deprecated, the
recommanded way is to use an array as a first parameter. Ex:

 $this->getLocalUrl( array( 'variant' => 'foo' ) );

Ping r105919

Hashar's comment:

I the idea of r105919 was to not break back compatibility. Since any call of a 
public getter eventually end up calling fixUrlQueryArgs() I though it would be 
a good it to add the deprecation notice there.

If you drop the second argument from the 4 callers, you will get PHP errors 
which is not really nice and my cause trouble with legacy extensions.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109558]: New comment added

[MediaWiki Mail]

"Bsitu" posted a comment on MediaWiki.r109558.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109558#c29818

Commit summary for MediaWiki.r109558:

Adding noindex, nofollow to Special Feedbackdashboard page

Bsitu's comment:

How could that happen! :), I always forget this

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109627]: Revision status changed

[MediaWiki Mail]

"Bhartshorne" changed the status of MediaWiki.r109627 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109627

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109627:

Use time.mktime() per CR on r105499

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r96546]: Revision status changed

[MediaWiki Mail]

"Nikerabbit" changed the status of MediaWiki.r96546 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546

Old status:  fixme
> New status: new

Commit summary for MediaWiki.r96546:

Enabled MoveLogFormatter
-> This brings better i18n even to existing move log entries
Fixed the class name from r96441, it's Move not Block
Added notes about new naming conventions to DefaultSettings.php
-> didn't bother the remain existing messages now, they will keep working
Didn't remove 1movedto2*, they are still used until I commit the code which 
actually makes new style log entries.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109282]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109282 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109282

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109282:

fix message

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109624]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109624 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109624

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109624:

AFT5 - followup to r109582, replace spaces with tabs.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r105499]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r105499 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105499

Old status:  fixme
> New status: resolved

Commit summary for MediaWiki.r105499:

added commented logging method.  used bind_port for internal URLs instead of
assuming port 80.  Protected an exception thrown when Last-Modified isn't
present.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109546]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109546 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109546

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109546:

Cache gallery object, don't create a new one unless we need to

Make getStartBody return something

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108696]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r108696 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108696

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r108696:

load options directly from a foreign wiki

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109625]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r109625 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109625

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109625:

Greatly simplify http request from r108696

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108586]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r108586 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108586

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108586:

only display banner if carrier is found

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109614]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109614 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109614

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109614:

typo in log file initalization

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r107462]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r107462 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107462

Old status:  new
> New status: ok

Commit summary for MediaWiki.r107462:

fix licenses to link to human readable versions at creativecommons.org (bug 
#0)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109612]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109612 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109612

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109612:

Use no message when removing rights because \n will be replaced by the 
'rightsnone' message if nothing follows

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109444]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109444 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109444

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109444:

added all fliters currently running or scheduled to run on emery

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r105574]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r105574 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105574

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r105574:

AFTv5: Partial fix for #32842, fix categories for sample (underscore vs space)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r102575]: New comment added

[MediaWiki Mail]

"^demon" posted a comment on MediaWiki.r102575.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102575#c29817

Commit summary for MediaWiki.r102575:

Commit to fix bug 30513.

^demon's comment:

Definitely needs release notes if we're bumping the export version.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109621]: New comment added, and revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r109621 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109621#c29816

Old Status: fixme
> New Status: ok

Commit summary for MediaWiki.r109621:

Revert r109196, code style fixes backported with no rationale

MaxSem's comment:

Though at this point I care only about 1.18wmf1... :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109600]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109600 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109600

Old status:  new
> New status: deferred

Commit summary for MediaWiki.r109600:

modified namespaces to analyze (main and user talk only)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109523]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109523 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109523

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109523:

Explicitly define the dependency on mediawiki.user for 
ext.articleFeedbackv5.startup.js

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109621]: New comment added, and revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r109621 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109621#c29815

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109621:

Revert r109196, code style fixes backported with no rationale

MaxSem's comment:

Grr grr, I specifically requested this backport to make my class that inherits 
from this one work on both 1.18 and 1.19.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109196]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109196 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109196

Old status:  new
> New status: reverted

Commit summary for MediaWiki.r109196:

MFT r102851, r102861

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109543]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109543 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109543

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109543:

MFT r109542

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109544]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109544 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109544

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109544:

MFT r109542

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109542]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109542 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109542

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109542:

Fix object munging to fix (bug 33818) GoogleNewsSitemap failing to return feeds

FeedItem sets ->title to the text, no the object

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109161]: New comment added, and revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109161 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29814

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109161:

deprecated $query2 in Title.php

$query2 was used to pass a variant. Make that deprecated, the
recommanded way is to use an array as a first parameter. Ex:

 $this->getLocalUrl( array( 'variant' => 'foo' ) );

Ping r105919

^demon's comment:

This doesn't accomplish anything really, fixUrlQueryArgs() is private, so 
nothing outside of this class can possibly be using it. Why not just fix those 
4 callers rather than doing this?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108937]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r108937 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108937

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108937:

r105512: Handle REDIRECT_URL discrepancies and always work with URI paths for 
thumb 404 handling

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108885]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r108885 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108885

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108885:

[Core JS] Fix code from r107327 which was broken by r108222
-- Of course one most not assume the DOM is finished enough for #p-logo to be 
parsed, simply bind to document ready

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109617]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109617 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109617

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109617:

Cleanup WikimediaMaintenance scripts slightly

Add INSERT IGNORE to RebuildInterwiki as apparently we build a list with 
duplicate keys

Bug 32813 - dumpInterwiki.php spews many warnings

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109618]: Revision status changed

[MediaWiki Mail]

"^demon" changed the status of MediaWiki.r109618 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109618

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109618:

Some fixes from r109617 brought in

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Text browser users won't see your important site notice

[Michael]

Anne,

Many thanks that you were aware of creating a log page. But, given the many 
difficult aspects, and the importance of being prepared in the future, would it 
be exaggerated to think it could become a very huge discussion ?

Could it perhaps be wise to split and structure even more right from the 
beginning (like, one page for each issue, and clear distinction between 
technical, and community / decision pages) ? 

While i imagine that distinction can not always be drawn clearly, but at least 
it should be tried. I am not that much into wiki culture but maybe it's 
possible to just copy the existing comments, and replace the existing content 
with just a table of contents of the subchapter pages.

More importantly, i wonder if that whole content is not more like the 'talk' 
side of a page that would be the 'article', that is, the extracted knowledge 
from all the comments. So why not start it as talk pages altogether.

-- Michal


> Perhaps folks with additional recommendations might want to add them at the
> post-mortem page on Meta.[1]
> 
> Risker/Anne
> 
> [1]
> http://meta.wikimedia.org/wiki/English_Wikipedia_anti-SOPA_blackout/Post-mortem


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] What happened to MediaWiki-CVS

[Chad]

On Fri, Jan 20, 2012 at 2:09 AM, Niklas Laxström
 wrote:
> I haven't received any new commit mails in the past 14 hours and the
> archives [1] are empty.
> [1] http://lists.wikimedia.org/pipermail/mediawiki-cvs/
>

Mail servers were migrated, but the post-commit hooks weren't
updated to point to the new hosts. This has been fixed now.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Text browser users won't see your important site notice

[Merlijn van Deen]

On 20 January 2012 15:22, Daniel Friesen  wrote:

> It is in fact difficult to do. The message that comes up when the site is
> down has nothing to do with what would be necessary to have the cluster
> serve out a sopa page.
>

Not only that, but also something I haven't seen anyone note in this
thread: the gains are very small. The part of the population that uses text
browsers is a) very small and b) technologically literate - i.e. most of
them would already know about SOPA. Although there are more people using
scriptblock, these people will be in general also quite technologically
literate.

Remember - this banner was not there for us to see. It was for the average
office worker, teacher and students. And we have all laughed at the
reactions on twitter - reactions that only showed we have reached the
target audience.

Best,
Merlijn
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r109582]: New comment added, and revision status changed

[MediaWiki Mail]

"Johnduhart" changed the status of MediaWiki.r109582 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109582#c29813

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109582:

AFT5 - Add permissions/roll checks to AFT5 feedback page and API calls. 
Requirements call for additional permissions on features that don't exist yet, 
which is why there are more roles than we seem to need.

Johnduhart's comment:

Mixes spaces and tabs.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109597]: New comment added

[MediaWiki Mail]

"Johnduhart" posted a comment on MediaWiki.r109597.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109597#c29812

Commit summary for MediaWiki.r109597:

wrapped lines to 100 columns, re-enabled some tests that were disabled
followup to r109594

Johnduhart's comment:

Don't comment out tests. Mark them as broken.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Text browser users won't see your important site notice

[Daniel Friesen]

On Fri, 20 Jan 2012 05:24:44 -0800, Thomas Dalton  
 wrote:



On 20 January 2012 01:06, Ryan Lane  wrote:

No, there isn't a difference. A blackout where everyone sees a page
with a particular message instead of the article they wanted is
exactly the same as unscheduled downtime where everyone sees a page
with a particular message instead of the article they wanted. If
search engines and caches can survive one of them, they can survive
both, since they are identical from an external perspective.



I'm sorry. but this is silly. I have a hard time believing that you
aren't simply trolling here.


How is it silly? I'm not trolling, I just think the way the blackout
was implemented looked really unprofessional and I can't see any good
reason for not having done a better job. All we wanted was for anyone
viewing any page on the site to see a particular static page rather
than what they would usually see. That isn't difficult to do, as
evidenced by the fact that it happens automatically whenever the site
breaks.


It is in fact difficult to do. The message that comes up when the site is  
down has nothing to do with what would be necessary to have the cluster  
serve out a sopa page.


The cluster is NOT designed to serve out something 'instead' of what it  
usually serves. The cluster is designed to serve Wikipedia's MediaWiki  
installation, period.


Error pages are served by the apaches, not the squids/varnishes. And we  
can't rely on that for the serving of a sopa page. An error page  
necessitates one of two interactions with the cache. Either the cache  
stores the contents of the error page and keeps serving that. Which  
obviously is NOT what one wants in the normal case, since the  
squid/varnish cache will be serving out an error page still after an issue  
has gone away. So naturally you'd expect that serving an error necessarily  
means that the cache is kept empty. But that's NOT what we want with a  
sopa page. If that happens then either we're still serving cached entries  
of Wikipedia articles when we're supposed to be serving a sopa page. Or  
EVERY request ends up bypassing the cache and hitting the apaches to get  
the uncached sopa page. Which is NOT an acceptable implementation of a  
sopa page because that kind of traffic bypassing the cache will kill the  
apaches and cripple the cluster. It would be like DDoSing Wikipedia's SOPA  
page.


So this means that a real sopa page would likely involve modifications of  
the caching configuration. Probably also something that involves purging  
the ENTIRE front end cache, both before and after the sopa setup. And  
naturally deployment of something that will serve the sopa page throughout  
the cluster. Potentially outside of the actual MediaWiki installation  
despite the fact that the cluster was only designed to handle the  
MediaWiki installation.
And of course ops also needs to make sure that the cluster can even handle  
the traffic when all the cached entries disappear and piles of requests  
need to be made to the apaches to repopulate the cache.

Then there is the issue of testing the whole thing before deployment.

So yes, the concept that a sopa page and error pages when the apaches  
can't handle traffic are identical is silly, very silly.


--
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r109611]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r109611 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109611

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109611:

r109455: Fix some errors
* URLs -> e-mails in the explaining text for the new feature
* Move closing ', behind the explaining text, otherwise it is a PHP comment only
* http -> https:
Spotted by kgh 
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Email-blacklist/en

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Text browser users won't see your important site notice

[Petr Bena]

Let's comment on the issue, not on the people

It's true that there wasn't lot of time to prepare this and that what
Thomas asked for, replace live site using a static content, is not so easy.
While there are many benefits (especially, mind the traffic - full content
overwritten with extra banner) from having a static page instead of live
site, replaced with javascript window I don't believe it was possible to
prepare such a site so fast and properly test if shutdown of whole english
wikipedia for that time, wouldn't break other systems. Also it would be
much harder to keep the content of static site updated regarding to request
made during the blackout.

I believe that operation team did a great work during the protest and I
know myself that lot of them spent whole night just by keeping an eye on
the whole cluster which was heavily impacted by this action and needed many
immediate updates done by them.

On Fri, Jan 20, 2012 at 2:41 PM, William Allen Simpson <
william.allen.simp...@gmail.com> wrote:

> On 1/19/12 8:06 PM, Ryan Lane wrote:
>
>> I'm sorry. but this is silly. I have a hard time believing that you
>> aren't simply trolling here.
>>
>>  Personally, I decided to stop responding to Thomas Dalton some time
> ago.  Many of his rants seem to be trolling.  Typical college freshman,
> knows more than the rest of us.
>
>
> __**_
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/**mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Text browser users won't see your important site notice

[William Allen Simpson]

On 1/19/12 8:06 PM, Ryan Lane wrote:

I'm sorry. but this is silly. I have a hard time believing that you
aren't simply trolling here.


Personally, I decided to stop responding to Thomas Dalton some time
ago.  Many of his rants seem to be trolling.  Typical college freshman,
knows more than the rest of us.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Text browser users won't see your important site notice

[Risker]

On 20 January 2012 08:24, Thomas Dalton  wrote:

> On 20 January 2012 01:06, Ryan Lane  wrote:
> >> No, there isn't a difference. A blackout where everyone sees a page
> >> with a particular message instead of the article they wanted is
> >> exactly the same as unscheduled downtime where everyone sees a page
> >> with a particular message instead of the article they wanted. If
> >> search engines and caches can survive one of them, they can survive
> >> both, since they are identical from an external perspective.
> >>
> >
> > I'm sorry. but this is silly. I have a hard time believing that you
> > aren't simply trolling here.
>
> How is it silly? I'm not trolling, I just think the way the blackout
> was implemented looked really unprofessional and I can't see any good
> reason for not having done a better job. All we wanted was for anyone
> viewing any page on the site to see a particular static page rather
> than what they would usually see. That isn't difficult to do, as
> evidenced by the fact that it happens automatically whenever the site
> breaks.
>


But that wasn't what was wanted, Thomas.  There was a specifically voiced
desire to make *certain* pages accessible - such as the articles about SOPA
and PIPA - and they were exempted from the blackout. That presented a
different operational challenge than a total blackout would do.   Given
that priority one will always be "don't break the site", I think the team
did about the best they could in the time they had, keeping in mind the
impossibility of testing alternate solutions.  It was just as important to
be able to confidently bring the site back up after 24 hours as it was to
go dark for those 24 hours.

Perhaps folks with additional recommendations might want to add them at the
post-mortem page on Meta.[1]

Risker/Anne

[1]
http://meta.wikimedia.org/wiki/English_Wikipedia_anti-SOPA_blackout/Post-mortem
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Text browser users won't see your important site notice

[Thomas Dalton]

On 20 January 2012 01:06, Ryan Lane  wrote:
>> No, there isn't a difference. A blackout where everyone sees a page
>> with a particular message instead of the article they wanted is
>> exactly the same as unscheduled downtime where everyone sees a page
>> with a particular message instead of the article they wanted. If
>> search engines and caches can survive one of them, they can survive
>> both, since they are identical from an external perspective.
>>
>
> I'm sorry. but this is silly. I have a hard time believing that you
> aren't simply trolling here.

How is it silly? I'm not trolling, I just think the way the blackout
was implemented looked really unprofessional and I can't see any good
reason for not having done a better job. All we wanted was for anyone
viewing any page on the site to see a particular static page rather
than what they would usually see. That isn't difficult to do, as
evidenced by the fact that it happens automatically whenever the site
breaks.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r109033]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r109033 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109033

Old status:  new
> New status: ok

Commit summary for MediaWiki.r109033:

test with MWDebug enabled (made possible by r109032)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108228]: New comment added

[MediaWiki Mail]

"SVG" posted a comment on MediaWiki.r108228.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108228#c29811

Commit summary for MediaWiki.r108228:

r107413: Changing BatchUserRights' class from 'BatchUserRights' to 
'SpecialBatchUserRights' again
HelpCommons: Only make category links blue in non-help-fetching wikis. Made 
them blue in previews of nonexistent pages in help-fetching wikis

SVG's comment:

Only r107413 was reverted. Not this action. I've changed the status to deferred 
and removed the follow-up r109592.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109111]: New comment added

[MediaWiki Mail]

"MaxSem" posted a comment on MediaWiki.r109111.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109111#c29810

Commit summary for MediaWiki.r109111:

Refactored SpamBlacklist to be extendable for other blacklist types

This is the groundwork for Bug 33761

MaxSem's comment:

* Although I admit I'm prone to abuse regexes too, $thisHttpRegex is not really 
needed, strpos() will suffice.
* $cachedRegexes = $wgMemc->get( "$wgDBname:{$listType}_blacklist_regexes" 
); - Use wfMemcKey(), it automatically prepends $wgDBname. Also please put 
variable part of the key name to the end to make reading key names easier.
* getArticleText() gives me the creeps, but it was so before you.
* BaseBlocklist probably should have been called BlocklistBase per precendents.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r108228]: Revision status changed

[MediaWiki Mail]

"SVG" changed the status of MediaWiki.r108228 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108228

Old status:  reverted
> New status: deferred

Commit summary for MediaWiki.r108228:

r107413: Changing BatchUserRights' class from 'BatchUserRights' to 
'SpecialBatchUserRights' again
HelpCommons: Only make category links blue in non-help-fetching wikis. Made 
them blue in previews of nonexistent pages in help-fetching wikis

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Wikimedia Trusted XFF List

[Petr Kadlec]

On 20 January 2012 13:22, Petr Bena  wrote:
> It shouldn't be kept in sync with trunk. There is a branched version in
> 1.18wmf1 we use on cluster atm.

Well, OK, you’re right. Then again, shouldn’t
http://www.wikimedia.org/trusted-xff.html be kept in sync with
http://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.18wmf1/extensions/TrustedXFF/trusted-hosts.txt?view=co
…? (Cause, currently, it obviously isn’t.)

-- [[cs:User:Mormegil | Petr Kadlec]]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Wikimedia Trusted XFF List

[Petr Bena]

Hello,

It shouldn't be kept in sync with trunk. There is a branched version in
1.18wmf1 we use on cluster atm.

On Thu, Jan 19, 2012 at 11:49 PM, Petr Kadlec  wrote:

> Hi,
>
> shouldn’t http://www.wikimedia.org/trusted-xff.html be kept in sync
> with
> http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/TrustedXFF/trusted-hosts.txt?view=co
> (or deleted/redirected)? Or is there another current valid list of the
> trusted XFF hosts?
>
> Regards,
> -- [[cs:User:Mormegil | Petr Kadlec]]
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r108864]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r108864 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108864

Old status:  new
> New status: ok

Commit summary for MediaWiki.r108864:

stylize.php and some minor identation and whitespace updates.
L10n update

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview