[MediaWiki-CodeReview] [MediaWiki r111202]: New comment added

[MediaWiki Mail]

"Nikerabbit" posted a comment on MediaWiki.r111202.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111202#c30760

Commit summary for MediaWiki.r111202:

Fix whitespace

Nikerabbit's comment:

That looks very broken when tab-width is something else. Just use spaces or 
newlines like everywhere else.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Git migration - updated schedule & workflow descriptions

[Niklas Laxström]

On 11 February 2012 03:51, Sumana Harihareswara  wrote:
> We had a meeting today to lay out some of the open questions and the
> answers.  Really raw notes are at
>
> https://www.mediawiki.org/wiki/Talk:Git/Conversion/issues#Topics_for_Chad.27s_email_to_wikitech-l_this_week
>
> It was so long that the email and blog post are going to happen early
> next week instead.  But here are some key points:
>
> * Please stop creating new extensions in Subversion, right now.  It
> makes Chad's migration work more error-prone.  If you want to create a
> new extension in git, ask Chad and he'll help you.

Since you already are suggesting people to start git repositories, we
should prepare the i18n support right now. Translatewiki.net is not
ready to handle random git repositories all over the world (nor it
necessarily wants to do that). MediaWIki has had very good i18n and
l10n including extensions - I don't want to lose that. So we need to
plan it now, not when we have hundreds of extensions migrated to git
and every one doing the things differently.

If our commit access is restricted (committing updated translations,
but also fixing i18n issues) we cannot do our job properly, which
means that we will start dropping support for stuff that doesn't
handle i18n adequately.

Which reminds me, does LocalisationUpdate support git? Or Extension Distributor?

> * As far as Chad knows, none of the gerrit bugs listed in
> https://labsconsole.wikimedia.org/wiki/Gerrit_bugs_that_matter are bad
> enough to block the migration.  What, *specifically*, do people hate
> about gerrit?  He needs to know specifics to make decisions that might
> delay the migration.

I read through almost all of the commit mails. If I need to spend any
more time on it or do more clicking around my head will probably
explode. This means that I want commit emails with links to review
tool, review tool should load fast, display all diffs inline (not
hidden behind links or anything) and I should be able to filter
commits by path or author. In addition I want to be able to tag
commits (for l10n team to review or keeping list of commits I want to
deploy to the live site). Any failure to meet these requirements is
highly likely to be a blocker for me. Oh and something that signs that
this commit has followups that fixes problems in it.

> * Chad is trying to get the real git repo up and running ASAP so people
> can start doing their real work there. He and RobLa believe we should
> encourage people to consider SVN indefinitely slushed.  If you are going
> to do large things, they prefer you start doing them in git.

We have been in a slush most of this year already and it has affected
the work of our team. We have already started to ignore the slush and
will probably do it again. On the other hand we probably will migrate
our extensions to git among the first ones.

Are extensions used by WMF forced to have the gated trunk model?

How much space do the git repos require? Right now we spend under 500M
to support the i18n of three branches of mediawiki and all extensions.

  -Niklas

-- 
Niklas Laxström

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111222]: New comment added, and revision status changed

[MediaWiki Mail]

"Nikerabbit" changed the status of MediaWiki.r111222 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111222#c30761

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r111222:

Working prototype of insertion of the text with annotations

Nikerabbit's comment:


+   this.$.on('m---ouseup', function( e ) {

?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111159]: New comment added

[MediaWiki Mail]

"Bryan" posted a comment on MediaWiki.r59.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59#c30762

Commit summary for MediaWiki.r59:

* (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.

Bryan's comment:

With upload type I mean upload source-type, not file type. It is possible to 
have different upload limits for upload-by-url, upload-from-file, etc. You'll 
see them in the upload form.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Git migration - updated schedule & workflow descriptions

[K. Peachey]

On Sat, Feb 11, 2012 at 7:20 PM, Niklas Laxström
 wrote:
> Which reminds me, does LocalisationUpdate support git? Or Extension 
> Distributor?

AFAIK No and No, For the latter I believe Tim (As to my understanding
when I last saw that discussed) is going to set up a RO Git -> SVN
mirror/gateway for that functionality, And since I saw that discussed
there has also been several end users comment in the channel about
wanting a mirror of phase3 as well.


Has the work been done, so the cluster is ready to support the base
being managed in Git compared to SVN?

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [pywikipedia r9880]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9880 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9880

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9880:

config.py:revert(sry)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9872]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9872 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9872

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9872:

Replaced firstcap() with builtin string method.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9873]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9873 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9873

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9873:

Rollback to previous, sorry about that (capitalize will decapitalize letters 
other than the first)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9872]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9872 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9872

Old status:  ok
> New status: resolved

Commit summary for pywikipedia.r9872:

Replaced firstcap() with builtin string method.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9874]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9874 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9874

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9874:

Oops, that was a merged version, will come later, this is the right one.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9875]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9875 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9875

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9875:

A new parameter, -first is introduced to handle overcrowded disambpages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9877]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9877 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9877

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9877:

Valhallasw discovered the dirty trick :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9876]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9876 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9876

Old status:  ok
> New status: resolved

Commit summary for pywikipedia.r9876:

With -hist, action "move" will write the edit history of old cat to the talk 
page of new cat for improved respect for copyright (not i18nized yet)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9878]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9878 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9878

Old status:  new
> New status: ok

Commit summary for pywikipedia.r9878:

Adding hu to ignore_title

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] Regarding GSoC 2012

[Raylton P. Sousa]

Hi *Aashish*, I'm one of authors of
BookManagerand i
have a relatively large knowledge of the issues that comprise the
wikibooks/wikisource (and others),  I had thought to solve this problem I
don't have time and/or sufficient knowledge yet, I have several ideas I
have listed 
here.
Can I help what is within my reach.

=D
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Common photo management plugins for MediaWiki

[lakmal padmakumara]

Hey Mike ,

First of all Thanks a lot for that nice feedback .

I would be grateful if you can illustrate a little bit on what you meant by
"GUI way of managing pictures" .
As I understood will it be a integrated option  to the edit menu of an
article where we can explore and search our photos in services like Flickr
,Picasa ,panoramio etc ,Select the required picture and insert the selected
picture in to our wiki document by one click.

Please correct me if I'm wrong .

On Sat, Feb 11, 2012 at 12:29 PM, Mike Dupont <
jamesmikedup...@googlemail.com> wrote:

> Hi there
> It would be great to have a better photo management tool.
> Currently I am using google to host my creative commons photos, and using
> the easy upload tools from google plus to load into the albums,
> from there they can be imported into panoramio and imported into mediawiki.
>
> So, really I find that that best way to upload photos is via google, and
> then import them into commons.
>
> the things that are really needed is
> 1. GUI way to manage the geotagging of photos.
> 2. an easy way to import existing photos.
> 3. a better way to manage many photos.
> 4. Import of files from archive.org would also be good.
>
> the entire system of processing photos for commons is too complex for
> beginners.
>
> mike
>
> On Sat, Feb 11, 2012 at 7:54 AM, lakmal padmakumara <
> lakmalpadmakum...@gmail.com> wrote:
>
> > Hey Thanks for the quick reply .
> > It is the third idea which is mentioned in this suggested
> > ideas >list
> > .
> > At the moment I'm doing a research on the availability of APIs of these
> > photo management Softwares .I am hoping to come up with  a draft proposal
> > which includes possible plugin list and basic implementation details of
> the
> > project in next few days .I will keep community updated about that .
> >
> > Meanwhile any guidelines ,tips or comments from the community is more
> than
> > welcome and highly appreciated .
> >
> > On Sat, Feb 11, 2012 at 3:30 AM, Platonides 
> wrote:
> >
> > > Hello lakmal,
> > > Good to meet you. This is indeed the right place.
> > > I don't see where it was suggested, but I haven't heard anyone to be
> > > working on that idea, so it seems perfectly available.
> > > I encourage you to prepare a draft proposal based on that.
> > >
> > >
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > >
> >
> >
> >
> > --
> > Thanks & Kind Regards
> >
> > Lakmal Padmakumara
> > Undergraduate
> > Computer Science and Engineering Department
> > University of Moratuwa
> > Sri Lanka
> > http://srilankatechnology.blogspot.com/
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
>
>
>
> --
> James Michael DuPont
> Member of Free Libre Open Source Software Kosova http://flossk.org
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



-- 
Thanks & Kind Regards

Lakmal Padmakumara
Undergraduate
Computer Science and Engineering Department
University of Moratuwa
Sri Lanka
http://srilankatechnology.blogspot.com/
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111229]: New comment added

[MediaWiki Mail]

"Umherirrender" posted a comment on MediaWiki.r111229.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111229#c30763

Commit summary for MediaWiki.r111229:

Add missing action messages.

Umherirrender's comment:

{{Messagedocumentation}}
I have add the qqq messages on translatewiki.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9881]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9881 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9881

Old status:  new
> New status: deferred

Commit summary for pywikipedia.r9881:

strip trailing whitespaces

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9876]: New comment added, and revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9876 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9876#c30764

Old Status: resolved
> New Status: fixme

Commit summary for pywikipedia.r9876:

With -hist, action "move" will write the edit history of old cat to the talk 
page of new cat for improved respect for copyright (not i18nized yet)

Xqt's comment:

withHistory is never used by the bot and the version history is alway tagged 
but it shouldn't e.g. in de-wiki.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r109990]: New comment added

[MediaWiki Mail]

"Umherirrender" posted a comment on MediaWiki.r109990.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109990#c30765

Commit summary for MediaWiki.r109990:

[Xml/Html] new method Html::namespaceSelector
* Using params and option arrays instead of 4 random parameters like 
Xml::namespaceSelector did
* Right now it's passing $selectAttribs['name'] to Xml::label, this is done 
because that's what Xml::namespaceSelector did. However it's wrong since labels 
associate over ID not NAME. Will fix in the next commit, making sure unit tests 
stay functional first. This bug has been in Xml::namespaceSelector for a long 
time but usually unnoticed as people kept either defaults. Although it was easy 
to get wrong as the NAME was configurable but the ID was hardcoded in 
Xml::namespaceSelector.
* Deprecated Xml::namespaceSelector and made it cal Html::namespaceSelector

* Follows-up r109974, r109698
* XmlTest.php still runs successfully

Umherirrender's comment:

Please add the warning for deprecated method only, when the method is not used 
in core. Thanks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [pywikipedia r9876]: Revision status changed

[MediaWiki Mail]

"Xqt" changed the status of pywikipedia.r9876 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9876

Old status:  fixme
> New status: resolved

Commit summary for pywikipedia.r9876:

With -hist, action "move" will write the edit history of old cat to the talk 
page of new cat for improved respect for copyright (not i18nized yet)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111142]: New comment added

[MediaWiki Mail]

"SPQRobin" posted a comment on MediaWiki.r42.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/42#c30766

Commit summary for MediaWiki.r42:

Update all wfMsg*() -> wfMessage(), and drop DummyLinker compatibility

SPQRobin's comment:

Yes, I know wrapWikiMsg, but I prefer it this way :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r110955]: New comment added

[MediaWiki Mail]

"Umherirrender" posted a comment on MediaWiki.r110955.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110955#c30767

Commit summary for MediaWiki.r110955:

(bug 33374) - 'Deletion log summary not properly truncated'

Umherirrender's comment:

Now the log looks good, but the log entry in the recentchanges is not 
truncated, see [[rev:96441#c30457]].

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111229]: Revision status changed

[MediaWiki Mail]

"Nikerabbit" changed the status of MediaWiki.r111229 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111229

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111229:

Add missing action messages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Logging & messages

[Niklas Laxström]

On 10 February 2012 17:32, Beebe, Mary J  wrote:
> I was trying to use this old extension: 
> http://www.mediawiki.org/wiki/Extension:UserLoginLog to log login attempts.  
> It used $wgMessageCache; therefore it worked fine until we went to a 1.18 
> wiki.  I tried to modernize it by creating a UserLoginLog.i18n file to keep 
> the messages.
>
>
>
> I have $wgExtensionMessagesFiles['userLoginLog'] = dirname( __FILE__ ) . 
> "/UserLoginLog.i18n.php";  at setup.

Looks good this far.

> A sample method is:
>
> function wfUserLoginLogSuccess(&$user) {
>
>        wfLoadExtensionMessages( 'userLoginLog' );
>
>        $log = new LogPage('userlogin',false);
>
>        $log->addEntry('success',$user->getUserPage(),wfGetIP());
>
>        return true;
>
>        }
>
>
>
> The statement 'wfLoadExtensionMessages( 'userLoginLog' );' does not seem to 
> do anything because the message in the log is    instead 
> of the message.

wfLoadExtensionMessages hasn't done anything for a while. The needed
messages are loaded automatically, as long as the files are registered
with $wgExtensionMessagesFiles.

> I am not sure how to pass in the message log name or how to make it global 
> now that wgmessageCache is no longer available.  Is there a document on how 
> to use the logging feature in the wiki?

Maybe your i18n file is not properly formatted, or it is cached. Try
running 'php maintenance/rebuildLocalisationCache.php' fom the command
line.
  -Niklas


-- 
Niklas Laxström

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111120]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r20.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/20#c30768

Commit summary for MediaWiki.r20:

* (bug 32341) Add upload by URL domain limitation.

Essentially reverts r109741  live again

Which was r109562, r109564, r109570

Reedy's comment:

Why am I not getting emails from CR atm? :/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111120]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r20 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/20

Old status:  fixme
> New status: new

Commit summary for MediaWiki.r20:

* (bug 32341) Add upload by URL domain limitation.

Essentially reverts r109741  live again

Which was r109562, r109564, r109570

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111120]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r20.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/20#c30769

Commit summary for MediaWiki.r20:

* (bug 32341) Add upload by URL domain limitation.

Essentially reverts r109741  live again

Which was r109562, r109564, r109570

Reedy's comment:

Also, omg table css change...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111239]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r111239.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111239#c30770

Commit summary for MediaWiki.r111239:

Followup r11120, wfParseUrl() can return false, if it does, the host isn't 
going to be valid

Reedy's comment:

r20 rather

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111017]: New comment added

[MediaWiki Mail]

"SPQRobin" posted a comment on MediaWiki.r111017.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111017#c30771

Commit summary for MediaWiki.r111017:

put in r110285 again now that 1.19 branched

SPQRobin's comment:

This is useful, I was considering adding such a hook too. However, this doesn't 
affect internal links in page content (they remain redlinks) and I think it 
would be better/more logical if it does. They're checked in LinkHolderArray.php 
calling Title->isAlwaysKnown() and page existence checks are optimised in that 
file so I suppose we can't just change it to call isKnown(). We could perhaps 
either add a parameter to isKnown() which would skip the $this->exists() check 
or move this hook to isAlwaysKnown().

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111247]: Revision status changed

[MediaWiki Mail]

"GWicke" changed the status of MediaWiki.r111247 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111247

Old status:  new
> New status: deferred

Commit summary for MediaWiki.r111247:

Move data-* annotations into separate object on tokens, that is then
serialized into a single data-mw-rt attribute if present. Update parserTests
to ignore this attribute for comparisons with expected parser output.

A few more tweaks and notes are thrown into this commit too. 233 tests are
passing now.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111234]: New comment added, and revision status changed

[MediaWiki Mail]

"RobLa-WMF" changed the status of MediaWiki.r111234 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111234#c30772

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r111234:

Remove some methods marked for removal in 1.20 and update FakeTitle accordingly.
No more callers in core or extensions.

RobLa-WMF's comment:

Please revert this, both based on the ongoing code slush and frequent 
conversations on wikitech-l about breaking backwards compatibility.  At a 
minimum, there needs to be an email to wikitech-l saying this work will be done.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111231]: New comment added, and revision status changed

[MediaWiki Mail]

"RobLa-WMF" changed the status of MediaWiki.r111231 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111231#c30773

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r111231:

* Remove last remaining traces of wfLoadExtensionMessages().
* Add missing action message and remove unused global in UploadLocal.
* Some whitespace updates in Maps.

RobLa-WMF's comment:

Per our frequent conversations on wikitech-l, we shouldn't break backwards 
compatibility unless we have to.  This function is doing no harm (it's doing 
nothing).  The Semantic MediaWiki folks have explicitly stated their desire to 
support older versions of MediaWiki, yet you even broke their code that would 
still work *with* removing the function:


-   if ( version_compare( $wgVersion, '1.16', '<' ) ) {
-   wfLoadExtensionMessages( 'SemanticMediaWiki' );
-   }


...and you removed smwfLoadExtensionMessages() as well.

That's just rude.  Please revert.



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111223]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111223 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111223

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111223:

Follow-up to r111091. Dont paste md5 in the code.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111091]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111091 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111091

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r111091:

(bug 17416) Don't prompt for summary when summary is preset using &summary=

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111221]: Revision status changed

[MediaWiki Mail]

"RobLa-WMF" changed the status of MediaWiki.r111221 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111221

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111221:

Reverted r88: backport conflict fodder

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111239]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111239 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111239

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111239:

Followup r11120, wfParseUrl() can return false, if it does, the host isn't 
going to be valid

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111120]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r20 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/20

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r20:

* (bug 32341) Add upload by URL domain limitation.

Essentially reverts r109741  live again

Which was r109562, r109564, r109570

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111236]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111236 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111236

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111236:

Added two blogs per request on meta

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111242]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111242 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111242

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111242:

Fix casing on OutputPage::setPageTitle() call and pass it a Message object

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111246]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111246 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111246

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111246:

Use local context to get messages

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111240]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111240 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111240

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111240:

Drag in a change noticed in wmf branches

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111238]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111238 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111238

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111238:

Bug 34328 - Syntax error in CentralAuthPlugin.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111226]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111226 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111226

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111226:

re r86: remove extra form tag.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111186]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r86 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86

Old status:  new
> New status: resolved

Commit summary for MediaWiki.r86:

Fixes Bug 18704 - Add an unique CSS class or ID to the tagfilter table row at 
RecentChanges
Patch from Jarry1250

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111203]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r111203 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111203

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111203:

(bug 32210) UserMailer.php: New edit emails should offer a single-diff link.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111218]: New comment added

[MediaWiki Mail]

"RobLa-WMF" posted a comment on MediaWiki.r111218.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111218#c30774

Commit summary for MediaWiki.r111218:

attempt to fix bug33989 - fix the mode parameter in api call

RobLa-WMF's comment:

This is so full of win!  I love it that such an insidious-seeming bug has a 
relatively small fix.

It might make things a ''little'' easier to understand to call:
 $wgCategoryTreeCategoryPageOptions['mode'] = CategoryTree::decodeMode( 
$wgRequest->getVal( 'mode' ) );
...and then put the $wgCategoryTreeCategoryPageMode setting logic in 
CategoryTree::decodeMode function, since there's other logic in there which 
does default setting.  That said, on casual inspection it's pretty hard to 
figure out the interplay of globals here, so I don't think that minor tweak 
would matter that much.  Since this is a tested combination, seems great to 
call it good for 1.19. 


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111249]: Revision status changed

[MediaWiki Mail]

"GWicke" changed the status of MediaWiki.r111249 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111249

Old status:  new
> New status: deferred

Commit summary for MediaWiki.r111249:

Remove WikiDom default serialization and --html argument from parse.js
wrapper. HTML ist now the only supported format. The DOMConverter is now no
longer used. Roan, feel free to remove / butcher it for direct HTML to linear
model conversion.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111185]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r85.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85#c30775

Commit summary for MediaWiki.r85:

(bug 21256) Add "islqttalkpage" parameter to prop=info. Patch is by John Du 
Hart, with minor style and formatting tweaks by me.

Duplicatebug's comment:

Please do not add unconditionally new output to a api module. It is better, to 
add new option to prop=info and check, if the option is set and than add the 
information. That avoid a waste of performance/time, when the caller does not 
need that information. With the param you have a documentation at the api help 
page, which is also a nice to have.

You should not create your own title objects (A function you call, need the 
page id, which is not set in your case and that means a seperate query to the 
database).

Better it is to get the PageSet and operate on the "GoodTitles" (that all pages 
from the query, which are valid and exist) and maybe on the "MissingTitles" (if 
you want support this information for non-existing pages).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111168]: New comment added

[MediaWiki Mail]

"Tbleher" posted a comment on MediaWiki.r68.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68#c30776

Commit summary for MediaWiki.r68:

GOOD BYE $wgArticle!
It was stated that it would be removed in 1.20 and we are in 1.20.

Tbleher's comment:

Hmm, so how does one access article related information now?

I have the following simple code, and couldn't see how to port it to MW 1.20, 
despite searching for quite a while:

$wgHooks['SkinTemplateNavigation'][] = 'wfAlterEditPageLinkHook2';
function wfAlterEditPageLinkHook2( &$vector, &$links ) {
global $wgTitle, $wgArticle;
if( array_key_exists( 'edit', $links['views'] ) && 
$wgTitle->isContentPage() && $wgArticle !== null && $wgArticle->isCurrent() ){
if( $wgTitle->exists() ) {
$links['views']['edit']['href'] = Title::newFromText( 
'Spezial:Spiel_bearbeiten/'. $wgTitle->getPrefixedDBkey() )->getLocalUrl();
} else {
$links['views']['edit']['href'] = Title::newFromText( 
'Spezial:Neues_Spiel/'. $wgTitle->getPrefixedDBkey() )->getLocalUrl();
}
}
return true;
}

(the code redirects the edit link to a special page, but only if the page 
viewed is the current version of the article).

Could you document how to do something like this when using MW 1.20? The best 
place to document this would probably be [[Manual:$wgArticle]].

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111201]: Revision status changed

[MediaWiki Mail]

"MarkAHershberger" changed the status of MediaWiki.r111201 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111201

Old status:  fixme
> New status: new

Commit summary for MediaWiki.r111201:

part 1 of fix for Bug 30332 - API spamblocklist error should provide *all* 
blocked URLs, not just one
Patch from Jarry1250

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111254]: Revision status changed

[MediaWiki Mail]

"Jeroen De Dauw" changed the status of MediaWiki.r111254 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111254

Old status:  deferred
> New status: ok

Commit summary for MediaWiki.r111254:

removed old countdown code from further files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111252]: Revision status changed

[MediaWiki Mail]

"Jeroen De Dauw" changed the status of MediaWiki.r111252 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111252

Old status:  deferred
> New status: ok

Commit summary for MediaWiki.r111252:

fixed typo in SQL statement for deleting all queries; should fix Bug 31153

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] "backcompat" keyword

[Rob Lanphier]

Hi everyone,

After Niklas mentioned in another thread that the i18n team was
effectively ignoring the code slush, I decided to do some spot
checking to see what couldn't wait.  What I saw was a lot of backwards
compatibility breakage that's going to make releasing 1.19 and the
eventual 1.20 release a lot harder, and make life generally miserable
for third party users of MediaWiki that just want to stay on top of
security releases and maybe want to install a new extension or two,
but have extensions that they can't afford the dev resources to
update.  I've been there myself, and it sucks.

At a minimum, we need to start marking backwards-compatibility
breaking changes.  So, I've created the "backcompat" keyword, and
started the task of marking these.  I'd like help in marking these
things, since I suspect we've got a lot of work before we can release
a 1.19 tarball.

Here's the list so far:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/backcompat

It's hard enough to make things work.  Expending effort trying to make
things *not* work is bound to be more successful than anyone is
banking on.  Please stop this.

Thanks
Rob

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111168]: New comment added, and revision status changed

[MediaWiki Mail]

"RobLa-WMF" changed the status of MediaWiki.r68 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68#c30777

Old Status: ok
> New Status: fixme

Commit summary for MediaWiki.r68:

GOOD BYE $wgArticle!
It was stated that it would be removed in 1.20 and we are in 1.20.

RobLa-WMF's comment:

As much as I would love to see us ditch a lot of the globals, this is not the 
time to make this change.  Please revert.

See this email for more:  
http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/58678

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111201]: New comment added

[MediaWiki Mail]

"RobLa-WMF" posted a comment on MediaWiki.r111201.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111201#c30778

Commit summary for MediaWiki.r111201:

part 1 of fix for Bug 30332 - API spamblocklist error should provide *all* 
blocked URLs, not just one
Patch from Jarry1250

RobLa-WMF's comment:

I'd prefer it if you reverted this.  I'm not sure I see the value in having 
one-half of Jarry1250's patch applied.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1121]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1121 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1121

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1121:

MFT  r938, r939, r940, r941, r949, r1015, r1032, r1036, r1064.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1122]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1122 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1122

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1122:

MFT  r938, r939, r940, r941, r949, r1015, r1032, r1036, r1064.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1174]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1174 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1174

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1174:

MFT r1151, r1156, r1157, r1159, r1161, r1166, r1167, r1168, r1169, r1170, r1172

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1175]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1175 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1175

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1175:

MFT r1151, r1156, r1157, r1159, r1161, r1166, r1167, r1168, r1169, r1170, r1172

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1285]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1285 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1285

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1285:

MFT r1217, r1218, r1240, r1245, r1248, r1249, r1250, r1252, r1253, r1258, 
r1263, r1279

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1288]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1288 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1288

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1288:

MFT  r1173, r1210, r1215, r1216, r1224, r1225, r1226, r1280

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1289]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1289 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1289

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1289:

MFT   r1104, r1109, r1110, r1114, r1123, r1124, r1125, r1126, r1130, r1131, 
r1132, r1162

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1291]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1291 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1291

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1291:

MFT r1290

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1293]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1293 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1293

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1293:

MFT r1292

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1295]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1295 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1295

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1295:

MFT r1294

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82029]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r82029.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82029#c30779

Commit summary for MediaWiki.r82029:

* (bug 17160) Gender specific display text for User namespace
Second attempt for this thing..

Duplicatebug's comment:

Thanks for r108498

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1328]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of Wikimedia.r1328 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1328

Old status:  new
> New status: ok

Commit summary for Wikimedia.r1328:

Fixes r1212 issue with missing where statement.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82029]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r82029.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82029#c30780

Commit summary for MediaWiki.r82029:

* (bug 17160) Gender specific display text for User namespace
Second attempt for this thing..

Duplicatebug's comment:

I have create bug 34340 for this.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111017]: New comment added

[MediaWiki Mail]

"Jeroen De Dauw" posted a comment on MediaWiki.r111017.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111017#c30781

Commit summary for MediaWiki.r111017:

put in r110285 again now that 1.19 branched

Jeroen De Dauw's comment:

Good, catch, I had actually not noticed links in pages remained redlinks. That 
sucks.

I'm reluctant to just move over the hook though, as the docs for isAlwaysKnown 
state:

"This function is semi-deprecated for public use, as well as somewhat 
misleadingly named.  You probably just want to call isKnown(), which calls this 
function internally."

What about having LinkHolderArray call isKnown instead? Would this cause issues?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111220]: New comment added

[MediaWiki Mail]

"Jeroen De Dauw" posted a comment on MediaWiki.r111220.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111220#c30782

Commit summary for MediaWiki.r111220:

Missing files from r111215

Jeroen De Dauw's comment:

Yes, I agree with that. I already discussed this a while back with Van. See 
here for my thoughts: 
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056436.html

I don't have time at this point to start this work, but if you feel like giving 
it a go, I'll be happy to help finishing it up if needed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111220]: New comment added

[MediaWiki Mail]

"Danwe" posted a comment on MediaWiki.r111220.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111220#c30783

Commit summary for MediaWiki.r111220:

Missing files from r111215

Danwe's comment:

Perhaps I'll look into it at some point. But right now I am working on a new 
semantic extension and there is still the changes for the Maps extension I 
still have not implemented yet, as well as a couple of other things :/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Phabricator

[Ryan Lane]

On Fri, Feb 10, 2012 at 5:08 AM, John Du Hart  wrote:
> Unless you've been living under a rock (If you have, how's the wifi under
> there?) we're moving to git soon. Along with this will come a change in how
> we do code review. However, some people have expressed concerns over the
> usability of gerrit. Therefore I'd like to propose an alternative.
>
> Phabricator is a code review tool written by and for Facebook that has
> been open sourced. For an introduction, see this:
> http://phabricator.com/docs/phabricator/article/Introduction.html
>
> I've written up some documentation about Phabricator for our uses here:
> https://www.mediawiki.org/wiki/Phabricator
>
> I would really like for some of our developers and reviewers to try this
> out as an alternative to gerrit. Personally I've found it much more
> pleasurable to work with than gerrit. If we think this might be a viable
> solution for us then I'd be willing to work on adding more integration
> (LDAP support and Unit testing integration).
>
> Let me know if you have any questions or feedback. Thanks!
>

We have to consider how this will affect the operations team as well.
We have a very hard requirement of review before merge, and we must
have fine-grained permissions per-branch. It would be a serious shame
to use phabricator for mediawiki development and gerrit for operations
development. We need *more* integration between operations and
development, not less.

We also need to consider Labs integration. I've been putting a lot of
effort into building things around gerrit's model (which is fairly
good, even if its UI is terrible). I'm fine with switching to
something else as long as it's going to actually work.

- Ryan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] new extension in SVN: EtherpadLite

[Thomas Gries]

https://www.mediawiki.org/wiki/Extension:EtherpadLite





signature.asc
Description: OpenPGP digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111220]: New comment added

[MediaWiki Mail]

"Jeroen De Dauw" posted a comment on MediaWiki.r111220.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111220#c30784

Commit summary for MediaWiki.r111220:

Missing files from r111215

Jeroen De Dauw's comment:

Right. I know how that goes :)

Might be worth writing a GSoC proposal for...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Phabricator

[Ryan Lane]

On Fri, Feb 10, 2012 at 5:08 AM, John Du Hart  wrote:
> Unless you've been living under a rock (If you have, how's the wifi under
> there?) we're moving to git soon. Along with this will come a change in how
> we do code review. However, some people have expressed concerns over the
> usability of gerrit. Therefore I'd like to propose an alternative.
>
> Phabricator is a code review tool written by and for Facebook that has
> been open sourced. For an introduction, see this:
> http://phabricator.com/docs/phabricator/article/Introduction.html
>
> I've written up some documentation about Phabricator for our uses here:
> https://www.mediawiki.org/wiki/Phabricator
>
> I would really like for some of our developers and reviewers to try this
> out as an alternative to gerrit. Personally I've found it much more
> pleasurable to work with than gerrit. If we think this might be a viable
> solution for us then I'd be willing to work on adding more integration
> (LDAP support and Unit testing integration).
>
> Let me know if you have any questions or feedback. Thanks!
>

I forgot. There's one other thing I wanted to point out about
phabricator. To properly use it, you must have php installed wherever
you are working from. I like that it uses PHP on the server side, but
despise that it uses it on the client side.

I also have a few questions:

* Who's going to get stuck with maintaining the LDAP support?
* Does it already integrate with Jenkins?
* Does it use the system SSH, or a separate SSH daemon?
* What permissions model does it have?
* Does it manage the repositories and branches?
* How are repos created?
* Does it support server side branches?
* Does it handle merges automatically?

- Ryan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Regarding GSoC 2012

[Aashish Mittal]

Hello,

Thanks a lot for the reply.

I am currently going through the project for implementing book management.
I have read through and installed Collection and BookManager extensions and
am going through other documentation related with this project.

Also, regarding the Convention extension, I am exploring the features
offered by 
OpenCWand
wiscondb. I will be installing OpenCW to get an idea of the usage and
will start looking into developing wikimedia extensions. Will try to get a
fair idea of the functionalities and their implementation details that are
needed to be achieved in this project. Will be discussing these on the list
and irc. Any suggestions on features/requirements that can be incorporated
in this project for making it better and more usable would be great to hear.

Thanks,
Aashish


On Sat, Feb 11, 2012 at 8:19 AM, K. Peachey  wrote:

> On Sat, Feb 11, 2012 at 8:01 AM, Platonides  wrote:
> > On 10/02/12 18:54, Aashish Mittal wrote:
> >> 2. Convention extension for converting mediawiki wiki into website for
> >> conference. I have been through the links, but I would like to get a
> better
> >> technical understanding of this project related to the implementation of
> >> the project. Any appropriate link or some useful guidelines would be
> great.
> >
> > Is this a new proposal? I remember about someone having implemented
> > something similar.
>
> Sounds like the DumpHTML extension...
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



-- 
Aashish Mittal
Student at University of Mumbai
Yahoo:av_mit...@ymail.com
Gtalk: ashishmittal.m...@gmail.com
LinkedIn: www.linkedin.com/in/aashishmittal
Phone: +919930820950
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Phabricator

[John Du Hart]

On Sat, Feb 11, 2012 at 4:46 PM, Ryan Lane  wrote:

> On Fri, Feb 10, 2012 at 5:08 AM, John Du Hart 
> wrote:
> > Unless you've been living under a rock (If you have, how's the wifi under
> > there?) we're moving to git soon. Along with this will come a change in
> how
> > we do code review. However, some people have expressed concerns over the
> > usability of gerrit. Therefore I'd like to propose an alternative.
> >
> > Phabricator is a code review tool written by and for Facebook that has
> > been open sourced. For an introduction, see this:
> > http://phabricator.com/docs/phabricator/article/Introduction.html
> >
> > I've written up some documentation about Phabricator for our uses here:
> > https://www.mediawiki.org/wiki/Phabricator
> >
> > I would really like for some of our developers and reviewers to try this
> > out as an alternative to gerrit. Personally I've found it much more
> > pleasurable to work with than gerrit. If we think this might be a viable
> > solution for us then I'd be willing to work on adding more integration
> > (LDAP support and Unit testing integration).
> >
> > Let me know if you have any questions or feedback. Thanks!
> >
>
> I forgot. There's one other thing I wanted to point out about
> phabricator. To properly use it, you must have php installed wherever
> you are working from. I like that it uses PHP on the server side, but
> despise that it uses it on the client side.
>
> I also have a few questions:
>
> * Who's going to get stuck with maintaining the LDAP support?
> * Does it already integrate with Jenkins?
> * Does it use the system SSH, or a separate SSH daemon?
> * What permissions model does it have?
> * Does it manage the repositories and branches?
> * How are repos created?
> * Does it support server side branches?
> * Does it handle merges automatically?
>
> - Ryan
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

* Me
* Why would it need to, it runs unit and lint tests before the diff is
posted

The rest of the questions are irrelevant because, unlike gerrit,
Phabricator does not manage git repositories.

-- 
John
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111271]: New comment added

[MediaWiki Mail]

"Wikinaut" posted a comment on MediaWiki.r111271.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111271#c30785

Commit summary for MediaWiki.r111271:

Fix global typo

Fix whitespace, remove unused global that wasn't defined

Wikinaut's comment:

(thanks. Re whitespaces: I need to use another editor)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111271]: New comment added

[MediaWiki Mail]

"Wikinaut" posted a comment on MediaWiki.r111271.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111271#c30786

Commit summary for MediaWiki.r111271:

Fix global typo

Fix whitespace, remove unused global that wasn't defined

Wikinaut's comment:

(removal of unused variable: perfect. This parameter was a relict before I 
added $userName  = $wgUser->getName();)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111263]: New comment added, and revision status changed

[MediaWiki Mail]

"Bawolff" changed the status of MediaWiki.r111263 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30787

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Bawolff's comment:

Some comments:
 function efEtherpadLiteParser_Initialize( &$parser )

Doing the & in &$parser isn't needed anymore as far as I am aware. (OTOH, it 
doesn't hurt anything either)

The empty function is generally discouraged in the coding conventions.

 $wgEtherpadLiteDefaultPadUrl= "http://www.example.com/p/";;

One alternative possibility is to do $wgEtherpadLiteDefaultPadUrl= 
null instead as default, and when you're about to display the pad, check 
for null and yell at user to configure the extension if the variable is null.
 $wgEtherpadLiteShowControls = 'true';
 ...
I'm not really a fan of using a string true. It would be better to use a 
boolean true value, and then convert that to a string when making the iframe 
url parameters.

  $padId= ( !empty( $args['pad-id'] ) ) ? $args['pad-id'] : "" ;
  ...

There's no validation of user input here. I'm not sure how much evil can be 
accomplished via the url parameters. Worst case scenario would be of course if 
etherpad had an xss vulnrability in terms of its url parameters (Of course you 
have to allow most input here because pads can be named everything, but should 
at least check for & since those separate url parameters.

  ( !empty( $args['pad-url'] ) ) ? $args['pad-url'] : 
$wgEtherpadLiteDefaultPadUrl

this is kind of scary, an evil user can then embed an iframe to an arbitrary 
site. This could perhaps be used to do some kind of clickjacking attack against 
some other site, track users of a wiki, other evil stuff etc.

This is also an XSS attack by doing something like 

 +  "id" => "epframe$padId",

Minor issue, but user could potentially make an id that is not a valid one. 
(HTML has some restrictions on ids if i recall). Also what if someone embeds 
the same pad twice (ids must be unique)?

 $userName  = $wgUser->getName();

No garuntee the user who parsed the page is the one viewing the page. Either 
need to call $parser->disableCache(), add the username process at some later 
stage (like use js, or possibly some hook that runs right before outputting the 
page).

 "style"  => "width:$width;height:$height",
CSS needs to be sanitized (There's a method somewhere in the Sanitizer for that 
i think). Certain browsers can be caused to execute js via certain css rules.

 return array( $output, 'noparse' => true, 'isHTML' => true );

That's the return value format for parser functions not parser tags. Parser 
tags you just return the html as a string. (There is an extended return value 
system for parser tags where you can specify markerType for example, but the 
element names of the array are different from the parser function return value)

 $wgExtensionCredits['other'][]

Generally this would probably be considered a "hook" extension not an "other" 
extension.

Cheers.

p.s. You should perhaps coordinate with NeilK. If i recall he was interested in 
etherpad <-> mediawiki stuff at one point.











___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111263]: New comment added

[MediaWiki Mail]

"Bawolff" posted a comment on MediaWiki.r111263.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30788

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Bawolff's comment:

Also two other things:

Might be nicer to use wfAppendQuery() instead of constructing the 
url with string concatenation, and for the boolean parameters (!empty( 
$args['show-controls'] ) )...) it should definitly validate that they 
are either true or false.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111266]: Revision status changed

[MediaWiki Mail]

"Platonides" changed the status of MediaWiki.r111266 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111266

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111266:

Follow up to r111264; update @since tags

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111264]: New comment added, and revision status changed

[MediaWiki Mail]

"Platonides" changed the status of MediaWiki.r111264 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30789

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r111264:

adding DBDataObject class after having some people review it and posting on the 
list. docs can currently be found at 
https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject

Platonides's comment:

Your use of an anonymous function in line 215 is PHP 5.3+ only (probably even 
more due to the use clause).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111264]: New comment added, and revision status changed

[MediaWiki Mail]

"Jeroen De Dauw" changed the status of MediaWiki.r111264 to "new" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30790

Old Status: fixme
> New Status: new

Commit summary for MediaWiki.r111264:

adding DBDataObject class after having some people review it and posting on the 
list. docs can currently be found at 
https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject

Jeroen De Dauw's comment:

This class is 5.3 dependent as described in the docs. You can get rid of the 
anon functions, but not of the late static bindings (unless you want to do evil 
stuff).

That's the way it is unfortunately - only code that can depend on 5.3 can use 
this. That means none of core for now, until we ditch 5.2, but most new 
extensions can happily require 5.3 (esp since 5.3 is now on the cluster).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111264]: New comment added

[MediaWiki Mail]

"Bawolff" posted a comment on MediaWiki.r111264.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30791

Commit summary for MediaWiki.r111264:

adding DBDataObject class after having some people review it and posting on the 
list. docs can currently be found at 
https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject

Bawolff's comment:

I'm really not a fan of putting stuff in core that requires 5.3 until such a 
time as we have bumped the required version to 5.3. Even if only extensions use 
the code (which honestly, probably won't stay that way once these classes are 
in core) it seems rather wrong.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111263]: New comment added

[MediaWiki Mail]

"Wikinaut" posted a comment on MediaWiki.r111263.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30792

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Wikinaut's comment:

Thanks for your deep analysism, which I appreciate very much.

As you might have noticed, I already use Sanitizer::cleanUrl and 
Html:rawElement methods as mentioned in the Security Guides.

Regarding the pad-id, and the query string parameters - which are then forming 
part of the url - I now think of sanitizing the whole "src" parameter like in 
this example

"src"=> Sanitzer::cleanUrl("$epliteHostUrl/$padId" .
"?showControls=$showControls" .
"&showChat=$showChat" .
"&showLineNumbers=$showLineNumbers" .
"&useMonospaceFont=$useMonospaceFont" .
"&userName=$userName" .
"&noColors=$noColors"),


If this works, will it fulfill the mw requirements for a sane code ?

The Html:rawElement was mentioned as a good way to sanitize here 
https://www.mediawiki.org/wiki/Security_checklist_for_developers#Output_.28API.2C_CSS.2C_JavaScript.2C_HTML.2C_XML.2C_etc..29
 , so I thought, it is enough to use this method. 

Pls. correct me, if I am wrong.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111264]: New comment added

[MediaWiki Mail]

"Jeroen De Dauw" posted a comment on MediaWiki.r111264.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30793

Commit summary for MediaWiki.r111264:

adding DBDataObject class after having some people review it and posting on the 
list. docs can currently be found at 
https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject

Jeroen De Dauw's comment:

I see your point. This would need clear docs that it requires 5.3 to avoid 
accidents. Then again, these should be easy to spot. This class could 
theoretically be put into it's own extension, but the hassle involved with this 
is probably more work then fixing any misuse of this class if it where to 
happen when it's in core.

Sort of makes me wonder when we finally will drop 5.2.x support in core though. 
That version lost official support by the PHP guys long ago (2 years?). This 
class is one more reason to drop support.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111263]: New comment added

[MediaWiki Mail]

"Bawolff" posted a comment on MediaWiki.r111263.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30794

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Bawolff's comment:



The Html:rawElement was mentioned as a good way to sanitize here 
https://www.mediawiki.org/wiki/Security_checklist_for_developers#Output_.28API.2C_CSS.2C_JavaScript.2C_HTML.2C_XML.2C_etc..29
 , so I thought, it is enough to use this method. 

That page was misleading (I changed it). Html::rawElement makes sure your 
attributes are encoded (So people don't do crap like width='foo" 
>

[MediaWiki-CodeReview] [MediaWiki r111168]: New comment added

[MediaWiki Mail]

"Bawolff" posted a comment on MediaWiki.r68.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68#c30795

Commit summary for MediaWiki.r68:

GOOD BYE $wgArticle!
It was stated that it would be removed in 1.20 and we are in 1.20.

Bawolff's comment:

If we really aren't going to kill this now ( Why exactly is this not the time. 
Will it ever be the time? ). Could we perhaps have a class similar to 
StubObject, that basically just issues a wfDeprecated warning the first time 
someone uses the global, to further discourage people from using the global.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111168]: New comment added

[MediaWiki Mail]

"RobLa-WMF" posted a comment on MediaWiki.r68.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68#c30796

Commit summary for MediaWiki.r68:

GOOD BYE $wgArticle!
It was stated that it would be removed in 1.20 and we are in 1.20.

RobLa-WMF's comment:

We deprecated this less than a year ago (in r88588).  This commit is doing 
nothing other than breaking things that might otherwise actually work, and 
there's no followup work with tangible end-user benefit that depends on this 
being gone.  Most of the major Linux distros are still shipping a version of 
MediaWiki prior to this even being deprecated.

When will we ever remove this?  When we need to.  Certainly not before someone 
gets around to writing the documentation that [[User:Tbleher|Tbleher]] 
requested.

It would be just fine to throw deprecation errors upon use of this global, 
assuming there's a reasonable way to do that.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added

[MediaWiki Mail]

"Preilly" posted a comment on MediaWiki.r110772.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30797

Commit summary for MediaWiki.r110772:

MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well)

Preilly's comment:

This extension has been renamed to MobileSkin in order to avoid any confusion 
with MobileFrontend.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r110889]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r110889 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110889

Old status:  new
> New status: ok

Commit summary for MediaWiki.r110889:

Avoid extra DOM parse when we already have a document. Includes r110876

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111171]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r71 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71

Old status:  new
> New status: ok

Commit summary for MediaWiki.r71:

Started extracting wikitext-manipulating code into a separate, isolated class

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111177]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r77 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77

Old status:  new
> New status: ok

Commit summary for MediaWiki.r77:

Fixed wrong format passed to manipulator, removed unused variable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111205]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r111205 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111205

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111205:

Sketch of action=parse extended by MobileFrontend, doesn't work yet

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111227]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r111227 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111227

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111227:

Follow-up r111205: forgot to add a file, fixed a fatal in non-API execution path

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111228]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r111228 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111228

Old status:  new
> New status: ok

Commit summary for MediaWiki.r111228:

* Made mobile format non-compulsory
* Full param info

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added

[MediaWiki Mail]

"MZMcBride" posted a comment on MediaWiki.r110772.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30798

Commit summary for MediaWiki.r110772:

MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well)

MZMcBride's comment:

[[Extension:MobileSkin]] has existed since December 2008 and refers to a 
completely different extension currently.

So much for avoiding confusion?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r110772]: New comment added

[MediaWiki Mail]

"Preilly" posted a comment on MediaWiki.r110772.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110772#c30799

Commit summary for MediaWiki.r110772:

MobileFrontend2, rewrite of MobileFrontend (really version 3 but oh well)

Preilly's comment:

I looked in the subversion repository and didn't see anything named MobileSkin. 
What name do you suggest?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview