[Wikitech-l] Minding pull-requests on GitHub

2014-04-18 Thread Ori Livneh
I just stumbled across https://github.com/wikimedia/mediawiki-core/pull/19,
a small but useful contribution to core from an HHVM developer. It has gone
unnoticed for two months, which is a bit sad.

Is there a way to accept pull-requests from GitHub? According to 
https://github.com/wikimedia/mediawiki-core/settings/hooks (may not be
visible to non-Wikimedians, sorry), the WebHook receiver 
http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py is defunct.
Anyone know the story there?

It'd be good if some additional people were watching (that is, receiving
notifications for) https://github.com/wikimedia/mediawiki-core/.

I haven't responded yet, by the way, so feel free to if you know the
answers to these questions. I don't know what effect accepting the
pull-request will have on the code in master, and telling someone who has
already submitted a patch to go sign up for Gerrit seems impolite.

Ori
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Minding pull-requests on GitHub

2014-04-18 Thread Bartosz Dziewoński

It is possible to copy the pull request to Gerrit easily: paste the contents of 
https://github.com/wikimedia/mediawiki-core/pull/19.patch into 
https://tools.wmflabs.org/gerrit-patch-uploader/ and bonk the button. This is 
of course a one-time, one-way synchronisation.

YuviPanda used to have a bot that provided two-way synchronisation between 
Gerrit changesets and GitHub pull requests, but I haven't seen it used recently 
and I don't know where to find the source code or anything.

--
Matma Rex

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Minding pull-requests on GitHub

2014-04-18 Thread Bartosz Dziewoński

On Fri, 18 Apr 2014 10:21:43 +0200, Ori Livneh o...@wikimedia.org wrote:


Is there a way to accept pull-requests from GitHub? According to 
https://github.com/wikimedia/mediawiki-core/settings/hooks (may not be
visible to non-Wikimedians, sorry), the WebHook receiver 
http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py is defunct.
Anyone know the story there?


Oh, I think that's actually backend for Yuvi's bot (it was called SuchABot).

--
Matma Rex

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread Federico Leva (Nemo)
This was asked just few days ago on this list... 
https://www.mediawiki.org/wiki/Manual:Pywikibot/touch.py is regularly 
used to make millions null edits, don't bother inventing something else.


Nemo

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Minding pull-requests on GitHub

2014-04-18 Thread Grunny
In this case, the developer was replied to by Krenair in a second PR
they opened for the same issue, so at least they weren't ignored, just
looks like the first PR wasn't closed along with the second one:
https://github.com/wikimedia/mediawiki-core/pull/20

The code for Yuvi's SuchABot is here:
https://git.wikimedia.org/tree/labs%2Ftools%2FSuchABot.git

Cheers,
grunny

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Minding pull-requests on GitHub

2014-04-18 Thread addshorewiki
As for notifications just turn the IRC hook on an point it at wikimedia-dev
for the repos?

WMDE do a similar thing for all of their github repos, see the following
script which makes it a lot easier!
https://github.com/wmde/github-hook-updater

Addshore


On 18 April 2014 10:31, Grunny mwgru...@gmail.com wrote:

 In this case, the developer was replied to by Krenair in a second PR
 they opened for the same issue, so at least they weren't ignored, just
 looks like the first PR wasn't closed along with the second one:
 https://github.com/wikimedia/mediawiki-core/pull/20

 The code for Yuvi's SuchABot is here:
 https://git.wikimedia.org/tree/labs%2Ftools%2FSuchABot.git

 Cheers,
 grunny

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
Addshore
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Config class and 1.23

2014-04-18 Thread Kevin Israel
Should the Config and GlobalConfig classes and the associated
RequestContext methods be reverted from 1.23 as an incomplete feature?
As far as I can tell, it is not yet used anywhere, so reverting it
should be easy.

getConfig() was added to IContextSource in 101a2a160b05[1]. Then
the method was changed to return a new class of object (Config) instead
of a SiteConfiguration object in fbfe789b987b[2]; however, the Config
class faces significant changes in I5a5857fc[3].

[1]: https://gerrit.wikimedia.org/r/#/c/92004/
[2]: https://gerrit.wikimedia.org/r/#/c/109266/
[3]: https://gerrit.wikimedia.org/r/#/c/109850/

-- 
Kevin Israel - MediaWiki developer, Wikipedia editor
http://en.wikipedia.org/wiki/User:PleaseStand

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Subscribe to Tech News via a web feed

2014-04-18 Thread Tomasz W . Kozłowski
Hi!
Just dropping a short note that it is now finally possible to
subscribe to the weekly Tech News bulletin[1] via a web feed to ensure
a smooth, hassle-free delivery of every issue to a news aggregator of
your choice.

You can subscribe to an Atom[2] or RSS[3] feed, which should deliver a
new issue at 00:00 UTC every Monday.

At this point, the feed only provides the English version of the
bulletin, so you'll need to click one of the links on top of the page
to read a version in a different language — if you think that a
per-language feed is a good idea, please let us know!

The feed is now also subscribed to the English Planet Wikimedia[4], so
if you get your Wikimedia news that way, you'll also see a new issue
of Tech News on the Planet every Monday.

Feedback and questions are welcome :-)

== References ==
* [1] https://meta.wikimedia.org/wiki/Tech/News
* [2] 
https://meta.wikimedia.org/w/api.php?action=featuredfeedfeed=technewsfeedformat=atomis
* [3] 
https://meta.wikimedia.org/w/api.php?action=featuredfeedfeed=technewsfeedformat=rss
* [4] https://en.planet.wikimedia.org/

Tomasz

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [Wikitech-ambassadors] Subscribe to Tech News via a web feed

2014-04-18 Thread Guillaume Paumier
Hi,

On Fri, Apr 18, 2014 at 4:17 PM, Tomasz W. Kozłowski
twkozlow...@gmail.com wrote:

 Just dropping a short note that it is now finally possible to
 subscribe to the weekly Tech News bulletin[1] via a web feed to ensure
 a smooth, hassle-free delivery of every issue to a news aggregator of
 your choice.

\o/ This is fantastic. Thank you so much, again :)

 You can subscribe to an Atom[2] or RSS[3] feed, which should deliver a
 new issue at 00:00 UTC every Monday.

Small correction: the link for the Atom feed is
https://meta.wikimedia.org/w/api.php?action=featuredfeedfeed=technewsfeedformat=atom

-- 
Guillaume Paumier

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Aaron Schulz
I'd suggest a revert from the branch, yes.



--
View this message in context: 
http://wikimedia.7.x6.nabble.com/Config-class-and-1-23-tp5026223p5026236.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread Daniel Barrett
Federico Leva (Nemo) writes:
https://www.mediawiki.org/wiki/Manual:Pywikibot/touch.py is regularly used to 
make millions null edits, don't bother inventing something else.

Awesome! This worked perfectly. Thank you so much!!
DanB

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Tyler Romeo
I agree. I was going to attempt to fix the newest patch, but until the
semester ends I won't have a lot of time (and it seems neither does the
current patch owner).

*-- *
*Tyler Romeo*
Stevens Institute of Technology, Class of 2016
Major in Computer Science


On Fri, Apr 18, 2014 at 12:16 PM, Aaron Schulz aschulz4...@gmail.comwrote:

 I'd suggest a revert from the branch, yes.



 --
 View this message in context:
 http://wikimedia.7.x6.nabble.com/Config-class-and-1-23-tp5026223p5026236.html
 Sent from the Wikipedia Developers mailing list archive at Nabble.com.

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Subscribe to Tech News via a web feed

2014-04-18 Thread Antoine Musso
Le 18/04/2014 16:17, Tomasz W. Kozłowski a écrit :
 Just dropping a short note that it is now finally possible to
 subscribe to the weekly Tech News bulletin[1] via a web feed to ensure
 a smooth, hassle-free delivery of every issue to a news aggregator of
 your choice.
snip
 * [3]
https://meta.wikimedia.org/w/api.php?action=featuredfeedfeed=technewsfeedformat=rss

Thank you very much!

-- 
Antoine hashar Musso


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Jeroen De Dauw
Hey,

Is there some kind of description of the responsibility of the context
source stuff anywhere? And the design vision behind it? I find the whole
thing extremely dubious, as it appears to try make you bind to a whole
group of rather scary classes. Perhaps I am missing something?

Cheers

--
Jeroen De Dauw - http://www.bn2vs.com
Software craftsmanship advocate
Evil software architect at Wikimedia Germany
~=[,,_,,]:3
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Subscribe to Tech News via a web feed

2014-04-18 Thread Thomas Gries

Am 18.04.2014 23:20, schrieb Antoine Musso:

Le 18/04/2014 16:17, Tomasz W. Kozłowski a écrit :

Just dropping a short note that it is now finally possible to
subscribe to the weekly Tech News bulletin[1] via a web feed to ensure
a smooth, hassle-free delivery of every issue to a news aggregator of
your choice.

snip

* [3]

https://meta.wikimedia.org/w/api.php?action=featuredfeedfeed=technewsfeedformat=rss

Thank you very much!


You should /change the order/ of the feed items to most recent on top
At the moment, the items are sorted old =new

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Legoktm

On 04/18/2014 04:40 AM, Kevin Israel wrote:

Should the Config and GlobalConfig classes and the associated
RequestContext methods be reverted from 1.23 as an incomplete feature?
As far as I can tell, it is not yet used anywhere, so reverting it
should be easy.


The implementation in core right now is incomplete. Once [3] is merged 
though, it should be suitable for people to start using it, and I know 
Reedy had a patch that converted all of the API modules in core to use it.


I would like to have Config make it into 1.23, mainly since it's an LTS, 
which would allow more extensions to take advantage of it without 
breaking backwards-compatability.


I was actually working on [3] last night and just updated the patchset, 
which should address the concerns the reviewers had. But if we're not 
able to get it merged in time for the 1.23 release, then I would 
recommend reverting the current implementation out of the release branch.



[3]: https://gerrit.wikimedia.org/r/#/c/109850/


-- Legoktm

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Retrospective on Typography Refresh

2014-04-18 Thread Steven Walling
Hi all,

Typography Refresh was one of the first batch of Beta Features launched
last November. It's also now the first Beta Feature that was removed and
then deployed in core. You'll probably have noticed the many threads about
it on Wikitech in the past. ;-)

While this might not have been a particularly large technical change (it's
mostly just some tweaks to the Vector Less styles in core) we wanted to
publicly share notes from the team about it. The purpose of a retrospective
is to focus on concrete actions we can take to ensure good process.
Hopefully we have learned some lessons that could help other beta features
testing/release go smoothly.

Notes are up at
https://www.mediawiki.org/wiki/Typography_refresh/Retrospective if you're
interested. Since these reflect the feelings of the team working on it, I'd
like to ask that you first add questions and comments on the Talk page,
rather than directly to the document.

Thanks!

-- 
Steven Walling,
Product Manager
https://wikimediafoundation.org/
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Tyler Romeo
On Fri, Apr 18, 2014 at 7:17 PM, Legoktm legoktm.wikipe...@gmail.comwrote:

 I would like to have Config make it into 1.23, mainly since it's an LTS,
 which would allow more extensions to take advantage of it without breaking
 backwards-compatability.


I don't mind getting the Config class into 1.23. However, at this moment,
Legoktm's patch is not merged, and while it'd be nice to get it merged
before the release, as we all know the MediaWiki review process is not
always as fast as we'd like it to be.

I'd recommend reverting the merged Config patch, and then backporting
Legoktm's patch when it's finished and merged.

*-- *
*Tyler Romeo*
Stevens Institute of Technology, Class of 2016
Major in Computer Science
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Roadmap and deployment highlights - week of April 21st

2014-04-18 Thread Greg Grossmeier
Hello and welcome to the latest edition of the WMF Engineering Roadmap
and Deployment update.

The full log of planned deployments next week can be found at:
https://wikitech.wikimedia.org/wiki/Deployments#Week_of_April_21st

A quick list of notable items...


== Tuesday ==

* MediaWiki deploy
** group1 to 1.24wmf1: All non-Wikipedia sites (Wiktionary, Wikisource,
   Wikinews, Wikibooks, Wikiquote, Wikiversity, and a few other sites)
** https://www.mediawiki.org/wiki/MediaWiki_1.24/wmf1


* Flow:
** Archive and enable Flow on the Nearby Pages Beta Feature talk page
** https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages
** https://www.mediawiki.org/wiki/Flow


== Thursday ==

* MediaWiki deploy
** group2 to 1.24wmf1 (all Wikipedias)
** group0 to 1.24wmf2 (test/test2/testwikidata/mediawiki)

* Media Viewer:
** Third limited pilot release: Enable by default on a few small
   pilot sites (batch 2: Czech, Estonian, Finnish, Hebrew, Polish,
   Romanian, Slovak, Thai, Vietnamese)
** 
https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Timeline


As always, questions and comments welcome,

Greg

-- 
| Greg GrossmeierGPG: B2FA 27B1 F7EB D327 6B8E |
| identi.ca: @gregA18D 1138 8E47 FAC8 1C7D |


signature.asc
Description: Digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Config class and 1.23

2014-04-18 Thread Chad
On Fri, Apr 18, 2014 at 5:35 PM, Tyler Romeo tylerro...@gmail.com wrote:

 I'd recommend reverting the merged Config patch, and then backporting
 Legoktm's patch when it's finished and merged.


That'd be messy in the history. Let's just wait a few days or
so and see what comes of the patch. There's no rush...the
revert will literally take seconds if we do need to back it out
of REL1_23.

-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread Liangent
On Fri, Apr 18, 2014 at 5:22 PM, Federico Leva (Nemo) nemow...@gmail.comwrote:

 This was asked just few days ago on this list...
 https://www.mediawiki.org/wiki/Manual:Pywikibot/touch.py is regularly
 used to make millions null edits, don't bother inventing something else.


It seems touch.py should be updated to make use of forcelinkupdate,
forcerecursivelinkupdate and generator parameters of api.php?action=purge,
to reduce traffic.

https://www.mediawiki.org/wiki/API:Purge

-Liangent



 Nemo


 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread MZMcBride
Liangent wrote:
It seems touch.py should be updated to make use of forcelinkupdate,
forcerecursivelinkupdate and generator parameters of api.php?action=purge,
to reduce traffic.

https://www.mediawiki.org/wiki/API:Purge

As far as I can tell, touch.py should not be necessary. Purging (including
links updates) should just work in MediaWiki. Individual users shouldn't
feel compelled to manually null edit or aggressively purge pages. I'd
personally rather see time and energy invested into making the need for
null edits obsolete instead of making touch.py more robust.

MZMcBride



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread Liangent
There're still cases / some bugs where *links tables can't be updated
automatically. touch.py and similar techniques work as a workaround.


On Sat, Apr 19, 2014 at 9:12 AM, MZMcBride z...@mzmcbride.com wrote:

 Liangent wrote:
 It seems touch.py should be updated to make use of forcelinkupdate,
 forcerecursivelinkupdate and generator parameters of api.php?action=purge,
 to reduce traffic.
 
 https://www.mediawiki.org/wiki/API:Purge

 As far as I can tell, touch.py should not be necessary. Purging (including
 links updates) should just work in MediaWiki. Individual users shouldn't
 feel compelled to manually null edit or aggressively purge pages. I'd
 personally rather see time and energy invested into making the need for
 null edits obsolete instead of making touch.py more robust.

 MZMcBride



 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Programmatically making an empty edit?

2014-04-18 Thread MZMcBride
Liangent wrote:
There're still cases / some bugs where *links tables can't be updated
automatically. touch.py and similar techniques work as a workaround.

Workaround or... hack. :-)  I agree that touch.py is useful right now. I
wish it were not necessary, though. If anyone's interested in killing the
purge action in MediaWiki: https://bugzilla.wikimedia.org/54902.

MZMcBride



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Auth_remoteuser -- please review

2014-04-18 Thread Mark A. Hershberger
For a current project, I have found that Auth_remoteuser can take care 
of a lot of the grunt work, but I felt the need to update it a little.


I have the feeling (wrong?) that this extension is one that is used in a 
lot of places but it hasn't been touched for a couple of years.


Could I get people to test out the modifications I want to contribute back?

   https://gerrit.wikimedia.org/r/127405 -- mostly just formatting
   https://gerrit.wikimedia.org/r/127406 -- refactoring
   https://gerrit.wikimedia.org/r/127407 -- changing invocation

I've made some effort to keep this compatible with the previous version. 
 If you want to try this out as a drop-in replacement for your current 
Auth_remoteuser, you can use 
http://mah.everybody.org/Auth_remoteuser.php.txt -- but please report 
back any problems you have.


Thanks,

Mark.

--
Mark A. Hershberger
NicheWork LLC
717-271-1084

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Auth_remoteuser -- please review

2014-04-18 Thread Chad
On Fri, Apr 18, 2014 at 7:47 PM, Mark A. Hershberger m...@nichework.comwrote:

 For a current project, I have found that Auth_remoteuser can take care of
 a lot of the grunt work, but I felt the need to update it a little.

 I have the feeling (wrong?) that this extension is one that is used in a
 lot of places but it hasn't been touched for a couple of years.

 Could I get people to test out the modifications I want to contribute back?

https://gerrit.wikimedia.org/r/127405 -- mostly just formatting
https://gerrit.wikimedia.org/r/127406 -- refactoring
https://gerrit.wikimedia.org/r/127407 -- changing invocation

 I've made some effort to keep this compatible with the previous version.
  If you want to try this out as a drop-in replacement for your current
 Auth_remoteuser, you can use http://mah.everybody.org/Auth_
 remoteuser.php.txt -- but please report back any problems you have.


Left you some comments on all 3. Have a good weekend.

-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l