Re: [Wikitech-l] FlaggedRevs gone from mediawiki.org
Le 23/05/2014 01:17, Chad a écrit : I've just undone the mistake I made almost 5 years ago getting FlaggedRevs turned on for mw.org with no consensus[0]. The average review time was 58 days. There were over 50 pages pending review (I didn't bother paging) The vast majority of edits are harmless/productive and don't need review. You probably noticed me removing you from the editor and/or reviewer groups since they're unused now. Since FlaggedRevs is gone you shouldn't notice any net permission changes. Will you reenable it in five year because the removal happened without consensus either ? :-D Thanks for the clean up Chad! Much appreciated. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] What should be the recommended / supported way to do skins? (A proposal.)
On Sat, 24 May 2014 21:12:26 +0200, Bartosz Dziewoński matma@gmail.com wrote: First of all, something we all agree on: let's murder skin autodiscovery. I'll submit patches to emit deprecation warnings if a skin using it is found (to master and 1.23 LTS release), and another patch that will remove it entirely (intended for MW 1.24 or MW 1.25). I will also convert the core skins not to use autodiscovery first. I'll keep them in 'skins/' for now, it'll be less disruptive in WMF environment and easy to change later if we decide to. I filed a bug to track this: https://bugzilla.wikimedia.org/show_bug.cgi?id=65748 And submitted patches that seem to do a complete job: https://gerrit.wikimedia.org/r/#/c/135383/ (master) Don't use autodiscovery for core skins https://gerrit.wikimedia.org/r/#/c/135384/ (master) Move core skins to separate directories https://gerrit.wikimedia.org/r/#/c/135429/ (master) Officially deprecate skin autodiscovery https://gerrit.wikimedia.org/r/#/c/135427/ (REL1_23) Officially deprecate skin autodiscovery https://gerrit.wikimedia.org/r/#/c/135439/ (master, on hold) Completely remove skin autodiscovery Reviews welcome. Especially the REL1_23 is a bit urgent, as the release is around the corner. I will create a brief migration guide for creators and users of custom skins later this week (or next week), probably at https://www.mediawiki.org/wiki/Manual:Skin_autodiscovery. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] What should be the recommended / supported way to do skins? (A proposal.)
On 24 May 2014 14:12, Bartosz Dziewoński matma@gmail.com wrote: Are there any fundamental, insurmountable issues with having skins in 'skins/' in WMF production? I am not a developer and therefore I cannot speak for them, but from a product perspective I have no insurmountable issues with either the /skins/ or the /extensions/ solution. It seems that there's pros and cons for each solution, so as long as it's handled appropriately (and it certainly seems to me like you're doing that), then you've got my support. So, I'm proposing an experiment: We can evaluate this almost painlessly by converting the current Nostalgia extension-skin to a skin in my proposed format, deploying it on nostalgia.wikimedia.org (after doing whatever changes are necessary to deployment things first) and seeing what happens. This should not affect the rest of the cluster, and even catastrophic failures would have a very tiny surface area. If it turns out that this is really not going to work, we can always revert all changes and stick with stuffing skins in 'extensions/' instead. Tim, Brion, Dan: How does this look to you? Well, you've got my endorsement! How can I help you make this happen? Thanks, Dan -- Dan Garry Associate Product Manager for Platform and Mobile Apps Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
