[Wikitech-l] Signature change without deprecation: ContentHandler::getUndoContent

[Gergo Tisza]

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447099 changes the
signature of ContentHandler::getUndoContent from  to 
(with Revision soft-deprecated). This is a breaking change as
ContentHandler is meant to be subclassed, and any subclass that typehints
Revision will raise a warning at compile-time, and a fatal when called with
Content.

Searching Gerrit, Github and Google only yielded a single instance of a
subclass overriding the method (which is being fixed) and providing
backwards compatibility in a robust way does not seem feasible, so we are
changing the method signature without a deprecation period (in the sense of
subclass compatibility; with respect to calling the method with Revision,
we follow the normal deprecation process).

For more information on the MediaWiki deprecation policy see
https://www.mediawiki.org/wiki/Deprecation_policy#Removal_without_deprecation
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] This Week's Log Health

[Tyler Cipriani]

Hi all!

The state of the Wikimedia error logs makes determining the health of a 
deployment difficult. This week there were a number of log messages that 
made determining the health of this week's train difficult.


This email is a request for help for a couple of troubling messages 
currently showing up on our error logs; please help to investigate these 
log messages if you are able:


* Exception thrown for failure to save settings appears ~ 1000 
times/day[0]

* "Falling back to DifferenceEngineSlotDiffRenderer" Logspam[1]

Thank you for your help!

<3
-- Tyler

[0] 
[1] 

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Improvements to the wikitext diff view

[Michael Schönitzer]

Thanks a lot for all the friendly feedback!

@Pine: Today I have a travel day, but I'll make some more screenshots on
Monday and ping you then.

Cheers,
 M

2018-08-24 2:43 GMT+02:00 Dennis During :

> This will make so many monitoring tasks much easier and lead to their being
> done better and more frequently.  It is hard to conceive of any drawback to
> it.  Even there turn out to be some bugs, this is a great improvement.
> Thanks.
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



-- 
Michael F. Schönitzer



Wikimedia Deutschland e.V. | Tempelhofer Ufer 23-24 | 10963 Berlin
Tel. (030) 219 158 26-0
http://wikimedia.de

Stellen Sie sich eine Welt vor, in der jeder Mensch an der Menge allen
Wissens frei teilhaben kann. Helfen Sie uns dabei!
http://spenden.wikimedia.de/

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/681/51985.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l