[Wikitech-l] Wednesday: Technical Advice IRC Meeting

2019-05-28 Thread Michael Schönitzer
Reminder: Technical Advice IRC meeting this week **Wednesday 3-4 pm UTC**
on #wikimedia-tech.

The Technical Advice IRC Meeting is a weekly support event for volunteer
developers. Every Wednesday, two full-time developers are available to help
you with all your questions about Mediawiki, gadgets, tools and more! This
can be anything from "how to get started" over "who would be the best
contact for X" to specific questions on your project.

If you know already what you would like to discuss or ask, please add your
topic to the next meeting:
https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting

Hope to see you there!

Michi (for the Technical Advice IRC Meeting crew)

-- 
Michael F. Schönitzer


Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin
Tel. (030) 219 158 26-0
https://wikimedia.de

Unsere Vision ist eine Welt, in der alle Menschen am Wissens der Menschheit
teilhaben, es nutzen und mehren können. Helfen Sie uns dabei!
https://spenden.wikimedia.de

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] "Patch-For-Review" tag in phabricator

2019-05-28 Thread Stephen Niedzielski
In lieu of a user mute feature[0], you can identify messages from the bot
in Gmail like:

  from:(Maintenance_bot no-re...@phabricator.wikimedia.org)
actor(@Maintenance_bot)

You have to enable the "send stamps" option under Phabricator settings ->
email format.

[0] https://phabricator.wikimedia.org/T164542

On Thu, May 23, 2019 at 4:48 AM Manuel Arostegui 
wrote:

> On Wed, May 22, 2019 at 12:12 PM Mukunda Modell 
> wrote:
>
> > If you do the edits as a bulk edit job I can flag it to run silently
> which
> > will spare people the email spam.
> >
>
> I would love to have this done :-)
> I already have lots of phab traffic, so keeping this one to a minimum would
> be nice!
>
> Thanks!
> Manuel.
>
>
> >
> > On Tue, May 21, 2019 at 4:53 PM Amir Sarabadani 
> > wrote:
> >
> > > Hey,
> > > It's already stopped and running them on open tasks only for now sounds
> > > like a good idea.
> > >
> > > Let me do that.
> > >
> > > On Tue, May 21, 2019 at 11:51 PM Antoine Musso 
> > wrote:
> > >
> > > > On 21/05/2019 23:40, Amir Sarabadani wrote:
> > > > > Hey,
> > > > > You probably know about the tag, it has been added automatically to
> > > > > phabricator tickets when someone makes a patch to gerrit and
> mentions
> > > the
> > > > > pabricator ticket (For example [0]). The problem is when the patch
> > gets
> > > > > merged the tag doesn't get removed automatically because there
> might
> > be
> > > > > other outstanding patches, etc.
> > > > >
> > > > > Now, lots of time of our developers is being spent on removing
> those
> > > tags
> > > > > when they don't apply which is tedious and with lots of tasks
> > > incorrectly
> > > > > having the tag, the tag itself is useless. So I wrote a bot to
> clean
> > > > those
> > > > > tags.
> > > > >
> > > > > In order to make sure I don't remove anything by mistake, the bot
> > > doesn't
> > > > > touch the ticket if any of these conditions apply:
> > > > > * If the tag is added by someone else than the gerrit bot
> > > > > * If there's a link to github.com anywhere
> > > > > * If there are still patches that are not merged (ta-duh)
> > > > > * If gerritbot in any way acts out of ordinary (for example,
> comments
> > > > twice
> > > > > for adding one patch)
> > > > >
> > > > > It's going to spam your inbox. Sorry:(  I'm working on it to find a
> > > less
> > > > > spammy way and will definitely run it with slow pace.
> > > > >
> > > > > [0]:https://phabricator.wikimedia.org/T155878#5190647
> > > >
> > > > Hello,
> > > >
> > > > I appreciate your initiative to cleanup Phabricator but in this case
> I
> > > > do not see a point of removing #patch-for-review on tasks that are
> > > > marked as resolved and are months, if not years old.
> > > >
> > > > Can you please stop this bot because it is flooding my email inbox.
> Or
> > > > at least exclude tasks marked as resolved!
> > > >
> > > > Thank you!
> > > >
> > > > --
> > > > Antoine "hashar" Musso
> > > >
> > > >
> > >
> > > --
> > > Amir (he/him)
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] "Patch-For-Review" tag in phabricator

2019-05-28 Thread Amir Sarabadani
Some updates:

* Using a batch job I removed around 140 tags from open tasks (An example:
https://phabricator.wikimedia.org/T222963#5216986) You should not get any
notification for those. This is basically the first and only big cleanup

* The bot is active and removes the tag on tasks that are open and have
been updated in the last hour, every hour. You will get notification for
those. It's similar to release tagger bot and I recommand filtering them on
your mail client if you get too many of them (as Stephen pointed out). This
is rather low-volume action to avoid piling those up in the future.

* I'm not touching closed tasks as it's lots of tickets and won't gain us
much benefit, if you want me to do it for any reason you want. Let me know.

* Now, the tag is only used on tickets that actually have a patch attached
to them (open tickets, closed ones is a mess), making us be able to use the
tag efficiently. For example, this is the tickets about wikidata that have
outstanding patch:
https://phabricator.wikimedia.org/project/board/71/query/3IFPR_mx6Nll/


Best

On Tue, May 28, 2019 at 5:14 PM Stephen Niedzielski <
sniedziel...@wikimedia.org> wrote:

> In lieu of a user mute feature[0], you can identify messages from the bot
> in Gmail like:
>
>   from:(Maintenance_bot no-re...@phabricator.wikimedia.org)
> actor(@Maintenance_bot)
>
> You have to enable the "send stamps" option under Phabricator settings ->
> email format.
>
> [0] https://phabricator.wikimedia.org/T164542
>
> On Thu, May 23, 2019 at 4:48 AM Manuel Arostegui  >
> wrote:
>
> > On Wed, May 22, 2019 at 12:12 PM Mukunda Modell 
> > wrote:
> >
> > > If you do the edits as a bulk edit job I can flag it to run silently
> > which
> > > will spare people the email spam.
> > >
> >
> > I would love to have this done :-)
> > I already have lots of phab traffic, so keeping this one to a minimum
> would
> > be nice!
> >
> > Thanks!
> > Manuel.
> >
> >
> > >
> > > On Tue, May 21, 2019 at 4:53 PM Amir Sarabadani 
> > > wrote:
> > >
> > > > Hey,
> > > > It's already stopped and running them on open tasks only for now
> sounds
> > > > like a good idea.
> > > >
> > > > Let me do that.
> > > >
> > > > On Tue, May 21, 2019 at 11:51 PM Antoine Musso 
> > > wrote:
> > > >
> > > > > On 21/05/2019 23:40, Amir Sarabadani wrote:
> > > > > > Hey,
> > > > > > You probably know about the tag, it has been added automatically
> to
> > > > > > phabricator tickets when someone makes a patch to gerrit and
> > mentions
> > > > the
> > > > > > pabricator ticket (For example [0]). The problem is when the
> patch
> > > gets
> > > > > > merged the tag doesn't get removed automatically because there
> > might
> > > be
> > > > > > other outstanding patches, etc.
> > > > > >
> > > > > > Now, lots of time of our developers is being spent on removing
> > those
> > > > tags
> > > > > > when they don't apply which is tedious and with lots of tasks
> > > > incorrectly
> > > > > > having the tag, the tag itself is useless. So I wrote a bot to
> > clean
> > > > > those
> > > > > > tags.
> > > > > >
> > > > > > In order to make sure I don't remove anything by mistake, the bot
> > > > doesn't
> > > > > > touch the ticket if any of these conditions apply:
> > > > > > * If the tag is added by someone else than the gerrit bot
> > > > > > * If there's a link to github.com anywhere
> > > > > > * If there are still patches that are not merged (ta-duh)
> > > > > > * If gerritbot in any way acts out of ordinary (for example,
> > comments
> > > > > twice
> > > > > > for adding one patch)
> > > > > >
> > > > > > It's going to spam your inbox. Sorry:(  I'm working on it to
> find a
> > > > less
> > > > > > spammy way and will definitely run it with slow pace.
> > > > > >
> > > > > > [0]:https://phabricator.wikimedia.org/T155878#5190647
> > > > >
> > > > > Hello,
> > > > >
> > > > > I appreciate your initiative to cleanup Phabricator but in this
> case
> > I
> > > > > do not see a point of removing #patch-for-review on tasks that are
> > > > > marked as resolved and are months, if not years old.
> > > > >
> > > > > Can you please stop this bot because it is flooding my email inbox.
> > Or
> > > > > at least exclude tasks marked as resolved!
> > > > >
> > > > > Thank you!
> > > > >
> > > > > --
> > > > > Antoine "hashar" Musso
> > > > >
> > > > >
> > > >
> > > > --
> > > > Amir (he/him)
> > > > ___
> > > > Wikitech-l mailing list
> > > > Wikitech-l@lists.wikimedia.org
> > > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > > ___
> > > Wikitech-l mailing list
> > > Wikitech-l@lists.wikimedia.org
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> ___
> Wikitech-l mailing list
> Wik