Re: [Wikitech-l] Content handler feature merge (Wikidata branch) scheduled early next week
Hello, I would consider https://bugzilla.wikimedia.org/show_bug.cgi?id=40653 (filed by Daniel Kinzler after one of my comments) as a blocker for this merge. Also Nikerabbit's comments in https://gerrit.wikimedia.org/r/#/c/25736/1/includes/Content.php lines 222 and following would be great to fix before the merge. Cheers! Alexandre Emsenhuber (ialex) Le 3 oct. 2012 à 03:07, Rob Lanphier a écrit : Hi everyone, We now at around the time that we planned to merge the ContentHandler branch in. Questions: * Daniel/others: have you submitted a merge commit for this? If not, do you need help/clarification, or do you have it? * People who reviewed Denny's faux commit[1] and left comments. Any blockers, or mainly stylistic stuff? Everyone else, now is the last call before the merge. Rob [1] Faux commit of ContentHandler branch: https://gerrit.wikimedia.org/r/#/c/25736/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Content handler feature merge (Wikidata branch) scheduled early next week
Hello, Would it be possible to have the whole changes as an changeset on Gerrit? This would make review and comments much easier than having to do this on this list. Cheers! Alexandre Emsenhuber (ialex) Le 25 sept. 2012 à 19:16, Rob Lanphier a écrit : Hi everyone, Assuming no one finds any substantive issues, we plan on merging the ContentHandler feature (Wikidata branch) early next week, in time for 1.20wmf14 (assuming we're still calling this the 1.20 series then). The tracking bug for that is here: https://bugzilla.wikimedia.org/show_bug.cgi?id=38622 The tree is here: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tree;h=refs/heads/Wikidata;hb=refs/heads/Wikidata ...and recent commits are here: https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/core+branch:Wikidata,n,z We'd like to get it in right after a deployment branch point so that it has some time to settle in master before we foist it on everyone. Please take a look at this branch, and raise any issues with the branch or this plan on list. Thanks! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Content handler feature merge (Wikidata branch) scheduled early next week
Hello, Having to dispatch comments over hunderds of commits is probably not the best idea, since I'm sure some of them will get lost. I would prefer having a central to do this instead. Cheers! Alexandre Emsenhuber (ialex) Le 25 sept. 2012 à 21:20, Jeremy Baron a écrit : On Tue, Sep 25, 2012 at 7:14 PM, IAlex ialex.w...@gmail.com wrote: Would it be possible to have the whole changes as an changeset on Gerrit? This would make review and comments much easier than having to do this on this list. is https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/core+branch:Wikidata,n,z sufficient? (copied from the first message on this thread) -Jeremy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Title objects as value objects; split with WikiPage/Article family?
Le 3 janv. 2012 à 22:50, Brion Vibber a écrit : I've reverted a number of recent commits to the Title class which added several more pre-cached fields to it, as I really don't think we want that sort of data in Title objects to begin with. A Title object is meant to represent a... well, a page title :) and as such should be roughly equivalent to passing the string-form title around, but without having to parse and de-parse the items all the time. Since ancient times we've had a couple things like an article ID being saved into local state, which is frequently useful to optimize lookups but has its own problems (it has to be explicitly cleared or reset from time to time). These really belong more in a 'Page' object than a 'Title' however. These days we've got a WikiPage class which has been further split from Article as well; it seems to me that these sorts of things might belong better there than in Title. Thoughts? -- brion I added those fields to the Title class to avoid some DB queries and avoid code duplication. The problem is that currently the WikiPage instance created in Wiki.php is not stored in the context object (you can grep for WikiPage::factory to see how many times that method is called). This means that every time another instance of that class is created there will be a new database query. I think we need to store the WikiPage object in RequestContext to be able to share that object and thus avoiding those database queries. Alexandre Emsenhuber (ialex) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 1.18 PHP version requirement
Le 10 nov. 2011 à 16:42, Antoine Musso a écrit : I am pretty sure Mac OS X 10.6 provide a PHP version after 5.2.6. Antoine hashar Musso Mac OS X 10.6.8 provides PHP 5.3.6. Cheers! Alexandre Emsenhuber (ialex) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Google's cached pages are much faster than wiki*edia's
Le 7 oct. 2011 à 06:21, Chad a écrit : On Thu, Oct 6, 2011 at 10:53 PM, Ryan Lane rlan...@gmail.com wrote: Isn't that the same thing Facebook just caught Congressional shit for? Not even close. We don't track you from site to site, you just happen to have a cookie that didn't get deleted that also happens to cause you to bypass cache. We should likely find out why these aren't getting deleted. Well we do serve the logged out cookie. What real purpose that serves, I don't know :) It's to bypass the browser cache, and to not let the user see a page with it's user name at the top when he just logged out. Alexandre Emsenhuber ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] removing 1.5 upgrader
Hi, Just a quick note: I already opened bug 25398 [1] to discuss about this. [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=25398 Cheers, Alexandre Emsenhuber (ialex) Le 31 oct. 2010 à 17:17, Ashar Voultoiz a écrit : Hello, We still have a the 1.4 - 1.5 upgrader in trunk. It was used to handle both the schema changes and the encoding changes that occurred in 1.5. According to code review on r72865 [1], it is broken since r22580 [2] from May 2007. Can we please remove it for 1.17 ? I am not sure we still have to support an upgrade from 1.4 which is like 5 years old and probably not used anywhere nowadays. [1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72865 [2] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/22580 -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
