[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added

2012-03-13 Thread MediaWiki Mail 
"Nikerabbit" posted a comment on MediaWiki.r113594.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32115

Commit summary for MediaWiki.r113594:

Add definitionFile to work with export.php's ppgettext.

Nikerabbit's comment:

Configuration documentation states:

;definitionFile:Use this to define the location of the definition file 
(with the English source messages) if it does not adhere to the sourcePattern. 
Path variables are supported.

https://www.mediawiki.org/wiki/Help:Extension:Translate/Group_configuration#FILES

FileBasedMessageGroups have method called getSourceFilePath() that could 
perhaps be suitable.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added

2012-03-13 Thread MediaWiki Mail 
"Siebrand" posted a comment on MediaWiki.r113594.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32114

Commit summary for MediaWiki.r113594:

Add definitionFile to work with export.php's ppgettext.

Siebrand's comment:

Command documentation actually states:

  --ppgettext   Group root path for checkout of product. "msgmerge" will post
process on the export result based on the current definitionFile
in that location


So this change shouldn't result in a fixme, as it is according to the current 
specification.

I'll make a follow-up commit adding a todo.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added, and revision status changed

2012-03-12 Thread MediaWiki Mail 
"Nikerabbit" changed the status of MediaWiki.r113594 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32080

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r113594:

Add definitionFile to work with export.php's ppgettext.

Nikerabbit's comment:

ppgettext should be fixed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview