[MediaWiki-CodeReview] [MediaWiki r113751]: New comment added

2012-03-13 Thread MediaWiki Mail 
"Preilly" posted a comment on MediaWiki.r113751.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113751#c32122

Commit summary for MediaWiki.r113751:

make memcache key valid for the day

Preilly's comment:

I've switched to gmdate in r113760.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113751]: New comment added

2012-03-13 Thread MediaWiki Mail 
"Brion VIBBER" posted a comment on MediaWiki.r113751.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113751#c32121

Commit summary for MediaWiki.r113751:

make memcache key valid for the day

Brion VIBBER's comment:

Avoid using local time for things like this; we might well be fiddling the 
local timezone around. Consider gmdate() if this is appropriate. Would it make 
more sense to just expire after a day instead of putting it in the key?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview