[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Raymond" changed the status of MediaWiki.r85302.

Old Status: new
New Status: fixme

User "Raymond" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15690

Comment:

I am unsure if this revision is the right culprit for this fatal:


Notice: Undefined property: SkinVector::$mTitle in 
D:\F_Programmierung\xampp\htdocs\wiki2\extensions\Cite\SpecialCite.php on line 
39
Fatal error: Call to a member function isContentPage() on a non-object in 
D:\F_Programmierung\xampp\htdocs\wiki2\extensions\Cite\SpecialCite.php on line 
39


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85302.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15691

Comment:

Heaven knows :D  Should be fixed in r85332 though.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Platonides" changed the status of MediaWiki.r85302.

Old Status: new
New Status: fixme

User "Platonides" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15702

Comment:

parserTests.php creates a new OutputPage.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85302.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15714

Comment:

Fixed in r85403

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-06 Thread MediaWiki Mail 
User "Platonides" changed the status of MediaWiki.r85302.

Old Status: new
New Status: fixme

User "Platonides" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15773

Comment:

Argument 1 passed to MediaWiki::__construct() must be an instance of 
RequestContext, none given, called in 
phase3/tests/phpunit/includes/MediaWikiTest.php on line 13 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-06 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85302.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85302.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15776

Comment:

I am rapidly losing faith in my IDE's search function... :S.  Fixed in 
r85584.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-08-17 Thread MediaWiki Mail 
User "Dantman" changed the status of MediaWiki.r85302.

Old Status: fixme
New Status: new

User "Dantman" also posted a comment on MediaWiki.r85302.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85302#c20999
Commit summary:

Instead of creating an OutputPage and then setting a context start initializing 
OutputPages 'with' a context and send depreciated calls to extensions directly 
creating OutputPage instances.
Now that we've taken care of the mess of mTitle inside OutputPage and Skin and 
made RequestContext track Skin instead of $wgUser we don't need the hack in 
SpecialPage anymore.

Comment:

Removed the deprecation notice for 1.18 in r94763.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview