[MediaWiki-CodeReview] [MediaWiki r85385]: New comment added

2011-04-04 Thread MediaWiki Mail 
User "Brion VIBBER" posted a comment on MediaWiki.r85385.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15710

Comment:

Oh poop, I still haven't retrained my muscle memory for our space style. ;) The 
empty() should be fine for arrays, but if it makes you feel better change it to 
check the count() or something. I'll re-add it to my internal blacklist :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85385]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r85385.

Old Status: new
New Status: fixme

User "Reedy" also posted a comment on MediaWiki.r85385.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15709

Comment:

empty? :P

Also, should have more spaces on your if statement ;)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview