[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added

2011-04-04 Thread MediaWiki Mail 
User "Dantman" posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15715

Comment:

You can also drop $wgUser->getSkin( $wgTitle ); // set skin title 
it's not needed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added

2011-05-23 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c17115
Commit summary:

Follow-up r85302: update OutputPage constructors in core.

Comment:

I think the intended semantic was (new RequestContext)->output, if 
that even parses, although it looks like I switched halfway to a temporary 
variable and didn't finish the job...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail 
User "Siebrand" changed the status of MediaWiki.r85403.

Old Status: new
New Status: fixme

User "Siebrand" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15719

Comment:

FIXME:

+var_dump('foo');

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-04-05 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85403.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15728

Comment:

Lol.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-04-05 Thread MediaWiki Mail 
User "Platonides" changed the status of MediaWiki.r85403.

Old Status: new
New Status: fixme

User "Platonides" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15746

Comment:

$ php tests/parserTests.php

PHP Fatal error:  Call to a member function getDefaultUserOptionOverrides() on 
a non-object in User.php:1071 User.php:1963 RequestContext.php:108 
RequestContext.php:194 parserTest.inc:684 parserTest.inc:427 parserTest.inc:374 
parserTest.inc:356 parserTests.php:90 includes/User.php on line 1071

Reason: You are removing the Language::factory( $lang );

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-04-06 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85403.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15759

Comment:

Fixed in r85553.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-05-23 Thread MediaWiki Mail 
User "Bawolff" changed the status of MediaWiki.r85403.

Old Status: new
New Status: fixme

User "Bawolff" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c17112
Commit summary:

Follow-up r85302: update OutputPage constructors in core.

Comment:

In ParserTests.inc/NewParserTests.inc - shouldn't that be 
$GLOBALS['wgOut'] = $context->output; not $GLOBALS['wgOut'] 
= ''new''' $context->output;? I think this causes:

Notice: Use of OutputPage::__construct is deprecated. [Called from 
ParserTest::setupGlobals in /var/www/w/phase3/tests/parser/parserTest.inc at 
line 687] in /var/www/w/phase3/includes/GlobalFunctions.php on line 3243

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-05-23 Thread MediaWiki Mail 
User "Happy-melon" changed the status of MediaWiki.r85403.

Old Status: fixme
New Status: new

User "Happy-melon" also posted a comment on MediaWiki.r85403.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c17120
Commit summary:

Follow-up r85302: update OutputPage constructors in core.

Comment:

Fixed in r88665.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview