[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added, and revision status changed

2011-04-15 Thread MediaWiki Mail 
User Freakolowsky changed the status of MediaWiki.r85786.

Old Status: fixme
New Status: new

User Freakolowsky also posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15987
Commit summary:

* fix as per brion's comment on r85669

Comment:

used quoted parameter in r86112

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added

2011-04-12 Thread MediaWiki Mail 
User Platonides posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15862

Comment:

What if $wgDBprefix contained some character that needs quoting?

I think tableName() should have a parameter to not quote the resulting variable 
(ie. it needs to be passed to addIdentifierQuotes before usage).


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added

2011-04-12 Thread MediaWiki Mail 
User MaxSem posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15863

Comment:

Why trim tableName?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added, and revision status changed

2011-04-12 Thread MediaWiki Mail 
User Platonides changed the status of MediaWiki.r85786.

Old Status: new
New Status: fixme

User Platonides also posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15881

Comment:

The parameter added to tableName() in r85888 should remove the quotes for you 
if needed. I think they ''should'' be there, though. Also test with the 
addIdentifierQuotes() change.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added

2011-04-12 Thread MediaWiki Mail 
User Freakolowsky posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15895

Comment:

The current state of MW oracle abstraction doesn't support quoted naming, 
because that makes object names case sensitive and not all of the code is 
currently written to work that way.
So currently $wgDBprefix (and all other parts of object names) *should not* 
contain characters that need quoting.

I'll add the parameter and use it in this case.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added

2011-04-12 Thread MediaWiki Mail 
User Platonides posted a comment on MediaWiki.r85786.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15896

Comment:

Seems that it's the other code what should be fixed. I uppercased $wgDBprefix 
for you in r85920.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview