[MediaWiki-CodeReview] [MediaWiki r85888]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r85888.
Old Status: new
New Status: fixme
User Brion VIBBER also posted a comment on MediaWiki.r85888.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85888#c18498
Commit summary:
Add parameter to tableName() to get the bare table name.
Comment:
Rather than a bare boolean parameter (what does $db-tableName('foo', true)
mean in context? I'm getting the table name for 'foo' with... some kind of
option that does. what?) please use symbolic class constants for the
values, eg: $db-tableName('foo', Database::QUOTED_NAME) vs
$db-tableName('foo', Database::RAW_NAME) or something.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85888]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r85888. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r85888. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85888#c15870 Comment: pre (2 lines skipped) [12-Apr-2011 17:13:49] PHP Strict Standards: Declaration of DatabaseSqlite::tableName() should be compatible with that of DatabaseBase::tableName() in /www/w/includes/AutoLoader.php on line 843 /pre The argument is not added to DatabaseSqlite::tableName(). Perhaps others as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
