[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-06-20 Thread MediaWiki Mail 
User "Aaron Schulz" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c18426
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

Article.php that is.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added, and revision status changed

2011-06-20 Thread MediaWiki Mail 
User "Aaron Schulz" changed the status of MediaWiki.r85929.

Old Status: new
New Status: ok

User "Aaron Schulz" also posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c18421
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

I hate this class...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-04-17 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c16071
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

Hm.. can/should we make it default to Main ?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-04-17 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c16070
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

Done in r86273.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-04-17 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c16069
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

Potentially more extensions:

"articleFromTitle" in /trunk/extensions/:

http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=173&hash=082b8bdeb037aee898c6e2ae77910bb0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-04-17 Thread MediaWiki Mail 
User "Tbleher" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c16068
Commit summary:

Implement a $context and getContext/setContext methods for Article (and its 
subclasses).

Comment:

Can you please update callers in extensions? DumpHTML was broken by this 
change, as it calls MediaWiki::articleFromTitle():
 Catchable fatal error: Argument 2 passed to MediaWiki::articleFromTitle() must 
be an instance of RequestContext, none given, called in 
/srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc on line 804 and defined in 
/srv/www/mediawiki/code/includes/Wiki.php on line 269


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added

2011-04-13 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c15905

Comment:

This is a result of having multiple separate things going on in my working copy 
at the same time and trying to break up commits.  The Action class exists in my 
working copy and so tests fine, but both sets of changes alter Wiki.php in 
different ways.  I missed the AutoLoader entry from r85928 for the same reason. 
 

This was already fixed in r85931.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85929]: New comment added, and revision status changed

2011-04-13 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r85929.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r85929.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c15904

Comment:

After up'ing to this revision my local wiki doesn't do anything anymore, just 
display this:

Fatal error: Class 'Action' not found in /trunk/phase3/includes/Wiki.php on 
line 474


Test before commit ;-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview