[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added, and revision status changed
User "TheDJ" changed the status of MediaWiki.r86088. Old Status: fixme New Status: resolved User "TheDJ" also posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c20737 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Marking as resolved, I know of no further issues with this rewrite. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "TheDJ" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19055 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: OK, as far as I can tell all known issues should now be fixed. Great work Diebuche !!! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19054 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: It's wrapping sortbottoms inside tfoot's as of r91207 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19045 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: * ''Should we also support the old syntax in order to prevent drama ?'' ** Yes we should. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "TheDJ" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19043 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: I do have to mention that sortbottom isn't actually that much used apparently. http://en.wikipedia.org/w/index.php?title=Special:Search&search=sortbottom&fulltext=Search&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns108=1&ns109=1&redirs=1 91 times in whole of en.wp ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "TheDJ" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19041 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: I was incorrect, we do have tfoot support apparently in 1.18 (r85922), but all content in Wikipedia currently assumes 'sortbottom'. I've been testing a few tables that use sortbottom, and i think that about 50% will break when we deploy this, because they don't use ! on all cells in their tablerow to indicate that this 'sortbottom' row is a footer. - We now have better syntax - The old syntax is broken So the question is: - Should we also support the old syntax in order to prevent drama ? - Should we explain up front to people what they need to fix in the articles in order to make it working again ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "TheDJ" posted a comment on MediaWiki.r86088. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86088#c18851 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: FYI, this breaks sortbottom behavior, because we have no tfoot support in wikitables yet. See also: bug 4740 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "TheDJ" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18622 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Since we have mw-collapsible and mw-collopsed now... Should we also change sortable and unsortable to mw-sortable and mw-unsortable Will be a lot of work to replace all that in the existing wikicode, but it's something to consider I think. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18573 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Wow, thanks for the quick fix! I'd only just narrowed it down to that commit and it would have taken me a while to figure out all the scary sort bits. ;) This resolves known actual bugs with the new sorting; should just need some more test cases for the fixed regressions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18570 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Fixed in r90612 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18566 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: It looks like these regressions are actually showing up on r86337 and later, but not on r86088 or r86305 (which both test clean once I adjust the test to set global month vars). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18564 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Numeric sort seems to be being broken by the date detection: numbers like '1234', '1234.5' etc match this regex: //Any date formated with . , ' - or / ts.dateRegex[0] = new RegExp(/^\s*\d{1,2}[\,\.\-\/'\s]*\d{1,2}[\,\.\-\/'\s]*\d{2,4}\s*?/i); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r86088. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c18555 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: There are some serious problems with this -- I've added a few initial qunit tests on trunk in r90595 and can confirm the failures I'm seeing manually: * numeric sort doesn't work (values of different magnitudes are somehow sorting wrong) * interference between tables? sort one table by name, then another and you often find that it sorts totally incorrectly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c16063 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: I'm not fond of it either, but it's necessary in order to use Array.sort ( http://www.w3schools.com/jsref/jsref_sort.asp ) Array.sort accepts a sorter function, and there no way to build this fn w/o eval. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Bawolff" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c16059 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Is the eval really necessary? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Catrope" posted a comment on MediaWiki.r86088. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86088#c16007 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: + #$localDateFormats = $wgContLang->getDateFormats(); + #$localPreferedFormat = $localDateFormats[$wgContLang->getDefaultDateFormat().' date']; + Please don't introduce commented-out code. There's another commented-out line a few lines down. + $monthNames = array(''); + $monthNamesShort = array(''); + for ($i=1; $i < 13; $i++) { + $monthNames[]=$wgContLang->getMonthName($i); + $monthNamesShort[]=$wgContLang->getMonthAbbreviation($i); + } This does not conform to whitespace conventions. Also, this array building code should be moved into the Language class so you can just call e.g. $wgContLang->getMonthNames() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Helder.wiki" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15996 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Isn't tableSorterCollation something that should go into mw.config.get( ... )? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added, and revision status changed
User "DieBuche" changed the status of MediaWiki.r86088. Old Status: fixme New Status: new User "DieBuche" also posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15982 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Ok, old code is removed & and I added support for data-sort-value & moved the other one to data-sort-type ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15980 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: It means that if it works, it will stay in trunk and future releases, but it will not go into the 1.18 release. data- attributes has been allowed for a while already. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15979 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: I somehow had the feeling that data stuff would be stripped. I was hesitant to close them because of the revert1.18 tag, will it only be reverted in the future REL1.18 branch? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r86088. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15978 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: You should remove all old code that is no longer in use. Otherwise it will just confuse people later. - jQuery( document ).ready( sortables_init ); + //jQuery( document ).ready( sortables_init ); By setting class="sort-{Parsername}", the row will be parsed with the specified Should use the data- parameters like the data-sort-value, which btw I don't see supported here! And you didn't close those bugs? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "Catrope" posted a comment on MediaWiki.r86088. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86088#c15974 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Provisionally tagging revert1.18; this is a rewrite that we'll probably want to defer to 1.19, assuming 1.18 will be branched in the next few days. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15971 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: That's not any better. *wishes for edit button* ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86088. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c15970 Commit summary: Completely rewritten table sorting script. Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732 1. Sites can specify custom collations. The script accepts an object "tableSorterCollation" which contains a lookup table, how specific characters should be treated. For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the site's common.js any string containing an ä or Ä will be sorted as if it were a 'ae'. 2. Table rows can be forced to use a specific data type. By setting class="sort-{Parsername}", the row will be parsed with the specified algorithm. class="sort-date" would force date sorting etc. The following parsers are available: text, IPAddress, number, url, currency, date, isoDate, usLongDate, time 3. Execution time is reduced by half or more. Sorting a 935 row * 8 columns table: Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms 4. Based on the content language and the mdy vs dmy preference, the parser can understand dates such as "17. März '11". wgMonthNames=[] and wgMonthNamesShort=[] in the content language and the mdy vs dmy preference are exported to js; A table containing the following dates would be sorted correctly: 17. Jan. 01 23 Feb 1992 9.02.05 13 November 2001 14 Oktober '76 Was tested in ie6-8, chrome, safari 5, ff3 & ff4 Comment: Weird something stripped the whitespace in the bench table Browser Before After -- - Chrome 10 90ms42ms Safari 5115ms 48ms Firefox 4 412ms 87ms IE8 720ms 115ms ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview