[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User "MarkAHershberger" changed the status of MediaWiki.r86305. Old Status: fixme New Status: ok User "MarkAHershberger" also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c22440 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Changing to OK but tagged TODO re Krinkle's comments and our meeting on FIXMEs last night. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86305.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c22329
Commit summary:
Followup r86088 per CR: Move month array builder into language; use
mw.config.get(); Fix rowspans and some cleanup
Comment:
Brion is right it's an site specific thing. Why would it be hard to use? You
just put something like mw.config.set('tableSorterCollation', {'รค' : 'ae'})
into common.js
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Krinkle" posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c21434 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Seems like something content language specific. Reminds me of the category collation sorting. Perhaps that can be used ? Regarding use script modification, theoretically that would be possible, but since the collation is build during construction and used from cache, it would be hard to use. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c21432 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: IIRC it's an interface allowing for user scripts / site scripts to set it to override the defaults. May need to be better defined, though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User "Krinkle" changed the status of MediaWiki.r86305. Old Status: new New Status: fixme User "Krinkle" also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c21396 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Marking fixme. tableSorterCollation isn't set anywhere (other than in the unit test). A grep search didn't return any call to mw.config.set and/or an array property in PHP's config vars for "tableSorterCollation". Where is it coming from or should the function using tableSorterCollation be refactored ? The rest of the revision is either fine or has been fixed in the mean time. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Catrope" posted a comment on MediaWiki.r86305. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86305#c21176 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: PHP part looks OK. Tagging for Krinkle to review the JS part. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User "DieBuche" changed the status of MediaWiki.r86305. Old Status: fixme New Status: new User "DieBuche" also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c19251 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Remarking as new; known regressions are fixed, rowspans got some tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c18571 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: (test case needed would be for the rowspans thing) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r86305. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c18558 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Needs JS tests; will end up reverted along with r86088 and friends if regressions are not fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Catrope" posted a comment on MediaWiki.r86305. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86305#c16162 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Right, I forgot. You can solve that with array_map, but that's not a whole lot clearer, so ignore me :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "DieBuche" posted a comment on MediaWiki.r86305. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86305#c16158 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Sounds cool, but that would only return the english keys defined in L92: array( 'january', 'february', 'march', 'april', 'may_long', 'june', 'july', 'august', 'september', 'october', 'november', 'december' ) Everyone of those needs to be run through getMessageFromDB() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User "Catrope" posted a comment on MediaWiki.r86305.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86305#c16157
Commit summary:
Followup r86088 per CR: Move month array builder into language; use
mw.config.get(); Fix rowspans and some cleanup
Comment:
+ function getMonthNamesArray() {
+ $monthNames = array( '' );
+ for ( $i=1; $i < 13; $i++ ) {
+ $monthNames[] = $this->getMonthName( $i );
+ }
+ return $monthNames;
+ }
This can be done much easier with e.g. return array_merge( array( '' ),
self::$mMonthMsgs ); and similar for the other one.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
