[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail 
User Brion VIBBER changed the status of MediaWiki.r87347.

Old Status: new
New Status: fixme

User Brion VIBBER also posted a comment on MediaWiki.r87347.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17755
Commit summary:

(bug 7) Special:Listfiles no longer throws an error on bogus file entries

Comment:

Title::makeTitle does not validate input and cannot return something resolving 
to false.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added

2011-06-07 Thread MediaWiki Mail 
User Catrope posted a comment on MediaWiki.r87347.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87347#c17756
Commit summary:

(bug 7) Special:Listfiles no longer throws an error on bogus file entries

Comment:

You may want makeTitleSafe() instead, if the input can possibly be invalid.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added

2011-06-07 Thread MediaWiki Mail 
User ^demon posted a comment on MediaWiki.r87347.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17757
Commit summary:

(bug 7) Special:Listfiles no longer throws an error on bogus file entries

Comment:

Yeah, makeTitleSafe(), whoops.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail 
User Brion VIBBER changed the status of MediaWiki.r87347.

Old Status: fixme
New Status: resolved

User Brion VIBBER also posted a comment on MediaWiki.r87347.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17805
Commit summary:

(bug 7) Special:Listfiles no longer throws an error on bogus file entries

Comment:

and fixed in r89674, thanks :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview