[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added, and revision status changed

2011-05-07 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r87587.

Old Status: fixme
New Status: ok

User "Siebrand" also posted a comment on MediaWiki.r87587.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16673
Commit summary:

Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13

Comment:

Ugh. Fixed in r87604. Please use the follow-up revs, Sam :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added, and revision status changed

2011-05-07 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r87587.

Old Status: new
New Status: fixme

User "Siebrand" also posted a comment on MediaWiki.r87587.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16672
Commit summary:

Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13

Comment:

Then reedy will, unfortunately, have to get busy updating the release notes for 
many more revs - he's been doing a lot of work on it (thanks Sam!)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added

2011-05-07 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r87587.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16671
Commit summary:

Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13

Comment:

When it doubt, it goes in the RELEASE-NOTES.

This should definitely be there, since we're removing back-compat.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added

2011-05-07 Thread MediaWiki Mail
User "Siebrand" posted a comment on MediaWiki.r87587.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16669
Commit summary:

Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13

Comment:

Should this type of change be in RELEASE-NOTES? Not sure what my opinion is. I 
do recognise however that it's not always clear to me which when to include 
something or not... Are there any guidelines?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview