[MediaWiki-CodeReview] [MediaWiki r87628]: New comment added

2011-05-07 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r87628.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87628#c16659
Commit summary:

(bug 28834) Restore nl2br() wrappers removed in r85918.

Comment:

No because a) the parameter was added in PHP 5.3 and so may not be available, 
and (more importantly) b) wfDie() does not assume that it is able to access the 
value of $wgWellFormedXml in either LocalSettings or DefaultSettings, 
and so unconditionally outputs an XHTML 1.0 Transitional doctype, 
regardless of the general state of the wiki.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87628]: New comment added

2011-05-07 Thread MediaWiki Mail 
User "Bryan" posted a comment on MediaWiki.r87628.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87628#c16655
Commit summary:

(bug 28834) Restore nl2br() wrappers removed in r85918.

Comment:

Shouldn't the second parameter of nl2br ($is_xhtml) be set, depending on 
$wgWellFormedXml?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview