User "Nikerabbit" posted a comment on MediaWiki.r89087.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89087#c18036
Commit summary:

PreviousTarget is now optional when blocking a user

The API does not seem to give a PreviousTarget field all the time.
This patch also fix the an assertion for ApiBlockTest::testMakeNormalBlock

Comment:

Some reason isset() cannot be used here? I'd prefer !== because we know both 
should be strings to match.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to