[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User Hashar posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17747 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: awesome! now we have to add a PHPUnit test suite to test the Block class :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User ^demon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17748 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: We do have (some) block tests. That's what led me to tracking this down. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User Happy-melon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17750 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: Block rewrite isn't in 1.17, it's 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
