[MediaWiki-CodeReview] [MediaWiki r89853]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r89853. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r89853. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89853#c20907 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter completenesstest has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential missing test. Comment: pre + console.log( 'CompletenessTest.ACTION_CHECK', that ); /pre So this code assumes codeconsole.log()/code will be callable? Doesn't that cause JS errors on browsers where it's not present? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89853]: New comment added
User Hashar posted a comment on MediaWiki.r89853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89853#c19695 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter completenesstest has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential missing test. Comment: jQuery part merged in 1.18 with r92349 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89853]: New comment added
User Reedy posted a comment on MediaWiki.r89853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89853#c19470 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter completenesstest has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential missing test. Comment: Tagging 1.18, but only jQuery to be merged ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89853]: New comment added
User Krinkle posted a comment on MediaWiki.r89853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89853#c17925 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter completenesstest has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential missing test. Comment: jQuery was updated, was intended for r89866 (1 minute after). Sorry for the mixup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
