[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added, and revision status changed

2011-06-16 Thread MediaWiki Mail 
User Platonides changed the status of MediaWiki.r89948.

Old Status: new
New Status: ok

User Platonides also posted a comment on MediaWiki.r89948.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18232
Commit summary:

* Fix I18nTags #languagename to use ParserOptions::getUserLang()
* Fix ParserOptions::getUserLang() to return code as documented

Comment:

Actually, I think there was some code down at wfMsg* so that both may have 
worked.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added

2011-06-16 Thread MediaWiki Mail 
User Nikerabbit posted a comment on MediaWiki.r89948.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18247
Commit summary:

* Fix I18nTags #languagename to use ParserOptions::getUserLang()
* Fix ParserOptions::getUserLang() to return code as documented

Comment:

What both would have worked?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added

2011-06-16 Thread MediaWiki Mail 
User Platonides posted a comment on MediaWiki.r89948.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18249
Commit summary:

* Fix I18nTags #languagename to use ParserOptions::getUserLang()
* Fix ParserOptions::getUserLang() to return code as documented

Comment:

Passing either a language code or a language object.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added

2011-06-14 Thread MediaWiki Mail 
User Platonides posted a comment on MediaWiki.r89948.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18053
Commit summary:

* Fix I18nTags #languagename to use ParserOptions::getUserLang()
* Fix ParserOptions::getUserLang() to return code as documented

Comment:

You weren't supposed to pass setUserLang() a Language object. Maybe it should 
thrown an exception instead of doing the right thing. Passing setUserLang() an 
object and getting a Language code is also weird...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added

2011-06-14 Thread MediaWiki Mail 
User Nikerabbit posted a comment on MediaWiki.r89948.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18054
Commit summary:

* Fix I18nTags #languagename to use ParserOptions::getUserLang()
* Fix ParserOptions::getUserLang() to return code as documented

Comment:

This was just a quick fix. Feel free to replace with a better one.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview