[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90043. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18156 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: I couldn't get the update or api script to open. The updater crashed on trying to read a file from /maintenance/archive, the api: preParse error: syntax error, unexpected '}' in /htdocs/SVN/mediawiki/trunk/extensions/MoodBar/ApiMoodBar.php on line 17/pre Can you investigate ? Perhaps look at ArticleFeedback as example. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Werdna posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18217 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: Sorry about that, I have no idea how that bit disappeared — I must have messed something up between testing and committing. Thanks for fixing this commit up, folks — looks like I was having a bad night. :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Siebrand posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18041 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: Can you please rename the messages file to MoodBar.i18n.php as this is the current naming convention for messages files? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Werdna posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18042 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: I prefer to use a different name because it makes autocomplete and scanning the file list easier — is there a convincing reason to stick to MoodBar.i18n.php other than all the other extensions do it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Siebrand posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18043 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: It takes more configuration to add support for the Translate extension, and all the other couple of hundred extensions do it. We have just taken a few years cleaning everything up. But if it is really important, just add a no rename request in the i18n file. People will understand. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Werdna posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18044 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: I've renamed it, I didn't realise it caused issues with Translate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
