[MediaWiki-CodeReview] [MediaWiki r90340]: New comment added
User "Krinkle" posted a comment on MediaWiki.r90340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90340#c19565 Commit summary: (bug 29408) Key 'something.' is not in a proper format Fixed this by relaxing the stash key regex. For some files MediaWiki is simply not able to guess an extension. If the wiki has been configured to allow them, we should just let them pass in the stash as well. Comment: See also bug 26367. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90340]: New comment added
User "Hashar" posted a comment on MediaWiki.r90340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90340#c19730 Commit summary: (bug 29408) Key 'something.' is not in a proper format Fixed this by relaxing the stash key regex. For some files MediaWiki is simply not able to guess an extension. If the wiki has been configured to allow them, we should just let them pass in the stash as well. Comment: Bug 29408 got follow up: Thanks! However, this does not fix the second half of the problem: Attempting to move already-uploaded .dem files, without changing the .dem extension, causes the error "The new file extension does not match its type" to appear (and the file doesn't move). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90340]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r90340. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r90340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90340#c18362 Commit summary: (bug 29408) Key 'something.' is not in a proper format Fixed this by relaxing the stash key regex. For some files MediaWiki is simply not able to guess an extension. If the wiki has been configured to allow them, we should just let them pass in the stash as well. Comment: You upset cruisecontrol. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90340]: New comment added, and revision status changed
User "Bryan" changed the status of MediaWiki.r90340. Old Status: fixme New Status: new User "Bryan" also posted a comment on MediaWiki.r90340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90340#c18363 Commit summary: (bug 29408) Key 'something.' is not in a proper format Fixed this by relaxing the stash key regex. For some files MediaWiki is simply not able to guess an extension. If the wiki has been configured to allow them, we should just let them pass in the stash as well. Comment: Can't reproduce, but should be fixed by r90349. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
