[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added, and revision status changed

2011-08-25 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r90668.

Old Status: fixme
New Status: ok

User "Reedy" also posted a comment on MediaWiki.r90668.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21466
Commit summary:

Fix for r86722: pass the message 'dberrortext' unescaped to the output since it 
contains. I really don't like to pass unescaped messages to the output *sigh*

Comment:

Marking ok again after fixing the actual issue in r95495 (which wasn't this rev)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added, and revision status changed

2011-08-24 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r90668.

Old Status: ok
New Status: fixme

User "Raymond" also posted a comment on MediaWiki.r90668.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21385
Commit summary:

Fix for r86722: pass the message 'dberrortext' unescaped to the output since it 
contains. I really don't like to pass unescaped messages to the output *sigh*

Comment:

This can produce a PHP warning:

 Warning:  htmlspecialchars() expects parameter 1 to be string, array given in 
D:\F_Programmierung\xampp\htdocs\wiki2\includes\db\DatabaseError.php on line 271

[[File:R90668 warning Screenshot.png|thumb|left|300px|Screenshot]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview