[MediaWiki-CodeReview] [MediaWiki r91668]: New comment added
User "Bawolff" posted a comment on MediaWiki.r91668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91668#c19336 Commit summary: Fixes Bug#17866 Minimal check that we have more than an empty string before sending and email. NikeRabbit asked me about LQT sending email to users w/o email addresses and this looked like one good place to add a check. Comment: I think there is a larger issue here involving confirming email. It should be impossible to send an email if your email is not verified. You can't verify an email if you don't have one set, so it should be impossible to get to this point if you don't have an email set. (Of course checking there is an email is probably a good sanity check nonetheless) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91668]: New comment added
User "MarkAHershberger" posted a comment on MediaWiki.r91668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91668#c19353 Commit summary: Fixes Bug#17866 Minimal check that we have more than an empty string before sending and email. NikeRabbit asked me about LQT sending email to users w/o email addresses and this looked like one good place to add a check. Comment: I agree that there is probably something that should be fixed in LQT so that it checks to make sure there is actually an email address to send to. In fact this doesn't solve the problem. Emails can still be sent w/o an actual address. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91668]: New comment added
User "Bawolff" posted a comment on MediaWiki.r91668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91668#c19354 Commit summary: Fixes Bug#17866 Minimal check that we have more than an empty string before sending and email. NikeRabbit asked me about LQT sending email to users w/o email addresses and this looked like one good place to add a check. Comment: I think the issue is more in where-ever we do verifications that the email is authenticated. Really its not LQT's job to do that, but should use the same code as special:emailuser/watchlist notifications/etc uses. (I'm assuming said code exists somewhere, I don't know enough about email stuff to say if that's actually the case or not) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
