User NeilK posted a comment on MediaWiki.r91671.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91671#c20500
Commit summary:
* add a spidering function for wget in spider.php
* add rel=nofollow to Cache links
Comment:
You don't even have plans to support curl, the download_lib thing is a waste of
space. Add it when you support curl.
You already brought this up yourself, but replace shell_exec() with
wfShellExec() - that seems not to be fixed in current version
The path to wget should be a global and should default to where it usually is
on Ubuntu Linux (/usr/bin/wget), see how we do it with
$wgImageMagickConvertCommand in DefaultSettings.php
Re: $ignore_in_prog_time, Testing for config variables and putting default
values deep in code is bad, try to establish the config as early as possible --
think of config as an input to your function, not something you create in the
middle of the function. Spelling mistake with $ingore / $ignore. At least try
it once before committing. i see you fix this in later revs though.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
