[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added

2011-07-28 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c20282
Commit summary:

output campaign log details

Comment:

Fixed in r93443.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added

2011-07-23 Thread MediaWiki Mail
User "Seb35" posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c20088
Commit summary:

output campaign log details

Comment:

The message key 'centralnotice-banners-changed' has been introduced here but is 
(still) not used.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added

2011-07-14 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19620
Commit summary:

output campaign log details

Comment:

Done in r92224.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added, and revision status changed

2011-07-14 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r92037.

Old Status: new
New Status: ok

User "Awjrichards" also posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19611
Commit summary:

output campaign log details

Comment:

You might consider un-hardcoding styling in showInitialSettings() and 
showChanges()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added

2011-07-13 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19554
Commit summary:

output campaign log details

Comment:

fixed in r92073

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added, and revision status changed

2011-07-13 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r92037.

Old Status: new
New Status: fixme

User "Siebrand" also posted a comment on MediaWiki.r92037.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19536
Commit summary:

output campaign log details

Comment:

Duplicate keys in message documentation:

+'centralnotice-multiple-languages' => '$1 is the number of languages 
in which the
notice is available. It is always greater than 3. This message is in the column
"languages" in the table.',
+'centralnotice-multiple-languages' => '$1 is the number of countries 
in which the
notice is available.',

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview