[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Bawolff posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c24006 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Causes bug 31551. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Peachey88 posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c23783 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Release Notes? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Peachey88 posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c23784 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: This is tagged post1.18deploy but appears to be apart of the 1.18 deploy, someone feel like detagging? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Krinkle posted a comment on MediaWiki.r92054.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22705
Commit summary:
Render category links as an HTML list. Bug 12261. Based on patch by Thana
Bergi. It's removing the textual pipe separator, wrapping the links inside li
elements and adding a left 1px border as separator. This makes it much easier
to manipulate the list via JS or CSS and is also semantically correct
Comment:
blockquote''Hm.. seems it is already centralized. Skin.php defines a method
codeSkin-getCategories()/code which wraps {{cnw|div id=catlinks}}
around {{cnw|getCategoryLinks()}} , perhaps use that instead ?''/blockquote
Any thoughts on that ? Is there a reason for not using that ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Dantman posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22707 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: The skins being legacy skins and being to lazy sounds like a good enough reason to me... I want to just get rid of those skins. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Krinkle posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22711 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: That's not a good reason to me. They are in trunk, so either remove it or maintain it. I've done it myself in r97382. There was also an issue with padding (see http://i.imgur.com/JWJvp.png). Fixed in r97381. Marking OK, rest looks good. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Dantman posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22712 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: ;) I hope I can do that by 1.20... I'm waiting for stats. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r92054. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22330 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: r96775 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Catrope posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22251 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Is there still a good reason for this to be marked fixme? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Dantman posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22252 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Print styles are still broken by this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Dantman posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21911 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: catlinks / getCategories needs to die horrible death... Style of things like these should be up to the skin that's actually styling the skin. This css should be in the individual skin stylesheets (like the rest of usermessage, header, toc, siteSub, etc...) and should be moved to commonInterface.css in 1.19. It should also use the css class, not the id. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92054. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21406 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: This revision introduces an issue. The codenowikidiv id=catlinks/nowiki/code are outputted form within the skin-implementations (ie. ColongneBlue.php), but that ID is styled from codecommon.css/code, please centralize that output so that the ID-naming is the same acros skins (or move the styling to skin's stylesheet). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Krinkle posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21407 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Hm.. seems it is already centralized. codeSkin.php/code defines a method codeSkin-getCategories()/code which wraps codenowikidiv id=catlinks/nowiki/code around codegetCategoryLinks()/code , perhaps use that instead ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User TheDJ posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c20104 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: We should inform Lupo, prime maintainer of HotCat ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User DieBuche posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c20105 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Just did so. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User DieBuche posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19634 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: I'm not sure: Should categories even be printed? We strip out a lot of other stuff and they're mostly useful for the discovery of articles, but not so on paper. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Peachey88 posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19635 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: I don't believe we print them currently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User DieBuche posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19641 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Just tried: Currently we do. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Fomafix posted a comment on MediaWiki.r92054.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19584
Commit summary:
Render category links as an HTML list. Bug 12261. Based on patch by Thana
Bergi. It's removing the textual pipe separator, wrapping the links inside li
elements and adding a left 1px border as separator. This makes it much easier
to manipulate the list via JS or CSS and is also semantically correct
Comment:
The space in code{$pop} {$embed}/code must be removed, because it is
rendered as codenowiki/li li/nowiki/code. This space is visible and
shifts the separator border out of the middle between the two words.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Fomafix posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19588 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: The style definition for printing is missing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
