[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92112. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c20296 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Addressed points related to the original script and the changes made here and in the follow-ups in r93351. Marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92112. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19682 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Why did you change it from an object oriented script into separate variables and functions ? The original wasn't perfect and wasn't a a proper object constructor with prototype functions and an options object either, but going away from that into even less object orientation seems wrong to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
