[MediaWiki-CodeReview] [MediaWiki r93595]: New comment added
User Eloquence posted a comment on MediaWiki.r93595. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93595#c20326 Commit summary: Instead of scraping the page title, use the actual title from the title object (and the actual title) Comment: Mh, I'm guessing the wurfl-config.xml change was accidentally committed as part of this rev? It did have the nice side effect of fixing WURFL for me. ;-) Obviously hardcoding config options here is wrong -- would be nice to move this into a config flag for the extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93595]: New comment added
User TheDJ posted a comment on MediaWiki.r93595. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93595#c20327 Commit summary: Instead of scraping the page title, use the actual title from the title object (and the actual title) Comment: Thx. Yeah I already made a note somewhere that we really should be using inmemoryconfig of wurfl. http://www.scientiamobile.com/api-doc/php/WURFL_Configuration/WURFL_Configuration_InMemoryConfig.html ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
