[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-11 Thread MediaWiki Mail 
User "Catrope" posted a comment on MediaWiki.r93856.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93856#c20620
Commit summary:

Add archive feed API list module for external archival services.

Comment:

What I usually do is go to the API help page (the autogenerated one, which you 
get to by calling api.php without any parameters) and Ctrl+F for the desired 
prefix preceded by a space, or prefix+'limit'. That's pretty sure to find an 
existing prefix.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-10 Thread MediaWiki Mail 
User "NeilK" posted a comment on MediaWiki.r93856.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93856#c20600
Commit summary:

Add archive feed API list module for external archival services.

Comment:

I have no idea how to ensure your API key is unique. I have trouble with this 
myself.

I just used this command to grep through the whole source tree, and it MAY have 
discovered all the possible keys that exist already...

$ find includes/api extensions/ -name 'Api*.php' | xargs grep __construct | 
perl -wlne '/moduleName\s*,\s*([^)]+)/ and print $1' | sort | uniq

$code 
$modulePrefix = '' 
$paramPrefix 
$paramPrefix = '' 
$prefix 
$prefix = 'ii' 
$prefix = 'vi' 
$this->prefix 
'' 
'abf' 
'ac' 
'af' 
'afl' 
'ai' 
'al' 
'am' 
'ap' 
'au' 
'bg'
'bk' 
'cc' 
'ci' 
'cl' 
'cm' 
'cp' 
'cr' 
'cs' 
'ct' 
'df' 
'dr' 
'el' 
'eu' 
'fa' 
'ga' 
'gc' 
'gu' 
'gui' 
'ii' 
'im' 
'in' 
'iw' 
'iwbl' 
'lbl' 
'le' 
'll' 
'mc' 
'mg' 
'or' 
'pa' 
'pp' 
'pt' 
'qp' 
'rc' 
'rn' 
'rp' 
'rt' 
'rv' 
'si' 
'sii' 
'sr' 
'tb' 
'tg' 
'th' 
'ti' 
'uc' 
'ui' 
'ur' 
'us' 
've' 
'wl' 
'wr' 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-10 Thread MediaWiki Mail 
User "Kevin Brown" posted a comment on MediaWiki.r93856.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93856#c20598
Commit summary:

Add archive feed API list module for external archival services.

Comment:

Thanks for catching this, I didn't notice it at the time. Would "afl" be a good 
prefix?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-10 Thread MediaWiki Mail 
User "NeilK" posted a comment on MediaWiki.r93856.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93856#c20578
Commit summary:

Add archive feed API list module for external archival services.

Comment:

marking fixme due to the prefix issue

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-10 Thread MediaWiki Mail 
User "Catrope" posted a comment on MediaWiki.r93856.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93856#c20565
Commit summary:

Add archive feed API list module for external archival services.

Comment:

Yes. Such conflicts should be avoided, because it breaks support for combining 
arbitrary queries in one request.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added

2011-08-05 Thread MediaWiki Mail 
User "NeilK" posted a comment on MediaWiki.r93856.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93856#c20490
Commit summary:

Add archive feed API list module for external archival services.

Comment:

Does the prefix "al" conflict with the "alllinks" API methods? 
http://www.mediawiki.org/wiki/API:Alllinks





___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview