[MediaWiki-CodeReview] [MediaWiki r93980]: New comment added
User ^demon posted a comment on MediaWiki.r93980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93980#c20929 Commit summary: * Call Linker methods statically * Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation Comment: If everything actually updated stats via SiteStats, then yeah we probably could. Unfortunately we've got a lot of manual site_stats queries all over the place. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93980]: New comment added
User Hashar posted a comment on MediaWiki.r93980. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93980#c20555 Commit summary: * Call Linker methods statically * Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation Comment: Cant we disable site_stats when running parser tests? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93980]: New comment added
User IAlex posted a comment on MediaWiki.r93980. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93980#c20510 Commit summary: * Call Linker methods statically * Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation Comment: After some investigation, there are two things: * DatabaseSqliteTest calls SiteStatsInit::doAllAndCommit() which calls refresh() that does a DELETE/INSERT on the site_stats table, adding the row * That function is called once per Parser test, i.e. about 500 times when running the test suite. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93980]: New comment added
User ^demon posted a comment on MediaWiki.r93980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93980#c20487 Commit summary: * Call Linker methods statically * Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation Comment: I ''just'' removed that IGNORE because it wasn't throwing errors for me anymore. See r93933, r88772. Stack trace? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
