[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c22895 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Robin: can you do the split? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r93985. Old Status: deferred New Status: new User Nikerabbit also posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c20886 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Seems to silently break Translate extension for older version which don't have this hook. I think that is acceptable given the minor impact, not many people rely on this behavior. I'd like to break the onPageContentLanguage to two different functions, since code under tag/ should only handle page translation feature related stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User SPQRobin posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c20914 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Yeah, or we can move the function to a general file/class. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User Catrope posted a comment on MediaWiki.r93985. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93985#c20734 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: DO NOT DEFER REVISIONS IN THIS EXTENSION. It's deployed at WMF, on incubatorwiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User Catrope posted a comment on MediaWiki.r93985. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93985#c20743 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: By this extension I meant WikimediaIncubator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User Catrope posted a comment on MediaWiki.r93985. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93985#c20744 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: WikimediaIncubator part looks OK. Will not have any effect on 1.17wmf1 because the PageContentLanguage hook doesn't exist in that version, but the hook will be ignored in 1.17wmf1 and will magically start working in 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User SPQRobin posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c20781 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Yeah, thought so. That's the intention :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
