[MediaWiki-CodeReview] [MediaWiki r95172]: New comment added

2011-08-31 Thread MediaWiki Mail
User "Jeroen De Dauw" posted a comment on MediaWiki.r95172.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95172#c21690
Commit summary:

also support OutputPage/ParserOutput-agnostic script loading a la addScript() 
via SMWOutputs

Comment:

Markus, can you have a look at r95874? That code was adding resource loader 
module names as head items for MW >= 1.17. Commenting it out does not seem to 
cause any issues, but I'm not sure what the original purpose of this was, so 
something might be broken now (esp on 1.16).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95172]: New comment added, and revision status changed

2011-08-22 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r95172.

Old Status: deferred
New Status: fixme

User "Raymond" also posted a comment on MediaWiki.r95172.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95172#c21256
Commit summary:

also support OutputPage/ParserOutput-agnostic script loading a la addScript() 
via SMWOutputs

Comment:

Seen on translatewiki.net:

 PHP Notice: Undefined property: ParserOutput::$headItems in 
/www/w/extensions/SemanticMediaWiki/includes/SMW_Outputs.php on line 120

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview