[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Krinkle posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c23475 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: The fact that the Title object becomes mutable and that this new feature is enabled by default even when no repository is defined is problematic enough. Before things come dependant on this making merging revisions even harder, please remove this from core as soon as possible. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c23060 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: We should make a decision about this - is it staying in trunk, and if so, needs tidying up Else we back it out (sooner rather than later, 1.19 is going to be upon us soon...) and cleanup and think about properly extension-i[sz]ing it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Duplicatebug posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c22351 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: An unused tt$forceRawInterwiki/tt is leaved in Parser.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Duplicatebug posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c22352 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: This commit makes Title.php mutable (with Title::setInterwiki), it is called at one place, maybe it is possible to create a new title with one of the factory methods and remove Title::setInterwiki. The change of Preprocessor_Hash.php should also added to Preprocessor_HipHop. A comment is also nice, to say why the interwiki of the frame/context, and not the interwiki from the templatename, is used. (My understanding: It is used to load the inner templates of a distant template also from the distant wiki). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Krinkle posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21951 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Another problem is that these two special pages are enabled, accessible and listed on Special:SpecialPages by default. That's not supposed to happen ad 99% of wikis will not have anything global and doesn't need this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Krinkle posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21952 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: I agree, this seems like a perfect thing to go into an extension. A few side notes: * It uses global $wgUser-getSkin(); ** No need for globals here. OutputPage extends ContextSource which means it has both getUser and getSkin on itself. * CSS classnames used like codedistantTemplatesUsed/code and codemw-templatesUsedExplanation/code should user lowercase and separation by dash, and where needed prefixed with atleast codemw-/code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21953 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Indeed, which was the way when the code was written. This was a merge into trunk, not a merge and fix every issue ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21882 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: When trying to search for a global template usage: SQL error ... from within function GlobalUsageQuery::searchTemplate. Database returned error 1046: No database selected (localhost). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21884 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: That just sounds like it needs an if no database set, go away ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21885 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Which begs the question, why is this in core when wikifarms are rare compared to individual installations? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21758 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Class name clashes isn't really a good start... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21764 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Logged as bug 30686, and awaiting a response from Peter about it It seems that the one now in core, is a slightly modified, but otherwise copy of GlobalUsageQuery and SpecialGlobalUsage from the GlobalUsage extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21765 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Actually, this to some extent exists in the GlobalUsage extension... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21684 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: bug 30641 and possibly another... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21689 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Swapped $wgGlobalDB for $wgGlobalDatabase in r95872 $wgWikiID doesn't seem defined anyway, but not sure what it's supposed to be set to.. (in Default Settings) There's also an undefined $prefix (tagged with a FIXME comment in the code) Going to try and ping Peter to help tidy this up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396.
Old Status: new
New Status: fixme
User Raymond also posted a comment on MediaWiki.r95396.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21531
Commit summary:
Merge the iwtransclusion branch back into trunk
Hexmode fixed broken unit tests in revisions after last time
Comment:
pre
PHP Fatal error: Call to undefined method Title::moveToInternal() in
/www/w/includes/Title.php on line 3191
- private function moveToInternal( $nt, $reason = '', $createRedirect =
true ) {
- global $wgUser, $wgContLang;
+ private function moveOverExistingRedirect( $nt, $reason = '',
$createRedirect = true ) {
+ global $wgUseSquid, $wgUser, $wgContLang,
$wgEnableInterwikiTemplatesTracking, $wgGlobalDatabase;
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Raymond posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21533 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: On a first glanced fixed with r95594 but it seems the page moves (via JobQueue @ translatewiki.net) do not appear on the move log. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: fixme New Status: new User Raymond also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21534 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Strike the last comment. Seems fixed, revision status back to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21543 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Uses undefined globals $wgWikiID and $wgGlobalDB in LinksUpdate.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Duplicatebug posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21548 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Please add some API modules: * list=globalimageusage (or add a global parameter to list=imageusage) * list=globaltemplateusage/globalembeddedin (or add a global parameter to list=embeddedin) Please add global=wikiid/wikiname or imagerepository=wikiid/wikiname in the output of prop=images/templates when the used image/template came from another wiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21550 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Log that as a feature request ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21443 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Seen on Translatewiki: [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globalfileusage when searching for special page aliases for GlobalFileUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:00] PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 [25-Aug-2011 08:03:08] PHP Fatal error: Call to undefined method Xml::hidden() in /www/w/includes/specials/SpecialGlobalFileUsage.php on line 46 [25-Aug-2011 08:03:09] PHP Fatal error: Call to undefined method Xml::hidden() in /www/w/includes/specials/SpecialGlobalTemplateUsage.php on line 49 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User NeilK posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21499 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: n.b. This change will break wikis that are still using the old GlobalUsage extension -- the classes are redefined in an incompatible way ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21375 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Obviously this really needs RELEASE-NOTES writing up, as wgScaryTransclusion is dead etc... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21376 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21378 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Other minor thing is getCanonicalUrl() needs fixing in trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
