[MediaWiki-CodeReview] [MediaWiki r95586]: New comment added
User "SPQRobin" posted a comment on MediaWiki.r95586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95586#c21540 Commit summary: (bug 30566) Show error message if an IP is given on Special:ViewUserLang Another slight change: use if() { return ..; } instead of if() { .. } else { .. } Comment: I know, but I prefer to do it this way :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95586]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r95586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95586#c21530 Commit summary: (bug 30566) Show error message if an IP is given on Special:ViewUserLang Another slight change: use if() { return ..; } instead of if() { .. } else { .. } Comment: $wgOut->wrapWikiMsg? +return $wgOut->addHTML( Xml::span( wfMsg( 'wminc-ip', $target ), 'error' ) ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95586]: New comment added
User "SPQRobin" posted a comment on MediaWiki.r95586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95586#c21527 Commit summary: (bug 30566) Show error message if an IP is given on Special:ViewUserLang Another slight change: use if() { return ..; } instead of if() { .. } else { .. } Comment: Note: the diff looks like I changed a lot in showInfo() but I only changed if( .. ) { .. } else { .. } to if( .. ) { return ..; } .. and changed indenting accordingly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview