[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-28 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r95596.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95596#c21553
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

reverted in r95618 (because r95596 raised more questions than it solved 
problems)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-27 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r95596.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95596#c21536
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

Can you enlighten me what the problem being solved here is? As I understand it 
the bug is that on wiki with ['*']['view']=false users can't get a password 
reset e-mail. How does adding a new permission that potentially restricts 
PasswordReset even more fix the issue that a logged out user can't view the 
passwordreset special page? Isn't the correct fix here to add PasswordReset to 
the default whitelist?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-27 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r95596.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95596#c21537
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-27 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r95596.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95596#c21538
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

the other way around. It's for wikis where all pages can be viewed, but only - 
for example Sysops - can trigger reset password.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-27 Thread MediaWiki Mail
User Duplicatebug posted a comment on MediaWiki.r95596.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95596#c21547
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

Please create [[MediaWiki:Right-resetpassword]] (and add it to the maintenance 
file) for localisation on [[Special:ListGroupRights]]. Thanks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95596]: New comment added

2011-08-27 Thread MediaWiki Mail
User Reach Out to the Truth posted a comment on MediaWiki.r95596.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95596#c21551
Commit summary:

Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: 
wikitech-l 
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 
'Reclaiming a lost account on a private wiki: impossible'

Comment:

I'm not clear on how this would fix that. No restrictions were removed or 
loosened here, instead you've made it easier to add restrictions. Is there 
another part of this fix that hasn't been committed yet?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview