[MediaWiki-CodeReview] [MediaWiki r96815]: New comment added

2011-09-11 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r96815.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96815#c22356
Commit summary:

navigation++

Comment:

pre
+   protected function displayNavigation( array $links ) {
+   $this-getOutput()-addHTML( Html::rawElement( 'p', array(), 
implode( ' - ', $links ) ) );
+   }
/pre
Perhaps use Language-pipeList() instead ? Using dash as separator in 
navigation is uncommon in MediaWiki.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r96815]: New comment added

2011-09-11 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96815.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96815#c22357
Commit summary:

navigation++

Comment:

Cool, applied in follow up :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview