[MediaWiki-CodeReview] [MediaWiki r97374]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97374#c22921 Commit summary: AdManager: version 0.2: *remove unused jquery-1.4.2.min.js file *define new globals $wgAdManagerService and $wgAdManagerCode in the setup file *some i18n tweaks *removed usage of $wgDBprefix from the code, Database class can automatically add it when needed *simplified ResourceLoader existence checks *added __METHOD__ to all Database calls *trimmed trailing whitespace for all files *coding style tweaks *removed ancient cruft (wfLoadExtensionMessages etc.) *added read-only/block checks to special pages Comment: Those i18n files get not so fun to work with when they are in multimegabyte size category. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97374]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r97374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97374#c22872 Commit summary: AdManager: version 0.2: *remove unused jquery-1.4.2.min.js file *define new globals $wgAdManagerService and $wgAdManagerCode in the setup file *some i18n tweaks *removed usage of $wgDBprefix from the code, Database class can automatically add it when needed *simplified ResourceLoader existence checks *added __METHOD__ to all Database calls *trimmed trailing whitespace for all files *coding style tweaks *removed ancient cruft (wfLoadExtensionMessages etc.) *added read-only/block checks to special pages Comment: I wouldn't know, as it's not my extension. :) Ideally it'd be nice to have everything and anything i18n in one file, just like how we have for core: magic words, special page aliases and interface messages, all in one MessagesXx.php file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97374]: New comment added
User Raymond posted a comment on MediaWiki.r97374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97374#c22718 Commit summary: AdManager: version 0.2: *remove unused jquery-1.4.2.min.js file *define new globals $wgAdManagerService and $wgAdManagerCode in the setup file *some i18n tweaks *removed usage of $wgDBprefix from the code, Database class can automatically add it when needed *simplified ResourceLoader existence checks *added __METHOD__ to all Database calls *trimmed trailing whitespace for all files *coding style tweaks *removed ancient cruft (wfLoadExtensionMessages etc.) *added read-only/block checks to special pages Comment: alias file for special pages is missing. Intentionally? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
