[Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Zoran Dori 
Hi,
could someone review my patches in
https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/WikEdDiff,dashboards/default
?

With my patches all should be ok, -1's by Jenkins aren't related to my
patches.

Best regards ,

Zoran Dori
volunteer, Wikimedia Serbia
s: zoranzoki21.github.io e: zorandori4...@gmail.com
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Zoran Dori 
Hmm, URL works only in old UI, not in new.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Aron Demian 
On Sat, 29 Feb 2020 at 21:50, Zoran Dori  wrote:

> Hmm, URL works only in old UI, not in new.


Didn't work for me even in the old one. Please submit a working link next
time.
https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FWikEdDiff+status:open

First patch in chain:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikEdDiff/+/571093



Demian
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Brian Wolff 
Umm, what is with the sgndrp.online tracker urls?

--
Bawolff

On Saturday, February 29, 2020, Aron Demian  wrote:

> On Sat, 29 Feb 2020 at 21:50, Zoran Dori  wrote:
>
> > Hmm, URL works only in old UI, not in new.
>
>
> Didn't work for me even in the old one. Please submit a working link next
> time.
> https://gerrit.wikimedia.org/r/q/project:mediawiki%
> 252Fextensions%252FWikEdDiff+status:open
>  3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fq%2Fproject%3Amediawiki%
> 25252Fextensions%25252FWikEdDiff%2Bstatus%3Aopen&dID=1583010965492&
> linkName=https://gerrit.wikimedia.org/r/q/project:
> mediawiki%252Fextensions%252FWikEdDiff+status:open>
> First patch in chain:
> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikEdDiff/+/571093
>  3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fc%2Fmediawiki%
> 2Fextensions%2FWikEdDiff%2F%2B%2F571093&dID=1583010965492&
> linkName=https://gerrit.wikimedia.org/r/c/mediawiki/
> extensions/WikEdDiff/+/571093>
>
>
> Demian
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Aron Demian 
On Sun, 1 Mar 2020 at 01:59, Brian Wolff  wrote:

> Umm, what is with the sgndrp.online tracker urls?
>
> --
> Bawolff
>
> On Saturday, February 29, 2020, Aron Demian 
> wrote:
>
> > On Sat, 29 Feb 2020 at 21:50, Zoran Dori 
> wrote:
> >
> > > Hmm, URL works only in old UI, not in new.
> >
> >
> > Didn't work for me even in the old one. Please submit a working link next
> > time.
> > https://gerrit.wikimedia.org/r/q/project:mediawiki%
> > 252Fextensions%252FWikEdDiff+status:open
> >  > 3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fq%2Fproject%3Amediawiki%
> > 25252Fextensions%25252FWikEdDiff%2Bstatus%3Aopen&dID=1583010965492&
> > linkName=https://gerrit.wikimedia.org/r/q/project:
> > mediawiki%252Fextensions%252FWikEdDiff+status:open>
> > First patch in chain:
> > https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikEdDiff/+/571093
> >  > 3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fc%2Fmediawiki%
> > 2Fextensions%2FWikEdDiff%2F%2B%2F571093&dID=1583010965492&
> > linkName=https://gerrit.wikimedia.org/r/c/mediawiki/
> > extensions/WikEdDiff/+/571093>
> >
> >
> > Demian
> > ___
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-02-29 Thread Aron Demian 
On Sun, 1 Mar 2020 at 01:59, Brian Wolff  wrote:

> Umm, what is with the sgndrp.online tracker urls?
>

This addon:
https://chrome.google.com/webstore/detail/unlimited-email-tracker/gojogohjgpelafgaeejgelmplndppifh

Sorry for that, apparently I haven't turned it off on this station after
moving.
Inb4: It's not sharing PII (IP), only the fact that a link was visited.

The correct link is (hopefully):

List:
https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FWikEdDiff+status:open
First patch in chain:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikEdDiff/+/571093

The error in the tests is:
01:52:32 [0-1] Error in "Page should be undoable"
01:52:32 Can't call click on element with selector "#wpSave" because
element wasn't found

Run by:
core.git /tests/selenium/specs/page.js

Previous patch on Feb 04 did not fail. A dummy patch today fails. I wonder
what changed.


Demian
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-03-01 Thread Zoran Dori 
Patch on Feb 04 is related to updating composer dependencies. Patches
before that are just updating dependencies and L10n-bot translation updates.

Last patch which isn't like it is patch by Jay Prakash for
https://phabricator.wikimedia.org/T189301.

Best regards,

Zoran Dori
volunteer, Wikimedia Serbia
s: zoranzoki21.github.io e: zorandori4...@gmail.com
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [WikiEdDiff] Review wanted

2020-03-03 Thread Zoran Dori 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikEdDiff/+/575773/
 and
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikEdDiff/+/571093/
should be force-merged.

I will try to fix
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikEdDiff/+/575774/
 and
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikEdDiff/+/575775/
shouldn't
get +2 before it.

Best regards,

Zoran Dori
volunteer, Wikimedia Serbia
s: zoranzoki21.github.io e: zorandori4...@gmail.com

>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l