Re: [Wikitech-l] Flagged revs and Lua modules

2013-03-21 Thread Aaron Schulz
Sounds like a site config issue. All wikis that have NS_TEMPLATE in
$wgFlaggedRevsNamespaces should also have NS_MODULE in there.



--
View this message in context: 
http://wikimedia.7.n6.nabble.com/Flagged-revs-and-Lua-modules-tp4999685p497.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Flagged revs and Lua modules

2013-03-20 Thread Bináris
Please can anyone help to solve this issue? It causes a lot of extra work,
thousands of unchecked pages.

2013/3/18 Bináris wikipo...@gmail.com

 Hi,

 I don't know if there is a bugreport on this, forgive me if I duplicate.

 Hungarian Wikipedia began to use Scribunto in the first batch, and we also
 use Flagged Revisions.
 This is a page:
 http://hu.wikipedia.org/w/index.php?title=Abe_Sinz%C3%B3action=history
 where the editors were all trusted and/or bots, but the page had to be
 explicitliy checked. The behaviour is just like when a template is modified
 by untrusted user, and we have to check the articles where it is included.
 But in this case it is not the template but a module.
 All these pages
 http://hu.wikipedia.org/wiki/Speci%C3%A1lis:Mi_hivatkozik_erre/Modul:Nyelvtani_modul
 have the same problem.
 On the other side, the history of the involved module:
 http://hu.wikipedia.org/wiki/Modul:Nyelvtani_modul shows that it was only
 edited by an admin and should be autochecked (or reviewed or patrollod or
 anything because I always mix these words in English but uselang=en shows
 checked).

 --
 Bináris




-- 
Bináris
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Flagged revs and Lua modules

2013-03-20 Thread Rob Lanphier
Hi Bináris,

Could you file a bug report for this?  I think I might be able to
tease out what the bug is from your email, but it would be a lot
better if you could document what the expected behavior is, and what
the actual behavior is.

Here's my attempt to describe the problem, but I don't want to file it
because I'm not sure I've got it right:

Subject: Lua modules don't get autochecked by FlaggedRevs when they should be

On Hungarian Wikipedia, we use FlaggedRevs and Scribunto.  Lua modules
seem to require manual checking on this wiki, even in cases that where
the user (such as an admin) should have had their edit autochecked

Example page where this happened:
http://hu.wikipedia.org/w/index.php?title=Abe_Sinz%C3%B3action=history

Repro steps:
1.  Edit a Lua module as a user with autocheck rights
2.  View the FlaggedRevs status of that page

Expected behavior:  the revised Lua module becomes the new checked
version of the page
Actual behavior: the unrevised Lua module remains the checked version
until someone checks the latest revision


Is that an accurate description of the problem?  Is that the only
problem, or are there multiple problems?  If this is correct, could
you file this as a bug?

Rob

On Tue, Mar 19, 2013 at 11:13 PM, Bináris wikipo...@gmail.com wrote:
 Please can anyone help to solve this issue? It causes a lot of extra work,
 thousands of unchecked pages.

 2013/3/18 Bináris wikipo...@gmail.com

 Hi,

 I don't know if there is a bugreport on this, forgive me if I duplicate.

 Hungarian Wikipedia began to use Scribunto in the first batch, and we also
 use Flagged Revisions.
 This is a page:
 http://hu.wikipedia.org/w/index.php?title=Abe_Sinz%C3%B3action=history
 where the editors were all trusted and/or bots, but the page had to be
 explicitliy checked. The behaviour is just like when a template is modified
 by untrusted user, and we have to check the articles where it is included.
 But in this case it is not the template but a module.
 All these pages
 http://hu.wikipedia.org/wiki/Speci%C3%A1lis:Mi_hivatkozik_erre/Modul:Nyelvtani_modul
 have the same problem.
 On the other side, the history of the involved module:
 http://hu.wikipedia.org/wiki/Modul:Nyelvtani_modul shows that it was only
 edited by an admin and should be autochecked (or reviewed or patrollod or
 anything because I always mix these words in English but uselang=en shows
 checked).

 --
 Bináris




 --
 Bináris
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Flagged revs and Lua modules

2013-03-18 Thread Bináris
Hi,

I don't know if there is a bugreport on this, forgive me if I duplicate.

Hungarian Wikipedia began to use Scribunto in the first batch, and we also
use Flagged Revisions.
This is a page:
http://hu.wikipedia.org/w/index.php?title=Abe_Sinz%C3%B3action=history
where the editors were all trusted and/or bots, but the page had to be
explicitliy checked. The behaviour is just like when a template is modified
by untrusted user, and we have to check the articles where it is included.
But in this case it is not the template but a module.
All these pages
http://hu.wikipedia.org/wiki/Speci%C3%A1lis:Mi_hivatkozik_erre/Modul:Nyelvtani_modul
have the same problem.
On the other side, the history of the involved module:
http://hu.wikipedia.org/wiki/Modul:Nyelvtani_modul shows that it was only
edited by an admin and should be autochecked (or reviewed or patrollod or
anything because I always mix these words in English but uselang=en shows
checked).

-- 
Bináris
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l