Re: [Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-29 Thread Jon Robson 
Krinkle fixed the immediate problem
I opened https://bugzilla.wikimedia.org/show_bug.cgi?id=64564 to
further optimise the mediawiki.util library


On Sun, Apr 27, 2014 at 11:23 AM, Krinkle  wrote:
> The module was split out of mediawiki.util, nothing new, no need for any 
> special treatment here.
>
> It should've been given the same "target" definition as mediawiki.util.
>
> — Krinkle
>
> On 27 Apr 2014, at 19:37, Jon Robson  wrote:
>
>> Looks like  jquery.accessKeyLabel now seems to be a required ResourceLoader
>> module.
>>
>> The patch that introduced it is
>> https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the
>> mobile site with 49 or 50 tests failing since the
>> merge.
>>
>> I'm not quite sure whether this module is useful on mobile. I'm not judging
>> that here - I just want to report this is a consideration.
>>
>> Seems we have 2 options
>> 1) Enable the module on mobile if it is applicable. If it's a small library
>> maybe decide on whether it is important later.
>> 2) Revert this core change and rethink this
>>
>> We need to do _one_ of the above before the next deployment train.
>>
>> The damage can be viewed at
>> http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically
>> JavaScript exception.
>>
>> Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512
>>
>>
>> On Sat, Apr 26, 2014 at 10:18 PM,  wrote:
>>
>>>  * FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome
>>> Build #409
>>> 
>>> (Sun, 27 Apr 2014 04:52:29 +)*
>>> *Test 
>>> Result*
>>> 50 failed, 20 skipped
>>>  Failed Tests  *Test Name**Duration**Age*  Check UI components.Check
>>> existence of important UI components on other 
>>> pages.22
>>> sec2
>>>   Encourage
>>> new users to Keep Going.I see a KeepGoing message after completing my
>>> VisualEditor 
>>> edit48
>>> sec2
>>>   Encourage
>>> new users to Keep Going.I see a KeepGoing message after completing my 
>>> edit52
>>> sec2
>>>   Generic
>>> special page features.Search from 
>>> Login39
>>> sec2
>>>   Generic
>>> special page features.Search from 
>>> Nearby10
>>> sec2
>>>   Generic
>>> special page features.Search from 
>>> Uploads2.2
>>> sec2
>>>   Generic
>>> special page features.Search from 
>>> Watchlist38
>>> sec2
>>>   Issues.Clicking
>>> page issues opens 
>>> overlay12
>>> sec2
>>>   Issues.Closing
>>> page 
>>> issues

Re: [Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-27 Thread Krinkle 
The module was split out of mediawiki.util, nothing new, no need for any 
special treatment here.

It should've been given the same "target" definition as mediawiki.util.

— Krinkle

On 27 Apr 2014, at 19:37, Jon Robson  wrote:

> Looks like  jquery.accessKeyLabel now seems to be a required ResourceLoader
> module.
> 
> The patch that introduced it is
> https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the
> mobile site with 49 or 50 tests failing since the
> merge.
> 
> I'm not quite sure whether this module is useful on mobile. I'm not judging
> that here - I just want to report this is a consideration.
> 
> Seems we have 2 options
> 1) Enable the module on mobile if it is applicable. If it's a small library
> maybe decide on whether it is important later.
> 2) Revert this core change and rethink this
> 
> We need to do _one_ of the above before the next deployment train.
> 
> The damage can be viewed at
> http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically
> JavaScript exception.
> 
> Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512
> 
> 
> On Sat, Apr 26, 2014 at 10:18 PM,  wrote:
> 
>>  * FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome
>> Build #409
>> 
>> (Sun, 27 Apr 2014 04:52:29 +)*
>> *Test 
>> Result*
>> 50 failed, 20 skipped
>>  Failed Tests  *Test Name**Duration**Age*  Check UI components.Check
>> existence of important UI components on other 
>> pages.22
>> sec2
>>   Encourage
>> new users to Keep Going.I see a KeepGoing message after completing my
>> VisualEditor 
>> edit48
>> sec2
>>   Encourage
>> new users to Keep Going.I see a KeepGoing message after completing my 
>> edit52
>> sec2
>>   Generic
>> special page features.Search from 
>> Login39
>> sec2
>>   Generic
>> special page features.Search from 
>> Nearby10
>> sec2
>>   Generic
>> special page features.Search from 
>> Uploads2.2
>> sec2
>>   Generic
>> special page features.Search from 
>> Watchlist38
>> sec2
>>   Issues.Clicking
>> page issues opens 
>> overlay12
>> sec2
>>   Issues.Closing
>> page 
>> issues12
>> sec2
>>   Issues.Closing
>> page issues (browser 
>> back)

[Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-27 Thread Jon Robson 
Looks like  jquery.accessKeyLabel now seems to be a required ResourceLoader
module.

The patch that introduced it is
https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the
mobile site with 49 or 50 tests failing since the
merge.

I'm not quite sure whether this module is useful on mobile. I'm not judging
that here - I just want to report this is a consideration.

Seems we have 2 options
1) Enable the module on mobile if it is applicable. If it's a small library
maybe decide on whether it is important later.
2) Revert this core change and rethink this

We need to do _one_ of the above before the next deployment train.

The damage can be viewed at
http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically
JavaScript exception.

Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512


On Sat, Apr 26, 2014 at 10:18 PM,  wrote:

>   * FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome
> Build #409
> 
> (Sun, 27 Apr 2014 04:52:29 +)*
> *Test 
> Result*
>  50 failed, 20 skipped
>   Failed Tests  *Test Name**Duration**Age*  Check UI components.Check
> existence of important UI components on other 
> pages.22
> sec2
>   Encourage
> new users to Keep Going.I see a KeepGoing message after completing my
> VisualEditor 
> edit48
> sec2
>   Encourage
> new users to Keep Going.I see a KeepGoing message after completing my 
> edit52
> sec2
>   Generic
> special page features.Search from 
> Login39
> sec2
>   Generic
> special page features.Search from 
> Nearby10
> sec2
>   Generic
> special page features.Search from 
> Uploads2.2
> sec2
>   Generic
> special page features.Search from 
> Watchlist38
> sec2
>   Issues.Clicking
> page issues opens 
> overlay12
> sec2
>   Issues.Closing
> page 
> issues12
> sec2
>   Issues.Closing
> page issues (browser 
> back)13
> sec2
>   Issues.I
> see the this page has issues 
> stamp