Re: [Wikitech-l] nstab-main caching

2009-01-08 Thread Chad
On Thu, Jan 8, 2009 at 8:45 PM, Aryeh Gregor

> wrote:

> On Thu, Jan 8, 2009 at 8:28 PM, K. Peachey  wrote:
> > How about creating something like [[Mediawiki:Nstab-mainpage]] which
> > would work the same way as [[Mediawiki:Nstab-main]] thus removing any
> > need for a paser-function ect, although it might not work for people
> > that redirect their Main Page to some other name.
>
> It seems unjustifiably narrow.
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

Indeed. We wouldn't even be having this conversation if people
were content with leaving nstab-main set to something that makes
sense for all pages in ns-0. Fwiw, I disagree with the parser
function too, as it will generate needless confusion. The entire
point of the nstab- messages are to give a consistent tab name
for all pages in a given namespace. Once you introduce the ability
to customize it per page, you ruin its original meaning.

-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-08 Thread Aryeh Gregor
On Thu, Jan 8, 2009 at 8:28 PM, K. Peachey  wrote:
> How about creating something like [[Mediawiki:Nstab-mainpage]] which
> would work the same way as [[Mediawiki:Nstab-main]] thus removing any
> need for a paser-function ect, although it might not work for people
> that redirect their Main Page to some other name.

It seems unjustifiably narrow.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-08 Thread K. Peachey
How about creating something like [[Mediawiki:Nstab-mainpage]] which
would work the same way as [[Mediawiki:Nstab-main]] thus removing any
need for a paser-function ect, although it might not work for people
that redirect their Main Page to some other name.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-08 Thread Brion Vibber
On 1/7/09 2:26 PM, Aryeh Gregor wrote:
> On Wed, Jan 7, 2009 at 4:41 PM, Brion Vibber  wrote:
>> Hmm, this would require either parsing the page when you're on 'edit',
>> 'history', 'watch' or other tabs, or storing that info elsewhere.
>> Further requiring it to set both the article and the talk tabs means
>> they can be inconsistent between the subject and talk pages.
>
> It could be stored in the page_props table.  This is the kind of thing
> it's for, really.  In fact, display title could be stored there as
> well -- that would make that feature a lot nicer and cleaner without
> requiring schema changes.

H, that gives me a warm fuzzy feeling.

-- brion

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-07 Thread Aryeh Gregor
On Wed, Jan 7, 2009 at 4:41 PM, Brion Vibber  wrote:
> Hmm, this would require either parsing the page when you're on 'edit',
> 'history', 'watch' or other tabs, or storing that info elsewhere.
> Further requiring it to set both the article and the talk tabs means
> they can be inconsistent between the subject and talk pages.

It could be stored in the page_props table.  This is the kind of thing
it's for, really.  In fact, display title could be stored there as
well -- that would make that feature a lot nicer and cleaner without
requiring schema changes.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-07 Thread Brion Vibber
On 1/6/09 7:39 PM, Tim Starling wrote:
> Remember the dot wrote:
>> Hello,
>>
>> The discussion about nstab-main and the main page has flared up again:
>> http://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Main_Page_tab
>>
>> It was suggested in bug 14267 that the contents of nstab-main could be
>> cached with the page title, so that we could include a ParserFunctions
>> workaround in it without having the parser function execute on every page
>> load. What are your opinions on this?
>>
>> See https://bugzilla.wikimedia.org/show_bug.cgi?id=14267#c5
>
> I think a parser function that sets tab text directly would be better,
> e.g. {{#settab:nstab|Main Page}}{{#settab:talk|Main Page discussion}}

Hmm, this would require either parsing the page when you're on 'edit', 
'history', 'watch' or other tabs, or storing that info elsewhere. 
Further requiring it to set both the article and the talk tabs means 
they can be inconsistent between the subject and talk pages.

-- brion

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-07 Thread Mark Clements (HappyDog)
"Aryeh Gregor"  wrote in message 
news:7c2a12e20901071221w43eef7b5ld19e3ba47760d...@mail.gmail.com...
> On Wed, Jan 7, 2009 at 3:17 PM, Mark Clements (HappyDog)
>  wrote:
>> And that should be in an extension.
>
> Probably ParserFunctions.

I think not.  ParserFunctions should not have interface-specific code.  It 
could be a dedicated 'CustomiseTabs' extension, or a more general 
'InterfaceTweaks' extension (which will allow for other UI modifiers to be 
added).

- Mark Clements (HappyDog) 



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-07 Thread Aryeh Gregor
On Wed, Jan 7, 2009 at 3:17 PM, Mark Clements (HappyDog)
 wrote:
> And that should be in an extension.

Probably ParserFunctions.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-07 Thread Mark Clements (HappyDog)
"Tim Starling"  wrote in message 
news:gk185q$lt...@ger.gmane.org...
> Remember the dot wrote:
>> Hello,
>>
>> The discussion about nstab-main and the main page has flared up again:
>> http://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Main_Page_tab
>>
>> It was suggested in bug 14267 that the contents of nstab-main could be
>> cached with the page title, so that we could include a ParserFunctions
>> workaround in it without having the parser function execute on every page
>> load. What are your opinions on this?
>>
>> See https://bugzilla.wikimedia.org/show_bug.cgi?id=14267#c5
>
> I think a parser function that sets tab text directly would be better,
> e.g. {{#settab:nstab|Main Page}}{{#settab:talk|Main Page discussion}}
>

And that should be in an extension.

- Mark Clements (HappyDog) 



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] nstab-main caching

2009-01-06 Thread Tim Starling
Remember the dot wrote:
> Hello,
> 
> The discussion about nstab-main and the main page has flared up again:
> http://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Main_Page_tab
> 
> It was suggested in bug 14267 that the contents of nstab-main could be
> cached with the page title, so that we could include a ParserFunctions
> workaround in it without having the parser function execute on every page
> load. What are your opinions on this?
> 
> See https://bugzilla.wikimedia.org/show_bug.cgi?id=14267#c5

I think a parser function that sets tab text directly would be better,
e.g. {{#settab:nstab|Main Page}}{{#settab:talk|Main Page discussion}}

-- Tim Starling


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[Wikitech-l] nstab-main caching

2009-01-06 Thread Remember the dot
Hello,

The discussion about nstab-main and the main page has flared up again:
http://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Main_Page_tab

It was suggested in bug 14267 that the contents of nstab-main could be
cached with the page title, so that we could include a ParserFunctions
workaround in it without having the parser function execute on every page
load. What are your opinions on this?

See https://bugzilla.wikimedia.org/show_bug.cgi?id=14267#c5

-- 
Remember the dot
http://en.wikipedia.org/wiki/User:Remember_the_dot
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l