Re: RFC: System metrics changes
On Fri, 22 Sep 2000, Ulrich Weigand wrote: Running the system metrics sample in the Petzold in both Wine and Windows 98 showed a lot of differences. So I started hacking windows/sysmetrics.c and the result of this is the attached patch. With this patch all the differences listed below disapeared. Well, you can't really talk about the 'Win98 values' as such, since many (most) of these sysmetrics values can be modified by the user in Win9x (through the Control Panel / Desktop), and are stored in the registry ... It looks like this is already what we do: We call PROFILE_GetWineIniIntThis in a few places and most of the other values are derived from them. Even if you don't modify them yourself, the default values are not always the same but depend on things like whether you chose 'small fonts' or 'large fonts' IIRC. I'll try to test that. Hum, it looks like the best thing to do would be to write a simple program that dumps all the system metric to a file so that I can then compare the values between systems. Actually such a test could even be part of a regression test suite... -- Francois Gouget [EMAIL PROTECTED]http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.
Re: RFC: System metrics changes
Andreas Mohr wrote: On Fri, Sep 22, 2000 at 11:50:12AM -0700, Francois Gouget wrote: [...] But I have the feeling that system metrics is a delicate subject, especially because of the platform variations: win3.1, win9x, win nt, win2000. I hope to run compare the results with a Windows 95 machine tonight but I don't have access to the other platforms. So I would like your feed-back on the attached patch. Is there some parts that belong to a Win9x only section? Does anyone know if it breaks things for Windows 3.1? YES, it *definitely* does ! (I checked it some time ago and even tried to fix it, but didn't) Do you remember what were the problems? Please only reimplement it by keeping the Win3.1 values ! Ok, I'm rewriting it by systematically testing for TWEAK_WineLook. BTW, does anyone know which of these metrics are Win32 only? -- Francois Gouget [EMAIL PROTECTED]
